From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#57066: 29.0.50; Complex emoji overlaps with text Date: Thu, 11 Aug 2022 09:35:42 +0300 Message-ID: <87r11nb83l.fsf@protesilaos.com> References: <87r11pzsgb.fsf@protesilaos.com> <83iln1vfbl.fsf@gnu.org> <87o7wtzmdn.fsf@protesilaos.com> <837d3hvd5j.fsf@gnu.org> <87lerxzim5.fsf@protesilaos.com> <835yj1v1vy.fsf@gnu.org> <87czd9pc9z.fsf@protesilaos.com> <83iln1tjap.fsf@gnu.org> <877d3hpb55.fsf@protesilaos.com> <83bkstti9j.fsf@gnu.org> <87bkssn60s.fsf@protesilaos.com> <83zggcqnvz.fsf@gnu.org> <87edxnqv88.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36473"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.36 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , 57066@debbugs.gnu.org To: YAMAMOTO Mitsuharu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 11 08:36:47 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oM1oF-0009L8-CB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Aug 2022 08:36:47 +0200 Original-Received: from localhost ([::1]:59554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oM1oE-0007JH-0h for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Aug 2022 02:36:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oM1nc-0007Ix-7A for bug-gnu-emacs@gnu.org; Thu, 11 Aug 2022 02:36:13 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33265) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oM1nW-0001LP-Kj for bug-gnu-emacs@gnu.org; Thu, 11 Aug 2022 02:36:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oM1nW-0005I9-G0 for bug-gnu-emacs@gnu.org; Thu, 11 Aug 2022 02:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Aug 2022 06:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57066 X-GNU-PR-Package: emacs Original-Received: via spool by 57066-submit@debbugs.gnu.org id=B57066.166019975520329 (code B ref 57066); Thu, 11 Aug 2022 06:36:02 +0000 Original-Received: (at 57066) by debbugs.gnu.org; 11 Aug 2022 06:35:55 +0000 Original-Received: from localhost ([127.0.0.1]:51247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM1nP-0005Ho-51 for submit@debbugs.gnu.org; Thu, 11 Aug 2022 02:35:55 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:37689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM1nN-0005Ha-58 for 57066@debbugs.gnu.org; Thu, 11 Aug 2022 02:35:53 -0400 Original-Received: (Authenticated sender: public@protesilaos.com) by mail.gandi.net (Postfix) with ESMTPSA id E686B1BF204; Thu, 11 Aug 2022 06:35:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1660199747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kAUj4xSYHjmhTT/+dRinC7mj9ZVu8AWclRh5OBzeCL8=; b=mweSWxxbjgxbI7WFG/LCvbTHzbmetLU++DgLD/j/z0wwnnPzOEnm1af6xROf4KjKZf6E3C KSQ6qAFYY4UZuIZYsoXCMlvyvfDEBYjRBuy9c8FAzqspPO8d8w/LO8FlMHLVbXeNiQ7qmz Ob0YArgEAJGfWs0n+EYr+uULEvy+KkG3hPw3Wmg0MDIGhOWdmzD90YHu1UDvXfS9pVAGOG V8Cl4fPJjMltEg5n/rHoJw20fV+j8mfKFdURY2DYykTuzrNvFswq7yup8gqn/+NBeRkJdL 5+DF7AZjh22lx7rMtWK9HarfDhZ1/k5Y0jjfW1U0QTuNTI1LDJewXifNtkbXpg== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239332 Archived-At: > From: YAMAMOTO Mitsuharu > Date: Thu, 11 Aug 2022 15:24:38 +0900 > > Oops, it breaks non-HarfBuzz builds. Pleae try below instead. > > YAMAMOTO Mitsuharu > mituharu@math.s.chiba-u.ac.jp > > diff --git a/src/ftcrfont.c b/src/ftcrfont.c > index 39ea068556..d5d3e440af 100644 > --- a/src/ftcrfont.c > +++ b/src/ftcrfont.c > @@ -568,7 +568,11 @@ ftcrhbfont_begin_hb_font (struct font *font, double *position_unit) > > ftcrfont_info->ft_size = ft_face->size; > hb_font_t *hb_font = fthbfont_begin_hb_font (font, position_unit); > - if (ftcrfont_info->bitmap_position_unit) > + /* HarfBuzz 5 correctly scales bitmap-only fonts without position > + unit adjustment. > + (https://github.com/harfbuzz/harfbuzz/issues/489) */ > + if (!hb_version_atleast (5, 0, 0) > + && ftcrfont_info->bitmap_position_unit) > *position_unit = ftcrfont_info->bitmap_position_unit; > > return hb_font; Thank you! I just tried it and it works on my end. I only tested it with a regular 'make'. Do you want me to use other build options as well? -- Protesilaos Stavrou https://protesilaos.com