From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Amin Bandali Newsgroups: gmane.emacs.bugs Subject: bug#29108: 25.3; ERC SASL support Date: Wed, 23 Nov 2022 21:49:23 -0500 Message-ID: <87r0xtnk24.fsf__24671.6737326764$1669258230$gmane$org@gnu.org> References: <87h8ud92zl.fsf@gmail.com> <874jx4h6sk.fsf@neverwas.me> <875yhifujk.fsf_-_@neverwas.me> <87edw4swdk.fsf@neverwas.me> <878rljxfxs.fsf@neverwas.me> <87k04m4th8.fsf@neverwas.me> <87o7thlepf.fsf@neverwas.me> <87o7taoohd.fsf@neverwas.me> <87a64unifk.fsf@neverwas.me> <87y1sdk1fg.fsf@neverwas.me> <875yfflzps.fsf@neverwas.me> <878rk9576b.fsf@neverwas.me> <87leo8z79j.fsf@neverwas.me> <87tu2vroeh.fsf@neverwas.me> <87wn7pog1l.fsf@neverwas.me> <87y1s4mjj6.fsf@neverwas.me> <87r0xvks03.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5018"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org, 29108-done@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 24 03:50:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oy2Jh-00017X-Ns for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Nov 2022 03:50:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oy2JQ-0005tU-4H; Wed, 23 Nov 2022 21:50:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oy2JO-0005tH-UU for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 21:50:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oy2JO-0000Uw-JY for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 21:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oy2JO-0002JA-45 for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 21:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Amin Bandali Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Nov 2022 02:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29108 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29108-done@debbugs.gnu.org id=D29108.16692581798834 (code D ref 29108); Thu, 24 Nov 2022 02:50:02 +0000 Original-Received: (at 29108-done) by debbugs.gnu.org; 24 Nov 2022 02:49:39 +0000 Original-Received: from localhost ([127.0.0.1]:56757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oy2J0-0002IQ-Uj for submit@debbugs.gnu.org; Wed, 23 Nov 2022 21:49:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oy2Ix-0002IC-S6 for 29108-done@debbugs.gnu.org; Wed, 23 Nov 2022 21:49:36 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oy2Ir-0000OD-Kp; Wed, 23 Nov 2022 21:49:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/z48QSYHh3JfhJ4F2IJjE8/UhLmkWoUO6CjZVD7NbXM=; b=HANQLPugkcdCtAps6hck d/N1e9ZIPf6emg+ZoO29j+/KVRlK3cifpJAjOklmD3aPJa+pcxkDRMoh1ozZBgvwTQOzL6Agx4+Gv iLm8QOLjZFZd9JyTLU0CR/WvwVLvciW0Ld3Ie1UKWf/X8+89LC+aJZNKy6r4ByGj6g9lRayRVbgry vmfxidh8F/TNiUPjl1/gc1XkExD4mMsPIODYZCK7VxvX/4NwzwLJMwUekHZ6e+GA1VTgTLNKPWvj9 7xO0tVs1C5TDGqKtonI7aD0D8hKqdnsqMMe2P38VQz9Lgy+YQL0wTRnx/v4BfZIE2lKInF537VUvB z2kc/OhSLX6vCQ==; Original-Received: from [142.189.234.118] (helo=langa) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oy2Im-0003t6-P3; Wed, 23 Nov 2022 21:49:26 -0500 In-Reply-To: <87r0xvks03.fsf@neverwas.me> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248803 Archived-At: Hey J.P., (all,) J.P. writes: > v14. Revised docs a bit and renamed some compat functions. Added a 900 > handler to erc-backend. Added secrets-wrapping for auth-source-pass > results in erc-compat. Ditched hook indirection for AUTHENTICATE > handler. > Thanks! I've pushed all of these patches. All but one of them were committed without any additional changes; and that one was 0006-Add-non-IRCv3-SASL-module-to-ERC.patch, where I just added the missing entries for doc/misc/erc.texi and etc/ERC-NEWS to the commit message. > Subject: [PATCH 4/8] Support local ERC modules in erc-mode buffers [...] > diff --git a/doc/misc/erc.texi b/doc/misc/erc.texi > index 0d807e323e..b9c6e33d36 100644 > --- a/doc/misc/erc.texi > +++ b/doc/misc/erc.texi > @@ -390,8 +390,11 @@ Modules > > There is a spiffy customize interface, which may be reached by typing > @kbd{M-x customize-option @key{RET} erc-modules @key{RET}}. > -Alternatively, set @code{erc-modules} manually and then call > -@code{erc-update-modules}. > +When removing a module outside of the Custom ecosystem, you may wish > +to ensure it's disabled by invoking its associated minor-mode toggle, > +such as @kbd{M-x erc-spelling-mode @key{RET}}. Note that, these days, > +calling @code{erc-update-modules} in an init file is typically > +unnecessary. What do you think about tweaking the last sentence to be more specific about when calling `erc-update-modules' may still be needed, maybe with a short example, please? > Subject: [PATCH 6/8] Add non-IRCv3 SASL module to ERC [...] > diff --git a/doc/misc/erc.texi b/doc/misc/erc.texi [...] What do you think about adding a few short examples to the manual showing the usage of each of the variants/mechanisms with a call to `erc-tls'? Kind of like the ones in "Connecting to an IRC Server" that show how to use `:client-certificate' for instance. Many thanks for all of your work on implementing and landing SASL support for ERC, a feature that many ERC users (myself included) have wished for and looked forward to seeing in ERC for years! -amin