From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry Date: Sun, 27 Nov 2022 08:51:09 +0800 Message-ID: <87r0xpw77m.fsf@yahoo.com> References: <87tu2wlku7.fsf@elite.giraud> <878rk8ee6d.fsf@yahoo.com> <8735agr0g4.fsf@elite.giraud> <83o7t4bhk4.fsf@gnu.org> <87zgcov1ps.fsf@elite.giraud> <8335agbai5.fsf@gnu.org> <875yfcuw5r.fsf@elite.giraud> <83r0y09td6.fsf@gnu.org> <87zgcotbw9.fsf@elite.giraud> <83iljc9k5s.fsf@gnu.org> <871qpt7hac.fsf@elite.giraud> <83y1s1y3vg.fsf@gnu.org> <87fse7jd7t.fsf@elite.giraud> <8735a7jczf.fsf@elite.giraud> <8335a5ubgr.fsf@gnu.org> <87sfi5aaph.fsf@elite.giraud> <834julsjjz.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11770"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59351@debbugs.gnu.org, Manuel Giraud To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 27 01:52:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oz5u2-0002pS-CW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Nov 2022 01:52:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oz5tw-0006F5-F2; Sat, 26 Nov 2022 19:52:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz5tr-0006Ed-UV for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 19:52:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oz5tq-0000RI-Sb for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 19:52:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oz5tq-0000zj-9L for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 19:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Nov 2022 00:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59351 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59351-submit@debbugs.gnu.org id=B59351.16695102903816 (code B ref 59351); Sun, 27 Nov 2022 00:52:02 +0000 Original-Received: (at 59351) by debbugs.gnu.org; 27 Nov 2022 00:51:30 +0000 Original-Received: from localhost ([127.0.0.1]:41736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz5tK-0000zU-6B for submit@debbugs.gnu.org; Sat, 26 Nov 2022 19:51:30 -0500 Original-Received: from sonic309-22.consmr.mail.ne1.yahoo.com ([66.163.184.148]:35584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz5tG-0000zM-Ql for 59351@debbugs.gnu.org; Sat, 26 Nov 2022 19:51:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1669510279; bh=GsqhdMDO4hvWNriJc3DuqSxxmUVQScKXpxnv7HJdskk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=AzAgsHjVNbu11x+7hID6Yh9nOZIIejeGQ1Nl5taQuYcDdRenNix2HJffGziE6NVCPZ1q3lHO53QKWhHGvKFZ0W6oyUb1m4eQRE0BdVe88NOjKffLE3Xl2Q79LE9Ccbv7ebunMM7l1brPcYc53I7BL+K3hm+Ke60OMGsqQlGXQFBZtbfP0WMa6yRZ93a4evLb2QK0SBI5LKnwpx5AArFh5/24iUkUMFCtWh/nRBC6wmiPW2Lix/csJVtEDHhd4HAC+BrEw0z0awZcM5SAwv+OeRoW4VHjDhspcOrpSi95S3YbuPYuvt/rfFUKetAcpYuy6Biml365YzrSxY8z2VPvKw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1669510279; bh=fPlf+D+bejOP4XXm/xLojo67O/nIUs/IfyqVa2ioXAE=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=I/xXSamFzqg+Zej7E7unz25K3g/CttHGedB4xSa6xR+oNC6Lnz/m8lX3GQT3PHKt8fUig2kKq13DqA8oeDMFwIYs/xN7CEBb070VghuRL+dGVmKKFLJcuhYyYby9OTp2EVe7p1r4LWSoBEKEKC0feJ4eWr/VTBROI3Oy5UfHwSljcK6uhDO/56Ey4GYixRFPleF7vZ/8q9DffHx1VwvRPRIhl9hrPt8/yxYrbclAL19MsqJJvVih9NQ50iFsJOyOo99mfgYJ3HTHs73nQIi7/gdgSDOHtDD7yVhBNnYne9yuYEABjgmMadt73WbZykzvfx2BpLwlcCbF9IPv2OWsEw== X-YMail-OSG: fCLcjN4VM1lhVX6WayMxcoCpQBCGmDuMNRawlDUZ8g2Oy7JcbIv6mwMtaco1tO0 ygJaydsLv1ZeQfDzMQ5Ca0jrhETSHspuKu8CI8545q7D6pzqHYn1pphiepl90extfvC6Qt.cYGl9 kZmS2lethjHFcL1MrUgTq5_qgoVBXq0Pj.ze2twVJuaqptuQCbgEs6vMuGBo0GMWO14wWHoi3FzM B4F.zdG1ZnLnROqd4RIvSe7s7iuN3XfMXcU1goUSppl98Pw0eBkV2dfSP7n95.j5xjDPH_IJJmbx 7wYnhYXRmYn3Phi_OW2WtEIi.RQnpgp1ddQd70L3fqcnE3Ly5mDTaZOmL6OPAVPA4HIyWuIcQzii OyWKVu.g0ZICV42p.BPhIcAAsCLqKe6Mcc_QqnpHt3mvan2VdJla4U48sruywywfrLgSZG7BpTWO MOnbaB5N1fRkOcnqkGiaqPi3ZCOegtMGCpn1joL6AGGG.CE9B8rDZmVL1ej0G7hSY1SdWmDOyiWh mfyLSsmZJX8bN.QHJrrG_kts6XPFBT4QWvnisdGZPnh2k45oXM.DJLZPaqrKoJSv7q27Fk8nZEcC WTLX9W94YWXVQAfRAGwhZOfOTYHzkqKqmu9tQaT7UQZPSERwG30eylmjt_p.aRU8T3FkiwV2uAx2 6LBssd6lpsB9RmZpBVBz83mv8vgkUM3anqcak.ZUGfXHwVTXRl7qVwiZA6xdG5jpNTvpYpSs4iZu 9VAI1rP2iwz9My7JuPv.vMZ6IhcEluHcETEYLPUP1EDHfQtMgJ07WlmPBhxI2gxsDsLYkdx3LSZy k6NaLZwkVbc_PhbmVqdbbnIvEdnE12haTMjAEHSN89 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ne1.yahoo.com with HTTP; Sun, 27 Nov 2022 00:51:19 +0000 Original-Received: by hermes--production-sg3-6c8895b545-25cjq (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 88bbadba518761a474f120abe0b82729; Sun, 27 Nov 2022 00:51:15 +0000 (UTC) In-Reply-To: <834julsjjz.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 26 Nov 2022 19:38:08 +0200") X-Mailer: WebService/1.1.20863 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249156 Archived-At: Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: luangruo@yahoo.com, 59351@debbugs.gnu.org >> Date: Sat, 26 Nov 2022 18:26:34 +0100 >> >> Eli Zaretskii writes: >> >> [...] >> >> > The idea looks correct, thanks. What exactly prevents this from working >> > with multiple windows on the same frame? >> >> For instance, when vertically split (by C-x 3), the other window is not >> correctly redrawn (text area is above menu bar). Everything is then >> fixed by the next unsplit/split. Maybe, I should have use >> adjust_frame_size here. > > In redisplay_internal, we have: > > if (FRAME_VISIBLE_P (f) && !FRAME_OBSCURED_P (f)) > { > /* If fonts changed on visible frame, display again. */ > if (f->fonts_changed) > { > adjust_frame_glyphs (f); > /* Disable all redisplay optimizations for this > frame. For the reasons, see the comment near > the previous call to adjust_frame_glyphs above. */ > SET_FRAME_GARBAGED (f); > f->fonts_changed = false; > goto retry_frame; > } > > It sounds like this part is not being run in your case, so please try to > figure out why. I think if the above code runs, what you want to do will > happen automatically. Now, before adding more calls to adjust_frame_size, please wait for Emacs 29 to be cut first. That function tends to interact with X window managers in different ways on builds with different toolkits, so adding or removing calls to it is very likely to break stuff.