From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#60147: 30.0.50; vc-prepare-patch: Add numbered patch file names Date: Sat, 17 Dec 2022 17:33:30 -0700 Message-ID: <87r0wxv9d1.fsf@melete.silentflame.com> References: <87y1r64bof.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5774"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 60147@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 18 01:34:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6hd9-0001G7-Jn for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Dec 2022 01:34:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6hcx-0007Ib-9a; Sat, 17 Dec 2022 19:34:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6hcw-0007IO-Ce for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 19:34:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6hcw-0005ui-4x for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 19:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p6hcw-0006JA-0Z for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 19:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Dec 2022 00:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60147 X-GNU-PR-Package: emacs Original-Received: via spool by 60147-submit@debbugs.gnu.org id=B60147.167132361924239 (code B ref 60147); Sun, 18 Dec 2022 00:34:01 +0000 Original-Received: (at 60147) by debbugs.gnu.org; 18 Dec 2022 00:33:39 +0000 Original-Received: from localhost ([127.0.0.1]:58876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6hcY-0006It-K9 for submit@debbugs.gnu.org; Sat, 17 Dec 2022 19:33:38 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:45583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6hcW-0006In-PX for 60147@debbugs.gnu.org; Sat, 17 Dec 2022 19:33:37 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 75AAC5C0080; Sat, 17 Dec 2022 19:33:31 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 17 Dec 2022 19:33:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1671323611; x=1671410011; bh=7O c7yE6tJY0IWpvx21Sz6778ovNpNxt13nrsO1o64UI=; b=M5lI4mZKYcpzNLVJor VWA1q9fEwO7LNjvMj+wrzO7Y/G29UxBjyC8IB12BYemf3B/CuK3fpMXVmupIb3zI jdwEJiGAF3VKuecC/xIjlXLywWEOM9I0kxVLkQptIktreVsX6Erc2VBcG5gs73i2 xj0Y9QJ8Ko6Q9m6+ADdEe0Br0gxeffbbAxfIJDZS+X42LjIUL4GOzRbr5oPVmcNb TwInoitmD6GcEUT9BT/grf3RmRRttyVRBWwOw3sE4ucFJ4GD2J3QWa6iQpaIbACg R74TIkgeGh38b5qgmimDrOEaX6wMblf0pSz0fN16HGEnIXcCcQoLvIn6UxPXAXby kwfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1671323611; x=1671410011; bh=7Oc7yE6tJY0IWpvx21Sz6778ovNp Nxt13nrsO1o64UI=; b=V0wt+5xWOqx4X4JVps5xDq4aHBSqlVitL2FDpWyWEffn Sxof6xE51Y3BwQQVym6mE4qzDWI9Q1NE+jE+RuY5iBh/5sWxuGMIhh0hAzdITTDG lkE8mu5WvWv1x2Q/kIDOWIuEIuvvyz2/75I8B56CXvY06/acLI4OakBx6/r27u97 /sCoK6RVw+9nwP3sgkDutKN2k/TBXHfCtN4ffB9+CR6aJ/sKytkPAYr/mP6x2RHT Yc65Y28YVZdtyW8KruqMY4W1NvYoBN0DCuMO7491o+I9SNj2dMqL9OQLc19canIY gizMs2J2SfEn8C3mq2R3Q9ky5pktK2AyDL/CbtiyLw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedtgddvvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedukeeg geelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 17 Dec 2022 19:33:30 -0500 (EST) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 3266E7EA019; Sat, 17 Dec 2022 17:33:30 -0700 (MST) In-Reply-To: <87y1r64bof.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 17 Dec 2022 09:33:20 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251325 Archived-At: Hello, On Sat 17 Dec 2022 at 09:33AM GMT, Philip Kaludercic wrote: >> + (filename >> + (concat >> + (string-trim >> + (replace-regexp-in-string >> + "\\W" "-" (if (length> stripped-subject 50) >> + (substring stripped-subject 0 50) >> + stripped-subject)) > > Is limiting the file names to ~50 characters a Git thing? Git does it, yes, and I thought it seemed like a good idea in general. >> + (mml-attach-buffer >> + (buffer-name (plist-get patch :buffer)) >> + "text/x-patch" >> + patch-subject >> + "attachment" >> + (format "%04d-%s" (cl-incf i) filename)))))) > > Is the new additional argument really necessary, or couldn't we just > rename the generated buffer? We could specify that the buffer must be > fresh/renameable. The description and the filename for an attachment are not the same thing -- I don't believe MUAs will save the files with the correct name unless there is the filename= field. And I think it's a useful general addition to mml-attach-buffer. -- Sean Whitton