From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#61726: [PATCH] Eglot: Support positionEncoding capability Date: Fri, 24 Feb 2023 16:56:57 +0100 Message-ID: <87r0uf83au.fsf@gmail.com> References: <87a614g628.fsf@gmail.com> <875ybsfvtj.fsf@gmail.com> <831qmgr17p.fsf@gnu.org> <87wn48ecdz.fsf@gmail.com> <83v8jspgnr.fsf@gnu.org> <87lekodxja.fsf@gmail.com> <83a614p4sh.fsf@gnu.org> <87cz60dus9.fsf@gmail.com> <835ybrpnqj.fsf@gnu.org> <87y1oncz09.fsf@gmail.com> <83r0ufo3uc.fsf@gnu.org> <87356vbf0b.fsf@gmail.com> <83pm9znw0i.fsf@gnu.org> <87lekn9ss3.fsf@gmail.com> <83h6vbntqd.fsf@gnu.org> <878rgn9r6u.fsf@gmail.com> <83edqfnq5u.fsf@gnu.org> <87zg93866h.fsf@gmail.com> <83356vnl3m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25224"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61726@debbugs.gnu.org, joaotavora@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 24 16:59:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVaTs-0006JS-HZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Feb 2023 16:59:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVaSV-0004Vj-NS; Fri, 24 Feb 2023 10:58:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVaSR-0004OM-D5 for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 10:58:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVaSR-0006jk-0n for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 10:58:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVaSQ-00023u-Rv for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 10:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Feb 2023 15:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61726 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61726-submit@debbugs.gnu.org id=B61726.16772542287823 (code B ref 61726); Fri, 24 Feb 2023 15:58:02 +0000 Original-Received: (at 61726) by debbugs.gnu.org; 24 Feb 2023 15:57:08 +0000 Original-Received: from localhost ([127.0.0.1]:37991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVaRX-000225-W2 for submit@debbugs.gnu.org; Fri, 24 Feb 2023 10:57:08 -0500 Original-Received: from mail-ed1-f48.google.com ([209.85.208.48]:36617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVaRV-00021U-JX for 61726@debbugs.gnu.org; Fri, 24 Feb 2023 10:57:06 -0500 Original-Received: by mail-ed1-f48.google.com with SMTP id da10so57766384edb.3 for <61726@debbugs.gnu.org>; Fri, 24 Feb 2023 07:57:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=R2qfY1l3WdhnqKbyHf2IQS/02oDcCk/aLSbjTGoxum8=; b=kE6n2W5dYZF2wz+SiNeGioexum+lbHJouFwv1QvCFRDLp0537voyVbDYeWZrRUENvA WXaAc37gUgxeL2sCDJwBXryyig97TrmxZ5KgEwlD/XpE3XQjDqcgwadU+sTV7fAO1ql0 6jmBRlro7U0bCgL+mRPwhjSVo/4Kyka8qHPZQ0mOXDIydekGCXjgYA2LFfxFZhi6u+RO NmD1xqB2xKvc2zT7S4EmNzh35tKCfBYDzr27FsBeptnGKKhm3wWx0pvy3T3IMELFQg5I K9zD+3JSqQc/T27id5Cwv7s3qHiymkpbZGmol7vDhnEEs8Yjp3hTeKuagOSXV0ednke3 salQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R2qfY1l3WdhnqKbyHf2IQS/02oDcCk/aLSbjTGoxum8=; b=fTajHvKQ3DH0/uCik/ZXIvuKGvQKyFRW7VgasYu9ms1PtigKBjH5xEcKtLtG4RtyQ5 ZocHxcpSBYvCakHMJDQPAAdSaQCf/nSvJrHRoO+sL+O46bcN2BY6zYFXqxiLjSjobyHS sX3HtWHPyHSeVedbRB2w3Ql4dUYF2bWSo9QrOUtQN0JLSWS82HVhWiGChYsI6Hi5PWsp Fqu6YZi5NOt5bmI8fMjPQFYJyB5t2NAOkmkITdooI3rbWTuLeIggoQ6oWK6EZtjq/RV5 c8CNfW787/O3sO81Fso2HYi0NdY1RDvhChqGiczgS6G3UgyrwQlnaOg2YecKGeJDJf0w y2xg== X-Gm-Message-State: AO0yUKUDdrEDhACM/V1ey+dwcgh2Im0rrraIKxGgZtTuiRKd0D6c+lQE 1ObLTb8cC1zXWixo0WFy71YycbKL/rQ= X-Google-Smtp-Source: AK7set8h5J4BoZmaQfgqMrer94EA3WCSsJFkdrERY1cDT7wQKUsOvbJw7+ONE5WtQpWZbysFQim9NA== X-Received: by 2002:aa7:da97:0:b0:4aa:a0ed:e373 with SMTP id q23-20020aa7da97000000b004aaa0ede373mr13388401eds.7.1677254219496; Fri, 24 Feb 2023 07:56:59 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::6fd0]) by smtp.gmail.com with ESMTPSA id by17-20020a0564021b1100b004aef48a8af7sm5803257edb.50.2023.02.24.07.56.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 07:56:58 -0800 (PST) In-Reply-To: <83356vnl3m.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 24 Feb 2023 17:23:25 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256625 Archived-At: On Fri, 24 Feb 2023 at 17:23, Eli Zaretskii wrote: > It is not more expensive. The underlying functions we call are > already capable of producing replacements instead of characters that > cannot be encoded in UTF-8. We just don't use those capabilities in > json.c because some of us had strong feelings about signaling an error > in these situations. I didn't track down byte-to-position and position-bytes in the C code. So you are saying they're as expensive as encode-coding-string? If (and only if) this is the case, then I take back my point :-). > What if json-serialize stops signaling an error at some point, and > instead uses the replacement mechanism I mentioned above? In the other message I explained why I think this is exactly what we should _not_ do.