From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#61350: Eglot over Tramp freezes with large project Date: Tue, 07 Mar 2023 14:52:30 +0100 Message-ID: <87r0u0u0rl.fsf@gmx.de> References: <87y1ootw2t.fsf@gmail.com> <878rglxrzm.fsf@gmail.com> <87cz5wmjbx.fsf@gmx.de> <87h6v8f7u9.fsf@gmail.com> <87o7pflfcd.fsf@gmx.de> <87wn43e9ht.fsf@gmail.com> <874jr6oont.fsf@gmx.de> <87sfeqd4zi.fsf@gmail.com> <877cw1swjm.fsf@gmx.de> <87k0016dgo.fsf@gmx.de> <1458446553.50372.1677606917251@office.mailbox.org> <87ilfkh89k.fsf@gmail.com> <87y1ofct83.fsf@gmx.de> <87356n8kja.fsf@gmail.com> <877cvvfnp6.fsf@gmx.de> <54377687.213790.1678016749459@office.mailbox.org> <87356jfktc.fsf@gmx.de> <87a60ovi90.fsf@gmx.de> <31964054.380679.1678194256931@office.mailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31880"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Thomas Koch , 61350@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 07 14:53:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZXkb-0008C3-Fi for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Mar 2023 14:53:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZXkW-00075E-8r; Tue, 07 Mar 2023 08:53:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZXkU-000744-FQ for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 08:53:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZXkU-0008DH-7R for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 08:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZXkU-00045C-4L for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 08:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Mar 2023 13:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61350 X-GNU-PR-Package: emacs Original-Received: via spool by 61350-submit@debbugs.gnu.org id=B61350.167819716215669 (code B ref 61350); Tue, 07 Mar 2023 13:53:02 +0000 Original-Received: (at 61350) by debbugs.gnu.org; 7 Mar 2023 13:52:42 +0000 Original-Received: from localhost ([127.0.0.1]:44874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZXkA-00044e-Fw for submit@debbugs.gnu.org; Tue, 07 Mar 2023 08:52:42 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:45029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZXk8-00044T-9q for 61350@debbugs.gnu.org; Tue, 07 Mar 2023 08:52:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1678197151; i=michael.albinus@gmx.de; bh=rKxpPH5kCPj8INlot9UvyIJrWsASqfdTguyuUonhwzc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=BYKEd12mPMxha1s808E6eWaXNyRnLWIelPU7QU9RTBlit5aK+WI1zlJI80EjL2pjF h+V6JE7EzoNuET7LNPyJsos246HaZJJbAAzwnKpTAnAaiNU5WYHWdnqobnkKYuLgiV Zc2AsRggfOZwMxgLj5VgRrgLndbMJf1yoC9n4MN12oTM2KGLn63pWUCu8EKO+H7doX j2KMLG12YYGTkr3EIZs0BhPiwRulvd/6fqnhlzZnfHBdK8lii4EF0oNvu8gf8PAmCi M7r15MyL4BK0h/RPUMVlWkrtGMosKLkAV/EnSNqGVuo9vtC8Cy8cbQEHf4IrTlrIQZ SnQmNVCu/kBJw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.22]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M1Ygt-1pava81LiN-0035QW; Tue, 07 Mar 2023 14:52:31 +0100 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Tue, 7 Mar 2023 13:33:48 +0000") X-Provags-ID: V03:K1:c4f3ft9rpHSlUyOo53hUK2gVGMCNqXsQsHYGpfrrNV3UzesGatL BNMwE65q01rw6cCgqGXMLUUtyjVZ0/JOyzHd/nQS7iyYZNyFtWYYnkxE1+KQ02yDTc5u8ef VMYMgAMCCkExrvSsDQU7AChJp90o65JD+7Vs7/tQHH8WvZ1A6oyU+k0YdAgH/CgMJhdKGGQ ugCJ2aYLJKZ0cHNzwy1og== UI-OutboundReport: notjunk:1;M01:P0:HtYKM/5orXM=;+fR3sydBG1iGXAhxF23oZM4kHu+ LxVVgyIHbO+t1D3kfNXKqQSyg2/6NO1iZSZBJu7HxNfu7+5ruhcENVLhrduRYG9x+SCk9hjAX cmwCW5u5+TvhbMTpBSjkO3Sbrp5pqgTiDzRAemLun+LRzSTuEjQD8dZc/HlryvwuVZ5QXtsMv tH4aMMKGW2RMkDlSwcXQgwGlVwElANip8iDXzt9fRKXlH1jDuw8yiYqmVNpAWfeRiikLIIwRo BEY1EznkjRxnCElSPRjwlqQILdeM7EvGyCa7DUkbkxxT2SOFGmxTOUJH0JhkOz1ugIeXw2xK+ hHYYCcT7ZWdrfEoJZ1HKbPmW6OKObjr+g4dHiqfdL6i7/KSpQOsDBdCsxMlzbAwZ7y3Tcpocw KYV9DR9l5IKLU1zfnuUhVSbcNXDk80bB8OwhtgiZhYeZ2oUt3HW3vEvw5WuN0jGNjsHtHGQ9D iHrttdJWbGeX2Za2Hv9lTDaStWnC39kNAVjrlpTaqVICDS4TNisJYeNp3yWDKqL2FORKwMewQ O0601Tzgk4XG3qZ79sz6g5fnehaR+FxTjIEEsAQh1tkFAM/igjW2AWeDHW0wiMy++KQX3pRAz +vJlK14+Uj8LouusFMthc/yupGcoMdP0L3AD5iXtj1oiLJOePUbwQzIzw5zOGpFmDJOk5+xHf e4SAA/YEQza9ULOPHgyL9vT30xR1rxi5z/AKkhywEJFUiNk9RXrLpUM4CtKmUOL3T53AkTD7z T+npgwE7rCnn9F6a25LlVjORGrZXi/V+QCv55KuG2iWwwXJBXmGUXhZIiKsiExOOrIx2ZAIn X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257459 Archived-At: Jo=C3=A3o T=C3=A1vora writes: Hi Jo=C3=A3o, >> Thanks Michael! What is the advantage of this patch over just removing t= he JUST-THIS-ONE argument? >> In both cases tramp is triggering accept-process-output for processes it= does not own. > > Yes, I also ask myself that question. Though here, Tramp > has "shared" ownership of them, sort of, so it's more > conservative when compared to the current mechanics. Indeed. > Michael, your patch goes in the right direction but AFAIR > a single accept-process-output is not guaranteed to bring > into the process filter all the buffered data. > > In "40.9.4 Accepting Output from Processes": > > [In accept-process-output, ] If PROCESS is > non-=E2=80=98nil=E2=80=99 then this function does not return until s= ome output has > [^^^^^^^^^^^^^^^^^] > been received from PROCESS or PROCESS has closed the connection. > > > Note "some", not "all". So while less common, I think the hang > can still happen. > > So maybe you meant: > > (while (accept-process-output p 0 nil t)) > > as suggested in that section? That was my first idea as well. But tramp-accept-process-output itself is called in a loop, so there's no difference in practice[1]. Pls give my patch testing, in order to see whether Tramp still blocks. > Jo=C3=A3o Best regards, Michael. [1]: In theory, there's no difference between theory and practice. In practice, there is. :-)