From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#62048: 30.0.50; Non-nil `line-spacing' takes precendence over 'line-height t text property Date: Sat, 11 Mar 2023 11:10:10 +0000 Message-ID: <87r0tvwnl9.fsf@localhost> References: <87ilfbe8r0.fsf@localhost> <83a60n40an.fsf@gnu.org> <87y1o7cd6a.fsf@localhost> <834jqv3tv3.fsf@gnu.org> <87v8jbc70u.fsf@localhost> <83v8ja2z4d.fsf@gnu.org> <87sfeecmom.fsf@localhost> <83edpy2r3x.fsf@gnu.org> <87o7p2chyq.fsf@localhost> <83zg8m15n5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2256"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62048@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 11 12:09:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pax68-0000LQ-Sx for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Mar 2023 12:09:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pax60-0001kc-WD; Sat, 11 Mar 2023 06:09:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pax5z-0001kT-ML for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 06:09:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pax5z-0004lm-2k for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 06:09:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pax5y-00020W-I7 for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 06:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Mar 2023 11:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62048 X-GNU-PR-Package: emacs Original-Received: via spool by 62048-submit@debbugs.gnu.org id=B62048.16785329327699 (code B ref 62048); Sat, 11 Mar 2023 11:09:02 +0000 Original-Received: (at 62048) by debbugs.gnu.org; 11 Mar 2023 11:08:52 +0000 Original-Received: from localhost ([127.0.0.1]:56627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pax5o-000207-2x for submit@debbugs.gnu.org; Sat, 11 Mar 2023 06:08:52 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:56125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pax5l-0001zu-Sw for 62048@debbugs.gnu.org; Sat, 11 Mar 2023 06:08:50 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 04F442402EA for <62048@debbugs.gnu.org>; Sat, 11 Mar 2023 12:08:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1678532924; bh=0wQwFGrbrGSAklzwxmUxPnMuea/4dePmxLdeJSC1RP8=; h=From:To:Cc:Subject:Date:From; b=SVNISmQLC8KpWH4T5XHTfHNyHCDqVJC9d3mWzQ0hfqgluVe7pzmLiYvSoGZ1hGfH7 lBuUfPS/DsNlfn86CwFbT26g3jyPT+kx+Vj7sAhT3/djlpDuCaQnuB8Mtv2YilJEry n7xOuK05CHoOZ4Zecev5SZKAbjXWE2nXNLuAr8H7UOwODFZomGFTMtXIjULp8IG7DO KO3Tas8q1YQGNgAL62g0jRXQudcFRpcduOhFTwGWOYeMZiWTMGHs1DDtqXGt4OA+kX c+MVlcbUOaTk7sbvP2IkjKoe5vRbKii/31DaFMb156ulddeTIqMoFyY7X2cuRpV3LR Az2MtDQcFqISA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PYgCD5J9Wz6tqt; Sat, 11 Mar 2023 12:08:40 +0100 (CET) In-Reply-To: <83zg8m15n5.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257776 Archived-At: Eli Zaretskii writes: >> Observed: top of the image is displayed >> Expected: bottom of the image is partially revealed > > I don't understand the expectation. Scrolling by vscroll only happens > when before the scroll some part of the image is visible, which is not > what happens here. > > If you want to change that, feel free to hack on the code in > simple.el, but there was no intent to cover this particular use case, > and the code is already quite complicated (to say the least). > ... > You should always keep in mind that Emacs has no idea about what's > beyond the window, for display purposes. There's no way of saying > whether a given 'display property whose value is an image spec will be > taller than the window, except by actually displaying that image (or > at least simulating the display internally). So you expect something > that it is far from easy to do. > > Scrolling commands were never meant to allow smooth scrolling through > tall screen lines. What if the code instead tries to vscroll standard line height first and only then decide if we want to scroll further, displaying tall line? > What do you want to customize, and in what terms? I was referring to >> (if (and (< arg 0) >> (< (point) (window-start)) >> (> lh winh)) >> (set-window-vscroll >> nil >> (- lh dlh) t))) May we allow users to customize ~(> lh winh)~ condition? By providing a custom setting that will determine the threshold for partial scroll: `line-move-height-threshold'. The default value will be 'window making lines taller than window height to trigger partial scroll. Alternative values could be a subset of pixel specs, like (NUM) or (X . UNIT). Also, on the initial report. Is it possible to increase default buffer-wise line-spacing via text property? (AFAIU, decreasing is impossible). -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at