Eli Zaretskii writes: >> From: João Távora >> Date: Wed, 12 Apr 2023 12:15:11 +0100 >> Cc: philipk@posteo.net, monnier@iro.umontreal.ca, 62720@debbugs.gnu.org, >> larsi@gnus.org >> >> > This has the same problem: it modifies a function that is called in >> > too many places. package-installed-p has half a dozen callers in >> > package.el alone. The change is tiny, but what about its >> > implications on every use case where it is involved? >> >> What about them? I volunteer to help test whichever cases you (or >> anyone else) think may be problematic. > > We will never be able to reveal them all, let alone test them, before > Emacs 29.1 is released. > >> Can we put this tiny patch on master then? > > Yes, if Philip and Stefan don't object. But, since there will be a > command for updating core packages, doesn't this go against your > desire not to change the UX? After thinking about this for a bit, I think that the right approach is to use package-install instead of writing a separate command. After all, this will make the behaviour of package-install consistent with that of the package menu. It might work but it should be tested somewhat thoroughly before the patch is applied. In the meantime, I just finished a similar approach that does not modify `package-installed-p', but just adds another utility function: