From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set variables after info package Date: Mon, 17 Apr 2023 16:03:56 +0000 Message-ID: <87r0sih4wj.fsf@posteo.net> References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> <87sfd2ns6d.fsf@posteo.net> <833551ecb2.fsf@gnu.org> <87ttxh4e9i.fsf@posteo.net> <87bkjmiqtz.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33437"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62767@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier To: lin Sun Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 17 18:04:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poRKy-0008N5-GY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Apr 2023 18:04:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1poRKn-00076f-16; Mon, 17 Apr 2023 12:04:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poRKl-00076N-72 for bug-gnu-emacs@gnu.org; Mon, 17 Apr 2023 12:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1poRKk-0001aG-UM for bug-gnu-emacs@gnu.org; Mon, 17 Apr 2023 12:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1poRKk-0002Xo-86 for bug-gnu-emacs@gnu.org; Mon, 17 Apr 2023 12:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Apr 2023 16:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62767 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62767-submit@debbugs.gnu.org id=B62767.16817474159738 (code B ref 62767); Mon, 17 Apr 2023 16:04:02 +0000 Original-Received: (at 62767) by debbugs.gnu.org; 17 Apr 2023 16:03:35 +0000 Original-Received: from localhost ([127.0.0.1]:55876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1poRKJ-0002Wz-AN for submit@debbugs.gnu.org; Mon, 17 Apr 2023 12:03:35 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:45769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1poRKG-0002WZ-5R for 62767@debbugs.gnu.org; Mon, 17 Apr 2023 12:03:32 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A7C45240242 for <62767@debbugs.gnu.org>; Mon, 17 Apr 2023 18:03:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1681747406; bh=KHKj4TgAjdbNwHpJYLvPY9h0hU0Dl+gXiofdg97YSU4=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=NRoOEQv/DrE7yqRuaR+tlDdnlkLkY1yJvAqfsBn8gHHWRLRvO49DpZjDrwQSJ6Gq7 Ach7vQYISULO8x3E1bS2eo8bDz0Ce6m19ji+K6D3MKOh8tw8QgRciD6ewEcrfL1Mq/ 685YxIE5sHXg6Hl+6ueNDEzi3bUaE0KWlaI/BQ1iO/qG8kfO9RFKxau0IyOnyhaC7j YOQXjBQ3NX6APjqLVl9CWAYmIvSTc4YB5xNqHi2Wvz5Uufy/+kI7/g8PoEv+QmFS4Q otoYKIcbY6asszR7iMw7/HaqPcQ997WI2w/1q1ZPgrvbd3IM45cuVqoUkMV9zau5l3 B5F2DepGOhNEA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q0X0F6sM1z6tyL; Mon, 17 Apr 2023 18:03:25 +0200 (CEST) In-Reply-To: (lin Sun's message of "Mon, 17 Apr 2023 15:27:09 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260187 Archived-At: lin Sun writes: > Hi Philip, > >> How did you come to the conclusion about the second one? > The 2nd one is necessary because the following lines will use the full > `Info-directory-list` to print its values into the > package-quickstart.el, whose value was modified by the function > `package-activate'. > If I comment out or use the `eval-after-load` on the 2nd one, the > `Info-directory-list` will be empty, and missed in the > package-quickstart.el file. OK, I get it now. I was confused because it seemed as though `Info-directory-list' could just be bound and declared using a defvar before the function, but if we do not load info then the with-eval-after-load blocks in `package-activate-1' that are invoked for the side effect of manipulating `Info-directory-list' do not get evaluated, which is why we see that the value is empty. But as the function `package-quickstart-refresh' is not invoked on startup, but as `package-quickstart' says This requires the use of `package-quickstart-refresh' every time the activations need to be changed, such as when `package-load-list' is modified. This should be fine. > Hi Ruijie, > >> "insure" -> "ensure"? > You're right. > I had fixed my typo in the patch file (only typo in comment), and > attached the new one, please help review again. Thanks Again, assuming that there is no issue with `with-eval-after-load', the code should be fine. The commit message looks a bit distorted though? Did you generate it using C-c C-w? I get this template when I apply your commit: * lisp/emacs-lisp/package.el (package-activate-1): (package-quickstart-refresh): Also, it would make sense to motivate the changes in more detail. What do the changes improve?