From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62164: 29.0.60; ediff behaves poorly by default on tiling window managers Date: Tue, 06 Jun 2023 07:51:44 +0800 Message-ID: <87r0qpjwmn.fsf@yahoo.com> References: <87cz5c87xg.fsf@yahoo.com> <878rg087v5.fsf@yahoo.com> <87a60c3zuc.fsf@yahoo.com> <871ql3nj6y.fsf@catern.com> <871ql2su9q.fsf@yahoo.com> <87v8iemsbh.fsf@catern.com> <83ild19uzd.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10188"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: sbaugh@catern.com, Eli Zaretskii , 62164@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 06 01:53:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6K0t-0002UH-JC for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Jun 2023 01:53:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6K0X-0003Ey-3a; Mon, 05 Jun 2023 19:53:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6K0U-0003EW-Tf for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 19:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6K0U-0000Nv-LS for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 19:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q6K0U-0007vJ-8R for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 19:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Jun 2023 23:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62164 X-GNU-PR-Package: emacs Original-Received: via spool by 62164-submit@debbugs.gnu.org id=B62164.168600912530371 (code B ref 62164); Mon, 05 Jun 2023 23:53:02 +0000 Original-Received: (at 62164) by debbugs.gnu.org; 5 Jun 2023 23:52:05 +0000 Original-Received: from localhost ([127.0.0.1]:50525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6JzY-0007tm-Ts for submit@debbugs.gnu.org; Mon, 05 Jun 2023 19:52:05 -0400 Original-Received: from sonic313-9.consmr.mail.ne1.yahoo.com ([66.163.185.32]:41362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6JzX-0007tH-5C for 62164@debbugs.gnu.org; Mon, 05 Jun 2023 19:52:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1686009117; bh=wB7AYSxSGIv8FTS3bBgNh1p2fZC8oOInsHHCT26r4bc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=tlQsEtWnzGxBgDPKLA/U6aRzYeTET4Jzp0VBsIG1Rzkk5Tpuefw+hHFrDa7eD8L9DjI6zSgGcScZa1meUBvwltovxkV4b0I3s8Z9g3e1GEOclDuSK4NArZVr5LlqleFYHPe0vr0Dx2ha74OEjgEpGQ3zL7pDXBaZW5qbsiZ7gBvc8R+JAgBJimVi3KGXaym16Xc5MQEQTz3kH3UiC381Ns8iy0oFIGHqHql8bRkjPowh4TEyIHOx4izVXgwzC9dqY69ttflzV/0uOXWfrq1UXbDDLs/GFIkrMDsExuzZ0LGIO2FkjhU0aAsNlSupri6OCbyowYOFy8AC+0RjxyG3zQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1686009117; bh=8nmr1nr6TncMbc9I2Yzldd1jS5NannTqw0+Oshw7a6Z=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=PyU5ukikdY21sGaKI6Wsrodx8s8iAX/n2o69ekIg9KoJZRPnfHafJQjw8NihjVFDKx6Im4K1M21J+sGVDFha2emvraRO+4GoT2X+jgWSMr/51e1WAmoINDga5CpEQlV1DLNH3RUQ0uJgDbNNOMMq05mSF1uxexlUiZDPAHZMPPf/4B7IZtTUEqcBi+fVRk4zPlobx7T4GbxFAiK6qgitKRknC+C4UHk7gxBeHXWKwEEL+j1wY3r64EJFPONl0vPZfa8e6l6FFCqBKaQ9uAQQ+FxcesNtwNaE/Dl/7yzVh4wbpH6rSB4XinPw2INCmM+rXwM6DLiP5S+1yGBIfDwDFA== X-YMail-OSG: TnxPFTQVM1mfqwZG_M6APVjimLVVXemY5BjCMcEQIO9JjsBbix4Xan2I9fAP05L aBitaJeZdevbxTsrsHDPCe_SEwgLrWDIN.z5wMOBhGqQkYr9dq5vSuZYGO.LNPRASfp5E.rBCT.K 77TFDcdP2w9OJUY0UmUOlMjNjsKyO5vmYcAr9lcZ2kd7GOWsZQy2ksNlWchQvyEGlV58fsDda01p zt6oWtLKkmpzMPMEkMStw4fnIMIZoQEgJPNph3kRKQnSbq5tZz28gbyxoBvkEcZ_vHKiAbz9gDkM DxJE5BZDXF_AclS6jQ_K0NrLV2CdfhaSoHaDgvWk1rpIQpLqRURiNWIc8ZInLX3x_vIlcx.MzPib fT8pxmb_4KiiaZH.pjCEXfii_6vBCOgzlGS5vLgQ1T5VY78McxHQG65w2aovy9LgBxFCMzB1ezVn QedfKqmAzCL5wF5lZ_z2Y.mGqoOWfZ1VDflSQhpcVtOWijlCaaonURRgW0CtffDnljLCuioHbYWh zO8ZNcpejwu36BupwG_rAoEO0K.tOBSsWX7l5JDMXxvaaSEFLjCy.YkW8b0_25xx3ZlMNDyshn6K _uI6ZC95RfjCaXGTqHsLWADMtHK9R850wRx2sTtnnfPrKl9RMI9TETSDEJoUUkotex8cFV_Pvhjq Xpab2QgX5tOGKhOwMBXQP3ilJTUphgswvNpSsBbP7MvuGBAl_rjUkqo4cH4La4pL3xBKF8JENBtA wkyW.fuWcgaghpz.X3_UreyADb.3odXWCwNTnH53_2ooAj3dy9WuBD4kH.1148rutJ1sjygvKB1Z a6lz0uWY03r3_Zf4hd4cR6UAU67GztyFrqgnhiogw2 X-Sonic-MF: X-Sonic-ID: 149cb934-c353-4348-8e4f-8e5229c120b2 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Mon, 5 Jun 2023 23:51:57 +0000 Original-Received: by hermes--production-sg3-748897c457-fp9l7 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID cc703af246c0334e114709b01d0de7e6; Mon, 05 Jun 2023 23:51:53 +0000 (UTC) In-Reply-To: (Spencer Baugh's message of "Mon, 05 Jun 2023 17:56:38 -0400") X-Mailer: WebService/1.1.21516 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263036 Archived-At: Spencer Baugh writes: > Eli Zaretskii writes: >>> Cc: Po Lu , 62164@debbugs.gnu.org >>> From: Spencer Baugh >>> Date: Tue, 09 May 2023 14:27:11 -0400 >>> >>> +(defcustom ediff-x-utility-control-frame nil >>> + "If non-nil, the control frame is a utility window under X. >>> + >>> +This is useful in tiling window managers, where this will cause >>> +the control frame to be floating rather than tiled. It should be >>> +harmless on other well-behaved window managers." >> >> If this option causes the control frame to be floating rather than >> tiled, the name of the option should reflect that. Using "utility" in >> the name of the variable makes the option less self-explanatory, >> because that technical terms is not relevant on the user level. >> >> Thanks. > > Agreed. Revised patch attached: > > From 8725b7376b3e6ddaaa4389d363bd9da56bf3eedb Mon Sep 17 00:00:00 2001 > From: Spencer Baugh > Date: Tue, 9 May 2023 14:22:29 -0400 > Subject: [PATCH] Allow setting the ediff control frame as a utility window > under X > > This is a step in the direction of making ediff behave better by > default under tiling window managers and fixing bug#62164. > > * lisp/vc/ediff-wind.el (ediff-x-utility-control-frame): Add > defcustom. > (ediff-frame-make-utility, ediff-setup-control-frame): Allow setting > the control frame up as a utility window under X. (bug#62164) > --- > lisp/vc/ediff-wind.el | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/lisp/vc/ediff-wind.el b/lisp/vc/ediff-wind.el > index eb903f093f9..e50df599a98 100644 > --- a/lisp/vc/ediff-wind.el > +++ b/lisp/vc/ediff-wind.el > @@ -69,6 +69,16 @@ ediff-window-setup-function > (function :tag "Other function")) > :version "24.3") > > +(defcustom ediff-x-floating-control-frame nil I don't think this is correct. Ordering the control frame above other windows is one policy taken towards utility windows, but other window managers may behave differently (by placing the utility window at a fixed position, for instance.) The name of this variable should not depend on the behavior of the window manager.