From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#64242: [PATCH] Fix VC package build when there is no docs dir Date: Fri, 23 Jun 2023 07:35:06 +0000 Message-ID: <87r0q2r5qt.fsf@posteo.net> References: <877cruvijk.fsf@dsemy.com> <83352i3ed4.fsf@gnu.org> <87fs6ilme6.fsf@dsemy.com> <83zg4q1woh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35361"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64242@debbugs.gnu.org, Daniel Semyonov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 23 09:36:41 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qCbLV-00092F-SZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Jun 2023 09:36:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qCbKz-0006aR-AI; Fri, 23 Jun 2023 03:36:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCbKs-0006Ym-8j for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 03:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qCbKr-0004Gx-Vc for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 03:36:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qCbKr-0002c9-Qc for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 03:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Jun 2023 07:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64242 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64242-submit@debbugs.gnu.org id=B64242.16875057169722 (code B ref 64242); Fri, 23 Jun 2023 07:36:01 +0000 Original-Received: (at 64242) by debbugs.gnu.org; 23 Jun 2023 07:35:16 +0000 Original-Received: from localhost ([127.0.0.1]:37401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCbK8-0002Wj-1k for submit@debbugs.gnu.org; Fri, 23 Jun 2023 03:35:16 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:50321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCbK5-0002WR-6j for 64242@debbugs.gnu.org; Fri, 23 Jun 2023 03:35:14 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 30C05240028 for <64242@debbugs.gnu.org>; Fri, 23 Jun 2023 09:35:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1687505707; bh=mduxK2K7Du7aEMCOzAWOqkhrkLH3PzCM/P1Qx4zMtBA=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=OqEH9+eO2wZKfGU/AypUn3+QNx8HmM0409Ar49OEj5Qyk+NLwAykBSwznT/VRRr0o T4QlUwJMgtzKkP21x3LeBdBcflg7X0BI1yM2gwVJV1iLIT/hyDlF+GbKHWVUlpCN6a oDqjmuzwe+1LZ8bS0U2/OP7ZO6nCGVCp0vypaZp7ReVxs0DQUZAokJAdcmKaPj2b/b 8gpWg+KknUXTDB1S69RQCTW9NqRMmBnqzkJZyCYdKBsqMrP5xhY+ZRFPbEv+EtM9K1 L7CDiJHZa7fuN4ACwoyPNFJ5aaMYOULfDSuPJRidzVEcOqTvg63C16t/RkwHn0Xxj5 pn0TO7nP50Vyw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QnTXp3t5Jz9rxH; Fri, 23 Jun 2023 09:35:06 +0200 (CEST) In-Reply-To: <83zg4q1woh.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 23 Jun 2023 10:10:06 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263936 Archived-At: Eli Zaretskii writes: >> From: Daniel Semyonov >> Cc: 64242@debbugs.gnu.org >> Date: Fri, 23 Jun 2023 09:32:01 +0300 >> >> >>>>> Eli Zaretskii writes: >> >> > What do you mean by "isn't a directory"? FILE is supposed to be a >> > documentation file, not a directory, see the doc string of this >> > function. Do you mean that FILE is a relative file name so that >> > file-name-directory returns nil for it? If so, I think the >> > correct fix would be to reverse the order: >> >> > (docs-directory (file-name-directory (expand-file-name file))) >> >> Yeah, you're completely right, this was a misunderstanding on my part; >> my fix just happened to also work so I made some incorrect assumptions. >> >> After some further testing, this seems to happen for packages for which >> the doc file is in the base directory of the package (which causes >> 'file-name-directory' to return nil as the doc file name is relative to >> the package dir). >> >> I attached an updated patch. >> >> > Can you show a recipe to reproduce this problem, preferably >> > starting from "emacs -Q"? >> >> 1. $ emacs -Q >> 2. M-x package-vc-install RET eat RET >> 3. A few seconds later, >> "package-vc--unpack-1: Wrong type argument: stringp, nil" >> >> > And finally, this issue exists on the emacs-29 release branch as >> > well, doesn't it? >> >> I haven't tested it, but I don't see a reason it wont. > > Philip, any comments or objections to installing this on the emacs-29 > branch? I have none. There were just come complains last time, because we made the change too soon, so I believe the consensus was to wait for a bit longer and then it was just forgotten. > Thanks.