From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk Date: Fri, 04 Aug 2023 21:28:50 +0800 Message-ID: <87r0oj7x7x.fsf@yahoo.com> References: <875y5wf6ti.fsf@web.de> <87y1irabhw.fsf@yahoo.com> <87tttfh9iv.fsf@web.de> <87tttfa80m.fsf@yahoo.com> <87il9vascg.fsf@web.de> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7272"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 65042@debbugs.gnu.org To: Felix Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 04 15:30:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRusk-0001hY-2w for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Aug 2023 15:30:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRusX-0003w0-P9; Fri, 04 Aug 2023 09:30:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRusV-0003vj-GQ for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 09:30:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRusU-0007Lk-Vb for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 09:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRusU-0007DN-GL for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 09:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2023 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65042 X-GNU-PR-Package: emacs Original-Received: via spool by 65042-submit@debbugs.gnu.org id=B65042.169115574827639 (code B ref 65042); Fri, 04 Aug 2023 13:30:02 +0000 Original-Received: (at 65042) by debbugs.gnu.org; 4 Aug 2023 13:29:08 +0000 Original-Received: from localhost ([127.0.0.1]:53591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRurc-0007Bi-Cx for submit@debbugs.gnu.org; Fri, 04 Aug 2023 09:29:08 -0400 Original-Received: from sonic316-20.consmr.mail.ne1.yahoo.com ([66.163.187.146]:44884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRurb-0007BS-Fq for 65042@debbugs.gnu.org; Fri, 04 Aug 2023 09:29:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1691155741; bh=AYNv6rB1b5CeL9z8LIdcMk4U1zD6THCdNH5Ew43KXOE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=JpygYj+gJKwSK2kCZsfww0ZfUxNHYhNfON0hoVpfx1rLfpVawN1r/kBkoxaQO4QI8HviJgeFKShfYzdXB4cDHp+3aqLtkTabZK/LyYXfaq9dvCC7rpS4xeOs7nH42KnoRgf5DrPQccWyvAkdMQqj3DpkbSRl6K4uilYLu6wmFTEStjVhQZlJG/8kr/h2RVCv+hIWFgOfSnauXJ5dSExIpej49eB6mWoN2CCymnApWIi77CgEZ5DnQCj99eJHyp6RKCqAiejqA20LOirCKwPMKW252f8fhJeSBWaEQ0ubseKuHW5N/huW1aM8f6WTLmSqjIOJrsqahjkL4SH8zmWHfQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1691155741; bh=TXW6sOuQr8Q6YbWC/20pozGkjTzr10yO8cnP81Q4EN7=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Rk+iXF5LWuFdvkiWZ+HkVH+1OfEOVum2wgNckGb3yI2ClLfk3rwO81DSvFDOLl4rTHpDO1YR0eAQmX8K9DcIsXkaR+IqjmF1VMGT0tHMLJSuPbRnd0WbAA6mWEuaPAINs57YBFKjIgcM0A8ZrytFfKCcNeg39IaxrdP8xH8ERt3wilgdK+0Bltn3FdW5qUALck3lIfLsrx1h1SgcFKUKKz8IJY02wZ+Oh+wTlX9DvYClwqkJs8/EUI9nRZVlOckxYVKyTDhoSjkzjYY+BIacWSm1hzEC3gXlidgRqAUBCiFX/HaccbZOXk8XUuLHIcr7s2TIdBSP5flxs+HfvtkFYQ== X-YMail-OSG: _IeKp_IVM1nviDHfbC4snf4T350Nfo26riJB4pHT2ZhmqGZsHB29GaWCohoyoT0 .ePpNKOwfv8i3xwGK8yaD3rfNYae9jz7dA33urjKoCnQj6y_LXRzLLSBRjBuvwZ0vJMe20W5ou8T 4ZiLiRAoYWjrafQAxEHoXro3DNV2MUx61oT9H3YOddToQ_ZSob8srucHN1P35m08eys2_SL2.dgO TxJWh4A5L0lEEF3jC._Wk6v.zGFfz.G5PCrIex3OqzA.znplQGITarH2BXUT6uRHGfOmkAqNkJ_5 3tQ.rhZGPlJEEKnJHXwQc3B63lue4CdQvhI20aGJVy3GXGULiEmcszTS48e9a.VwHLqZirAGMjXz 7MKJ_rcfSA.AIu64W_XN2VP5_AuoGoi3N3KsyqV_k..Av3lpyNMT962Dk5nVewejOPmRiZnOcRjW hQsJLPPrBWWBaEgQ5n0IvBcH013iNlInlngNv4JXNfWRMPnuEUUskDuxKzpdvluz8apcZARuvXe2 bVqYYRfFSghX5tVYKWvdre1mhj18eICxwBtDlVR3kpu9roa7JGD3WFF01g67tecLLRACZ6H3g.ib TTASqdxhPEoD5T7Bbk1z1geTeS4fe0lUq9g11B.BE_uSjZziJ2W4kFev5X2yYh.y1mcaDScRnhXw ukUnUv3_44LVZndsf3yJ42anqEVg_ccVjCpwMuKYb03nKw797_ihmLeRDPJQlSDK8yxc2d2eEoM7 xm2Xt0TjV5ZFsupFlB6VuX_PvZvYIjlBMxQgChFr61Cou0cop.8fimuriUt6QoZjEnQ0TGpA2r6I GMh_EzsiadZPXsqtfzN6Ys16X6UL1KQKm8GuNaabgA X-Sonic-MF: X-Sonic-ID: beebc155-b6b1-4d44-a930-9770a44f4e5f Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Fri, 4 Aug 2023 13:29:01 +0000 Original-Received: by hermes--production-sg3-6b8fc8d58f-jwkjf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 03352c955b12995ab41f9eb19ccfddbb; Fri, 04 Aug 2023 13:28:54 +0000 (UTC) In-Reply-To: <87il9vascg.fsf@web.de> (Felix's message of "Fri, 04 Aug 2023 14:43:40 +0200") X-Mailer: WebService/1.1.21685 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266670 Archived-At: Felix writes: > Po Lu writes: > >> Felix writes: >> >>> Po Lu writes: >>> >>>> Felix writes: >>>> >>>>> The background of stipple stays opaque with alpha-background parameter >>>>> set for transparency. >>>>> This came up in the use of the new package 'indent-bars'. >>>>> The github issue: https://github.com/jdtsmith/indent-bars/issues/8 >>>>> I tested this with 'emacs -Q' only enabling the needed packages (compat >>>>> and indent-bars). >>>> >>>> Thanks. Do stipples start displaying adequately with this change? >>>> >>> No it doesn't. >>> But it gives weird artifacts (doubling the character one >>> line above or something like that) >> >> How about this? >> >> diff --git a/src/pgtkterm.c b/src/pgtkterm.c >> index 9c1fc7bef4e..a7c687d811d 100644 >> --- a/src/pgtkterm.c >> +++ b/src/pgtkterm.c >> @@ -1328,14 +1328,17 @@ fill_background_by_face (struct frame *f, struct face *face, int x, int y, >> int width, int height) >> { >> cairo_t *cr = pgtk_begin_cr_clip (f); >> + double r, g, b, a; >> >> + cairo_set_operator (cr, CAIRO_OPERATOR_SOURCE); >> cairo_rectangle (cr, x, y, width, height); >> cairo_clip (cr); >> >> - double r = ((face->background >> 16) & 0xff) / 255.0; >> - double g = ((face->background >> 8) & 0xff) / 255.0; >> - double b = ((face->background >> 0) & 0xff) / 255.0; >> - cairo_set_source_rgb (cr, r, g, b); >> + r = ((face->background >> 16) & 0xff) / 255.0; >> + g = ((face->background >> 8) & 0xff) / 255.0; >> + b = ((face->background >> 0) & 0xff) / 255.0; >> + a = f->alpha_background; >> + cairo_set_source_rgba (cr, r, g, b, a); >> cairo_paint (cr); >> >> if (face->stipple != 0) >> @@ -1343,10 +1346,10 @@ fill_background_by_face (struct frame *f, struct face *face, int x, int y, >> cairo_pattern_t *mask >> = FRAME_DISPLAY_INFO (f)->bitmaps[face->stipple - 1].pattern; >> >> - double r = ((face->foreground >> 16) & 0xff) / 255.0; >> - double g = ((face->foreground >> 8) & 0xff) / 255.0; >> - double b = ((face->foreground >> 0) & 0xff) / 255.0; >> - cairo_set_source_rgb (cr, r, g, b); >> + r = ((face->foreground >> 16) & 0xff) / 255.0; >> + g = ((face->foreground >> 8) & 0xff) / 255.0; >> + b = ((face->foreground >> 0) & 0xff) / 255.0; >> + cairo_set_source_rgba (cr, r, g, b, a); >> cairo_mask (cr, mask); >> } >> > > This time it works, > Thanks for this, and thanks your work on Emacs in general! OK, thanks. Eli, should this reach Emacs 29.2, or is it too involved for the release branch?