From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired Date: Fri, 04 Aug 2023 22:58:25 +0200 Message-ID: <87r0oied8u.fsf@ledu-giraud.fr> References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24462"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65052@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 04 22:59:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qS1tT-0006D4-5z for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Aug 2023 22:59:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qS1t3-0000ET-Hc; Fri, 04 Aug 2023 16:59:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qS1t2-0000EA-FH for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 16:59:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qS1t0-00032c-Cq for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 16:59:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qS1sz-0000HZ-Sl for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 16:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2023 20:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65052 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65052-submit@debbugs.gnu.org id=B65052.16911827121046 (code B ref 65052); Fri, 04 Aug 2023 20:59:01 +0000 Original-Received: (at 65052) by debbugs.gnu.org; 4 Aug 2023 20:58:32 +0000 Original-Received: from localhost ([127.0.0.1]:54964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qS1sW-0000Gn-9o for submit@debbugs.gnu.org; Fri, 04 Aug 2023 16:58:32 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:48703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qS1sT-0000Gd-BR for 65052@debbugs.gnu.org; Fri, 04 Aug 2023 16:58:31 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=uZP1VW31 Ht6P60E75QMm1KBnA03Frd2jXv7BMLV2CvE=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=vF7bAD61sC9RmHtUFtS+6y2h8E4AsS tm6kyRNnHQzcbnxK3BD8fIxCQiGFvYIUc+9/RfiUtjBwt5bStfdSf/CQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=uZP1VW31Ht6P60E7 5QMm1KBnA03Frd2jXv7BMLV2CvE=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=ofl+q9lufmrmlKDFxHE11mlaCeKrR6bchSiYVU AxuuZ+nAjGn1xat16uJs4I1NTLb7Mdzg8GrohFIBnKpoaEZSCMhmNFXhyoKB++ivZmnaEQ GvF2M2KSHA2mfS7E1JmxRc19tI+7QJPpMOfxhsfCnFWOIlqgnav5VEc5Qd862XpLouA3q4 dVupJaIU1E7uijqPotkSLVL4H2Hm+bK5JiZ+OhoAUQMyqyrfgEHj2Lgu4dIjtlxgXDfi4H zuMvEtOWVBpHSdXJMETfp1QREHdknvrG1OCctupe9WpOErnenQbxMGTbw6FSm7IJbaZcT6 Dy5qjh4BIL0ariPk6VnydGgQ== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id a2513069 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 4 Aug 2023 22:58:27 +0200 (CEST) In-Reply-To: <834jlevd7o.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Aug 2023 22:07:07 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266716 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: [...] > OK, but then this part: > >> + ;; "one line" dance to update tracking and header >> + (image-dired-next-line) >> + (image-dired-previous-line)) > > looks like a kludge. Can't we have a cleaner code for updating the > header data? If image-dired-previous/next-line can update the data, > why cannot the scroll commands do the same without calling the > line-movement commands? You're right. Here is a cleaner version inspired by `image-dired--movement-command-line'. -- Manuel Giraud --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Scroll-up-and-down-in-image-dired.patch >From 9395c814d5664f5d31490ee63de43fa3478b7143 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Thu, 9 Mar 2023 14:35:31 +0100 Subject: [PATCH] Scroll up and down in image-dired * lisp/image/image-dired.el (image-dired--movement-command-scroll): Macro to manage scroll in image-dired. (image-dired-scroll-up, image-dired-scroll-down): Scroll up and down command in image-dired. (image-dired-thumbnail-mode-map): Use them. --- lisp/image/image-dired.el | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 33beb5b3e49..067134fd331 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -740,6 +740,16 @@ image-dired--movement-command-line (point)) ,reverse)) +(defmacro image-dired--movement-command-scroll (&optional reverse) + `(image-dired--movement-command + (let ((goal-column (current-column))) + ,(if reverse + '(scroll-down) + '(scroll-up)) + (move-to-column goal-column) + (point)) + ,reverse)) + (defun image-dired-next-line () "Move to next line in the thumbnail buffer." (interactive nil image-dired-thumbnail-mode) @@ -770,6 +780,16 @@ image-dired-move-end-of-line (interactive nil image-dired-thumbnail-mode) (image-dired--movement-command (pos-eol) 'reverse)) +(defun image-dired-scroll-up () + "Scroll up the in thumbnail buffer." + (interactive nil image-dired-thumbnail-mode) + (image-dired--movement-command-scroll)) + +(defun image-dired-scroll-down () + "Scroll down the in thumbnail buffer." + (interactive nil image-dired-thumbnail-mode) + (image-dired--movement-command-scroll 'reverse)) + ;;; Header line @@ -980,6 +1000,8 @@ image-dired-thumbnail-mode-map " " #'image-dired-end-of-buffer " " #'image-dired-move-beginning-of-line " " #'image-dired-move-end-of-line + " " #'image-dired-scroll-up + " " #'image-dired-scroll-down :menu '("Image-Dired" -- 2.40.0 --=-=-=--