From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#64977: 29.1; `auth-source-macos-keychain-search' handles :user key incorrectly Date: Sat, 12 Aug 2023 18:02:59 +0200 Message-ID: <87r0o8z1sc.fsf@gmx.de> References: <831qg8g37f.fsf@gnu.org> <87leegqyk3.fsf@gmx.de> <87wmy0z9lp.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27212"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 64977@debbugs.gnu.org To: LdBeth Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 12 18:04:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUr6D-0006rR-0k for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Aug 2023 18:04:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUr5w-0005f6-3h; Sat, 12 Aug 2023 12:04:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUr5u-0005dO-Ob for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 12:04:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUr5u-0007z4-FL for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 12:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUr5u-0000gk-1X for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 12:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Aug 2023 16:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64977 X-GNU-PR-Package: emacs Original-Received: via spool by 64977-submit@debbugs.gnu.org id=B64977.16918561982591 (code B ref 64977); Sat, 12 Aug 2023 16:04:02 +0000 Original-Received: (at 64977) by debbugs.gnu.org; 12 Aug 2023 16:03:18 +0000 Original-Received: from localhost ([127.0.0.1]:56696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUr5B-0000fj-Mb for submit@debbugs.gnu.org; Sat, 12 Aug 2023 12:03:17 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:59553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUr57-0000fP-4z for 64977@debbugs.gnu.org; Sat, 12 Aug 2023 12:03:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1691856180; x=1692460980; i=michael.albinus@gmx.de; bh=ZOqnQ7ipUqyJryMCjTjd0fZ8lHOouRoITeca6BOVgb8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Q7ejM7VubO1djlMzZnqlrzMrLMwZLzwzqdOKgNiXJVTAc1lo0rCODXjrR8CWRwhGFv10NN+ M0wNaRDkq8ddrUbUtPZfGDvSCfGOA03MGt3DSkB3WE+LcasYJbSE+QQnAbZERXBJSMKWR5s9i lweUBZaTqFyA5N0BFCFEZTO3Y0By+2DpdIPV7dlxG+C4iCWi0GYmxEcaWrG+t4kW/atlC2zI/ qJa2KhEM2k0ysLn3jXH0ApUp2YImSFjCB9sSU7OGAPyxWSsY3c+zPxwmzqCZziziqFNJAFwnC RIYFFKS6i9stViuBuRcb3rPeDnb+U9JeWzu//pL0Zv2M7ShjPQsw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.27]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N0Fxf-1pXgDD29FX-00xMRK; Sat, 12 Aug 2023 18:03:00 +0200 In-Reply-To: (LdBeth's message of "Sat, 12 Aug 2023 10:40:36 -0500") X-Provags-ID: V03:K1:lSF/00mlohSsh3sLnru3IaOUBZTk2zauv2bqugWKRnKkPUKP+o5 sUZPN3QHwM0jQlia4e8JKFp29Z4VDz5t/QAmcAzWgJn6lc1h0KM8d3+L/U6LQ4v/mY5Dka0 wtmsjdCst3JceaaTegfzjw8g82hUrpXTux8YcddJCrT+RXjdRYC0VQME3ejQGjGbM7CsjrN 0j+Yz8dT7rSPgpQkTnbGg== UI-OutboundReport: notjunk:1;M01:P0:cT+HRtuftZY=;jcZ4P7VjLXJ4XcrnSo8+kWMl+lt OluekNkhEWG8H912WgV+ZRg2dzW7MiUUqSgL1okHRE+Vq+EeesQkj6Y/cu0qXCAGDSzoPDao5 DVpDt9qNWoik65xY3tgf/U8xY8ShILTuWPoGS3E3kgZA0aeGe9obvAC8mzJGLbcawpCIkt8du dFFbq3Ode0vinSrqNFUBrnc+w9h2Wuj4NGKjKcRPKbDkbUkOtEfkBrxlad1ZDGsZGTx8z6FZS f9vrwVYn859uHR9h/q+GPZbbtUd14PZZqR3HIM4zdyveEE/EnHDi7+tIYRZmn3cgFQRwXBGfX s2FrCHtEIEv6Cl323Lq3aLDkX/25vIdeaNuFIPzLPCH3cbgixlA7HslsjnIlMyoeuUZM8fh6U Sa6KjFwiJ/s+fqGly1MP7oQtzXIcNeiuQN7psqxOMuMYKYV/Gws/Ae02GsrBgNP5oHPuHSucE ApgAhmZI5pfqc8WAc/7WYNOuokzXaZgk2YDVZPQOZyKo/tnDeql3/u9QkdMFs34UKVl4tZeut VEQMjqGbKU0sSSDECQdoRGJs5+GmfeKs7EAgBXTyp900Q89vL7/FU+JnmG5JiBcfVUIkpDf77 2ubqYUtNU+neKI+j2t3B6V/vasOJ31+BoDsb0DgaqPNBzWAkbEFCu5LLZ1eZKLWRS8vgUdHQA pmUnyQS2VjolnybdZyqU5hpE21KV2thm9oy5oVx2Y2OF73ZUB6iF4BI/CGmq2eY11os4f7tkB HVZURhSQ3iDTjrlR1hXF38qvowqTCq3tLcx4GBlYedlWbTROwTKZFr9+B3JEV/jMKG/bvJbU X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267313 Archived-At: LdBeth writes: Hi, > I think it is possible to use cl-left to redefine > `auth-source-macos-keychain-search-items' to avoid calling external > security command and just check the argument passed to > `call-process'. > > Something like: > > (cl-letf (((symbol-function 'call-process) (lambda (&rest r) (print r)))) > (auth-source-search :user "ldb" :port "irc")) > > ("/usr/bin/security" nil t nil "find-internet-password" "-g" "-a" "ldb" "-r" "irc ") > > ("/usr/bin/security" nil t nil "find-generic-password" "-g" "-a" "ldb" "-s" "irc") Yes, like this. And in the lambda function, you could check the expected arguments of the "/usr/bin/security" call by `should' and friends. Would you like to add such test(s)? This would give us more confidence that nothing is or will be broken, because people using macOS would test this by default when running "make check", even if they don't care the macOS keychain. > ldb Best regards, Michael.