From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#64046: 30.0.50; Quoting in customize choice tags Date: Mon, 28 Aug 2023 15:50:10 +0200 Message-ID: <87r0nnmg31.fsf@gmx.net> References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> <87bkewpogr.fsf@gmx.net> <87h6oo2may.fsf@gmx.net> <65eb4677-5ae3-5170-1b37-2e02f974c972@gmail.com> <871qfqiygn.fsf@gmx.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10135"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Mauro Aranda , 64046@debbugs.gnu.org To: Ola x Nilsson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 28 15:51:05 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qace1-0002TL-5W for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Aug 2023 15:51:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qacdu-000599-NN; Mon, 28 Aug 2023 09:50:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qacdr-00058z-SO for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 09:50:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qacdr-0003Zn-Kl for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 09:50:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qacdx-0005xY-Mk for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 09:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Aug 2023 13:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs Original-Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.169323063022867 (code B ref 64046); Mon, 28 Aug 2023 13:51:01 +0000 Original-Received: (at 64046) by debbugs.gnu.org; 28 Aug 2023 13:50:30 +0000 Original-Received: from localhost ([127.0.0.1]:47438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qacdS-0005wl-17 for submit@debbugs.gnu.org; Mon, 28 Aug 2023 09:50:30 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:45797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qacdP-0005wU-Sc for 64046@debbugs.gnu.org; Mon, 28 Aug 2023 09:50:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1693230612; x=1693835412; i=stephen.berman@gmx.net; bh=/35x9Ya+NzeRGHtGobeRDejNtlUW9/cycJ8eVO43IwQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Vp1lSlAIli38XibJKiGavQjPQxc9ngDCFUjU3tlx2Jcf5ySIM0noX+TH32iCyq1uAQVt6FF y8GW0J97e81xsUtEgg0HQ6QWdRzv7HsdkKasCmke47E1b7JPU/FiZJYWrou4z/mgC9lvTvRm9 JUNEK+ltUBwgMVjcrBXvTrD3lmaiDwM28q/y70BEbwjmQP94gKxK7LQlhxGJ0L2YIBmdZEuvE UWsxUKmaEOb6CC0OaFYt+8azaejs9CqTb+Q1a2LI5VcJE1CYXeWGwhYBFTlKfYxYlq0ChwUvN U6CR5XVvCVNlPd0F1MabNdmaEv285JrP/+PdTvHXDaoTq8ffFbgw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfssd ([89.246.36.68]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MJE6F-1qHj0C3Is7-00KcwQ; Mon, 28 Aug 2023 15:50:11 +0200 In-Reply-To: (Ola x. Nilsson's message of "Mon, 28 Aug 2023 11:33:09 +0200") X-Provags-ID: V03:K1:tr30QfEJ/G3BfX62WLdAaPA/Ei0yhympUWTl3a5dMCFEgQChD/6 NEUuoRMdcKVjL55VWx7d7KaqVcxl7zzicD6QEG4DwJJ5a2E+OU5wiog5TOdF4ZbS5vZKWv3 hCQzlQW6C+dFZtzki6o5KhNU/WlUPG30lyyUFTD9zyq5IQjvPkAbnQ++2Eqg3s+omXx5syZ HdR8ZVzEscEKcmosqw/RQ== UI-OutboundReport: notjunk:1;M01:P0:FCVxjgYYXqY=;MWbdaPQpxrf1Xhuv1xu47hbfYkm VssqYH9j2ZXjlZWNCCsuyiPvRdjHggQpZNgQGRhWYn7nJjs6aq+NlQ23ZBA0r98npq216V7iM yaVkri/9bomALl+e26jl2rar6UxM8PTxXu8LJ6IOwS8BFlhFmeA+VQQDpBU7Oo7GpRwWngpJu tovUybAttFV5Ekc/tFNyNourdbl9gqWxNdaYv7n0/c65EHXMIJKdsNs2rgwr95rRoCh3T0Fio lhDjwmlDIXxJI7XcQwacWHBZvn9DLOgFO+InxtSmmj4RK70/6jimYE9MIOEXbG3/3Wr02tDX0 W+Je/E9ZtFeY3l8tasGfkzVQZCtG0Mj1kET4ZFZsS+CapraeTYMR+TcMKjPZmt+UVnWSCQEku 5dF6zcvxEv/aYQEDRlSo0yGeXFojgYaPm51wyd9xB8vYCoHbssQDgQLkLWB7vvEUXvp/qW7TE rtyF9/xH5b0apQh/1Vmruddh4dqJuy7kCzDeQD9xxskHtpwr5O+NrGK0tjyEgC+bp9sX5Mc1Y U/jCXernpqjq55634ky2fUB4g2+PmWJtjtKh3wAst0lUmLXhCNAIJWvgZ5vrD7kOE+0Oi46CD R40NSkshPxI9HaoF18hc0yua5YHkD1rR4g9StQ84+yMca1QNFoU0WV7tX5rqnq4DC9XXefixN AM79UX9H4HvuS+K77CZqJ9imi85qG/5vRGp2liM8YigAKCAzfKTTpMuMpUg0CMiwSVCx1EAYU v2oDuPCQ6jD/NqPZhb/zao4gO2xdH7i2jQ9YFxUlP9JGzARsL94F1UeWQZbpTlkQjSq+p5gR X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268630 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, 28 Aug 2023 11:33:09 +0200 Ola x Nilsson w= rote: > On Fri, Aug 25 2023, Stephen Berman wrote: > >> On Fri, 25 Aug 2023 10:02:35 +0200 Ola x Nilsson wrote: >> >>> On Thu, Aug 24 2023, Mauro Aranda wrote: >>> >>>> Stephen Berman writes: >>>> >>>>> On Thu, 24 Aug 2023 17:14:53 -0300 Mauro Aranda >>>> wrote: >> [...] >>>>>> Thinking about it, why do we need to call substitute-command-keys on= the >>>>>> VALUE part (i.e., the cdr of the cons cell), in case of simple item >>>>>> definitions? >>>>>> >>>>>> I re-read the bug report, but I didn't find any reference to why tha= t is >>>>>> a need.=C2=A0 Did I miss something? >>>>> >>>>> Well, the VALUE is displayed on entering a choice.=C2=A0 That is, whe= n I do >>>>> >>>>> M-: (widget-choose "Title" '(("Use `a'" . "Use `1'") ("Use `b'" >>>> . "Use `2'"))) >>>>> >>>>> I see curve-quoting in the widget-choose buffer: >>>>> >>>>>=C2=A0=C2=A0=C2=A0 Available choices: >>>>> >>>>>=C2=A0=C2=A0=C2=A0 0 =3D Use =E2=80=98a=E2=80=99 >>>>>=C2=A0=C2=A0=C2=A0 1 =3D Use =E2=80=98b=E2=80=99 >>>>> >>>>>=C2=A0=C2=A0=C2=A0 C-g =3D Quit >>>>> >>>>> and when I enter e.g. `0' at the "Title: " prompt in the minibuffer, = it >>>>> displays "Use =E2=80=981=E2=80=99", i.e., with curve-quoting.=C2=A0 B= ut if I omit the call to >>>>> substitute-command-keys on the cdr in widget-choose, then typing `0' = at >>>>> the "Title: " prompt displays "Use `1'", i.e. with grave-quoting.=C2= =A0 But I >>>>> don't know which one is the intended result. >>>> >>>> I see, thank you.=C2=A0 Your last patch looks good to me, then. >>> >>> The cdr is the return value, I would expect widget-choose to not >>> modify that.=20 >> >> I think this is indeed the correct expectation and I should have >> recognized it instead of looking only at appearances. But do you agree >> that applying (at least) quote substitution to the car of the simple >> item definition is appropriate here? If so, there is still the question >> of whether to use substitute-command-keys or just substitute-quotes. >> I'm inclined to stick with the former but would be fine with going with >> the latter. > > I agree that quote substition should be done on the car of simple item > definitions. I have no opinion on susbstitute-command-keys vs > substitute-quotes. But I came to think about the TITLE argument, > shouldn't quote substition be performed on it as well? I think you're right about that as well, since the title is simply a display feature. AFAIK it wouldn't make a noticeable difference for existing uses of widget-choose in the Customize UI (in the Value menu the title is simply "Choice" and in the State menu it's "Operation on