From: Rahguzar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 66676@debbugs.gnu.org
Subject: bug#66676: 29.1; Should some aspects of shr rendering be configurable
Date: Sun, 22 Oct 2023 12:26:53 +0200 [thread overview]
Message-ID: <87r0lnx7kx.fsf@zohomail.eu> (raw)
In-Reply-To: <83o7groufg.fsf@gnu.org>
Hi Eli,
Eli Zaretskii <eliz@gnu.org> writes:
>> 1) Using `visual-line-mode` for line wrapping. I think this is more
>> natural for html and makes resizing windows work more nicely.
>
> AFAIR, there were good reasons for the decision to fill text in shr.
> So this could be an optional feature, but not the default.
>
I was thinking of an optional feature too. I am not at all confident
that visual-line-mode will be good enough for tables for example.
> shr breaks lines on images because Emacs is incapable of displaying an
> image without making the line of surrounding text high enough to allow
> the image to be displayed.
I agree with this too, but the images I was thinking of are typically
around the same height as the surrounding text and I think these
newlines should be the responsibility of `shr-put-image-function`. The
default value `shr-put-image` already checks if image is more than 400
pixel wide and in that case inserts it into a new line. So I propose
adding a new `shr-max-inline-image-size` variable which a cons of
`WIDTH` and `HEIGHT` and images are inserted into a new line only if one
of its dimensions is bigger than the ones specified in
shr-max-inline-image-size.
>> 3) shr uses 0.2 and -0.2 as value of raise property for superscripts and
>> subscripts. I think it makes sense to make these values customizable.
>> For me 0.2 for superscripts was too low and 0.4 worked much better.
>
> No objection to making this customizable.
>
>> 4) shr uses 100 as the value of :ascent when creating an image. For me
>> this makes the inline images appear off centered. I fiddled with it a
>> bit and found 60 to be a good value for me. I wonder if it makes sense
>> to makes the value of :ascent to be customizable? My instinct is no
>> since I think the correct value can probably be computed from image
>> height and the average height of default face.
>
> I think it could be customizable even if it's computed from the image.
I will start with just making it customizable then since that is simpler
and send a patch adding the customizations listed above somewhat soon.
Thanks,
Rahguzar
next prev parent reply other threads:[~2023-10-22 10:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 7:29 bug#66676: 29.1; Should some aspects of shr rendering be configurable Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-22 9:52 ` Eli Zaretskii
2023-10-22 10:26 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-10-25 16:18 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 8:10 ` Eli Zaretskii
2023-11-04 9:06 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 12:05 ` Kévin Le Gouguec
2023-11-18 8:59 ` Eli Zaretskii
2023-11-19 12:07 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-22 20:14 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-25 11:01 ` Eli Zaretskii
2023-11-18 13:08 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-18 18:09 ` Kévin Le Gouguec
2023-11-19 11:12 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0lnx7kx.fsf@zohomail.eu \
--to=bug-gnu-emacs@gnu.org \
--cc=66676@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rahguzar@zohomail.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).