From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer Date: Sun, 10 Dec 2023 21:42:06 +0000 Message-ID: <87r0jtbuq9.fsf@zephyr.silentflame.com> References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14051"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 67661@debbugs.gnu.org, Eli Zaretskii , Eshel Yaron , 67001@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 10 22:43:04 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rCRZl-0003L7-Sx for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Dec 2023 22:43:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCRZZ-0001iM-Rp; Sun, 10 Dec 2023 16:42:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCRZY-0001i8-LP for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 16:42:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rCRZY-0006FG-Dc for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 16:42:48 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rCRZm-0006Bp-Of for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 16:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Dec 2023 21:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67661 X-GNU-PR-Package: emacs Original-Received: via spool by 67661-submit@debbugs.gnu.org id=B67661.170224455123747 (code B ref 67661); Sun, 10 Dec 2023 21:43:02 +0000 Original-Received: (at 67661) by debbugs.gnu.org; 10 Dec 2023 21:42:31 +0000 Original-Received: from localhost ([127.0.0.1]:51870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCRZG-0006Ar-J8 for submit@debbugs.gnu.org; Sun, 10 Dec 2023 16:42:30 -0500 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:41669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCRZD-0006AY-EV; Sun, 10 Dec 2023 16:42:28 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 8E1EF5C00A7; Sun, 10 Dec 2023 16:42:07 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 10 Dec 2023 16:42:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1702244527; x= 1702330927; bh=E8V89cxmg9G9QkkYx3v7vOqCgouK+kq/njNUP87GGyU=; b=N 0HhW1/J+ziGLvbxyuxhZT2ZVCZjb4FdDu7+50+amkn0WHT6NRSi5mIAMa7dNyacD NwfmunjFNYSK2x7UHAdc+9Omfdymc0aNcNvkmjWQ5Ez4QYFtzLbdueTnrp7eHp/v 6JfKvKlZ+AvNsfyjk5HN0pguytrrzloDy8rnHIMYeS1wTEDixVeHIl8+/6LNt+zJ Y3famdgJRh4ZsyisJbi2I1biwesJhqRjuy3svMbVnuut5353UQqg4jyXKLuWQ+k2 RPA9xIdc78Rq+zV7Tk32pKK5rKF1rMl/+y84pRVJsjf3K6LDCb50sSdtDZ8z1/t/ dwa00/SGHb06OoB1UQf/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1702244527; x=1702330927; bh=E8V89cxmg9G9Q kkYx3v7vOqCgouK+kq/njNUP87GGyU=; b=nMQGgr7NdjgLdsgvmv5uDnGDH7B0w z8L+NTo4ryGNhMitz3zuYAN0b65C/y//E4S+l38OPujnSLxeQjYKUekhbXqhShHn Hlb0/GyNe4gqus4L1PsrwCxda/Gyf85FA6dj+f1AKphNA4qi5LRHQLIj787YgT33 IjD7aGRYeu1DsFMaXQC+O8Z3qQoZI+h7VPa1U9k6B/mqxv+RXjiv6AvFQazf4H2j 9YZe3DFF9klFwEy/lJe5ehih4bX05GDqiYyXPkVd4RweOEFbckDWyJeTK0lgclxb I6qHx9r9AR9stF+TxscWACPLEHtxAkENpDzY+u2GI1bioo7EF6RTFoQKg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeltddgudehgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 10 Dec 2023 16:42:07 -0500 (EST) Original-Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 34F229410BF; Sun, 10 Dec 2023 21:42:06 +0000 (GMT) In-Reply-To: <86msuihxwl.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 10 Dec 2023 19:46:58 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275943 Archived-At: Hello, On Sun 10 Dec 2023 at 07:46pm +02, Juri Linkov wrote: >> Okay, well, if we think about it in terms of finishing the feature, then >> as the person who worked on it previously, could you share how you think >> it ought to work? >> >> ISTM that a single tab in Eshell starting completion, and a single tab >> not popping up a *Completions* buffer, are pretty clearly what we would >> want it to do, but maybe I just got used to it :) > > I think that Eshel is right about setting `completion-in-region-function` > to a new function. This function should be like `completion--in-region` > but without this line: > > (completion--in-region-1 start end) > > If you just remove this line from `completion--in-region` then > it should work like you expected without popping up *Completions*. Thanks, that does indeed restore the behaviour. Should we change this to a different completion-in-region-function in icomplete.el, then? Or what did you have in mind? -- Sean Whitton