From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Sun, 17 Dec 2023 11:26:28 +0000 Message-ID: <87r0jlysrf.fsf@localhost> References: <878r919qfh.fsf@localhost> <83fs06rz10.fsf@gnu.org> <87fs06w4ui.fsf@localhost> <83bkaurut9.fsf@gnu.org> <87o7esq319.fsf@localhost> <83bkasrb3f.fsf@gnu.org> <83wmtgpuyf.fsf@gnu.org> <871qboprh3.fsf@localhost> <87y1dwobey.fsf@localhost> <878r5v20gu.fsf@localhost> <83bkapl5zh.fsf@gnu.org> <83zfy9jkoh.fsf@gnu.org> <878r5tglwp.fsf@localhost> <83ttohjet0.fsf@gnu.org> <8734w114pa.fsf@localhost> <83r0jljdoa.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25238"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org, mattias.engdegard@gmail.com, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 17 12:24:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEpFt-0006PI-Ih for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Dec 2023 12:24:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEpFh-0001jc-W3; Sun, 17 Dec 2023 06:24:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEpFg-0001jU-Uq for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 06:24:08 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEpFZ-0004Yx-EF for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 06:24:08 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEpFa-0001c7-CY for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 06:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Dec 2023 11:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.17028122106154 (code B ref 66117); Sun, 17 Dec 2023 11:24:02 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 17 Dec 2023 11:23:30 +0000 Original-Received: from localhost ([127.0.0.1]:56656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEpF3-0001bB-QB for submit@debbugs.gnu.org; Sun, 17 Dec 2023 06:23:30 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:48307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEpEz-0001ar-SL for 66117@debbugs.gnu.org; Sun, 17 Dec 2023 06:23:28 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 90A02240103 for <66117@debbugs.gnu.org>; Sun, 17 Dec 2023 12:23:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1702812198; bh=ZrAlSE4gf/bMVdVvD2uC6h6RQCEFkvdAnRZSl448nmc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=ab+HyDOnRbe1WSDEbkXDMS0bV4gD7T6T8Y2g0nghG+lFlSIMA8V0lQQODUvUDKR8z RqIV1ViaWbtRoerqz02AW66k8a1+0spmmwUwUpwfsDZ5f5DfeaiOb7g4oAcAhCcd/i +MtYLpPvMczSbweLE5p930E6+SdUZwUI/byPqTGvqJUeqxQuZgWR8sqhNhBWYcAotM UVPJ+6nEstr/gO1qiPVUsVxLcAZdLJk4ZNIJC50OJHj3LWpwUY5Uj3ya9NpRYGzBEn gTMYQqBxFuBgjSNo1Km/7TONGBuaJl7+DT9Ibt93rh7a1Wx5GsTT7xyfmK3Gbu8ISE 7bsjdNoY3GQQQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4StLDQ06Rfz6tm4; Sun, 17 Dec 2023 12:23:17 +0100 (CET) In-Reply-To: <83r0jljdoa.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276417 Archived-At: Eli Zaretskii writes: >> > Maybe I'm confused, but won't this change have at least _some_ effect >> > on Lisp programs? For example, what about this fragment from the >> > ELisp manual, which describes the effect of >> > make-variable-buffer-local: >> > >> > A peculiar wrinkle of this feature is that binding the variable >> > (with =E2=80=98let=E2=80=99 or other binding constructs) does not= create a >> > buffer-local binding for it. Only setting the variable (with =E2= =80=98set=E2=80=99 >> > or =E2=80=98setq=E2=80=99), while the variable does not have a = =E2=80=98let=E2=80=99-style binding >> > that was made in the current buffer, does so. >> > >> > Will this case work the same after the change as it did before? >>=20 >> I read this differently > > Differently from what? AFAIU, you are concerned that my call to Fmake_variable_buffer_local may have unexpected side effects because make-variable-buffer-local can be tricky, as stated in the quoted paragraph. But it is not how I read this. Or did you mean something else? >> - when you have >>=20 >> (let ((var 'val)) >> (make-variable-buffer-local 'var)) >>=20 >> it will not set buffer-local value to 'val. > > And before the patch what would have happened? I did not make changes to `make-variable-buffer-local' in the patch. Nothing changed there. I just wanted to make sure that we understand that paragraph the same way - that `make-variable-buffer-local' has "wrinkle" when called inside let context. >> And the patch makes `case-fold-search' buffer-local internally. Nothing >> needs to call (make-variable-buffer-local 'case-fold-search). > > The patch itself calls make-variable-buffer-local. On top level, when Emacs defines all other variables. So, my call to make-variable-buffer-local is not inside let and thus should not have any problem with the paragraph you quoted. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at