From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#68947: 30.0.50; Gnus article mode keybindings Date: Sat, 10 Feb 2024 10:09:14 -0800 Message-ID: <87r0hkxkc5.fsf@ericabrahamsen.net> References: <87bk8ut2qd.fsf@gmail.com> <871q9p39zp.fsf@ericabrahamsen.net> <87r0hofow9.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18261"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 68947@debbugs.gnu.org To: Pranshu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 10 19:09:57 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rYrnY-0004aF-MG for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Feb 2024 19:09:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYrnQ-0001zn-6m; Sat, 10 Feb 2024 13:09:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYrnO-0001zR-PH for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 13:09:46 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYrnO-0003xP-HC for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 13:09:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rYrnd-0001hQ-V1 for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 13:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Feb 2024 18:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68947 X-GNU-PR-Package: emacs Original-Received: via spool by 68947-submit@debbugs.gnu.org id=B68947.17075885806471 (code B ref 68947); Sat, 10 Feb 2024 18:10:01 +0000 Original-Received: (at 68947) by debbugs.gnu.org; 10 Feb 2024 18:09:40 +0000 Original-Received: from localhost ([127.0.0.1]:59041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYrnI-0001gI-36 for submit@debbugs.gnu.org; Sat, 10 Feb 2024 13:09:40 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:45712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYrnF-0001fr-RB for 68947@debbugs.gnu.org; Sat, 10 Feb 2024 13:09:39 -0500 Original-Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id CA0C6FA0B2; Sat, 10 Feb 2024 18:09:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1707588556; bh=1D+xeEcV1pDRYeDSIS6MO63jyjt++UW8/hmm+3EQEco=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Z0pTS52ISEk+in46NHA56xE6wWQ7k6TcoRJt3zARqWkU3ZAswzc4NpauFkn6i67EN e1ys8U/upD0vBbV9gSQIkJseLyuq+gSOeHHBxXMxjcFYEwW2b/hIJKvqyJnMlcPneQ tyB8omNDGZYR/2Yc4+FvebdrydpxJavAFpp00pS8= In-Reply-To: <87r0hofow9.fsf@gmail.com> (Pranshu's message of "Wed, 07 Feb 2024 22:19:02 +1000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279778 Archived-At: On 02/07/24 22:19 PM, Pranshu wrote: > Eric Abrahamsen writes: > >> Pranshu writes: >> >>> Recipe from emacs -q: >>> 1. M-x gnus >>> 2. Select any group >>> 3. Select a random article >>> 4. do `W C-h' or C-h m >>> >>> W C-h simply does not work while C-h m works, but does not show the >>> bound keys. >> >> FWIW I'm unable to reproduce this, using Emacs master. I'd be pretty >> surprised if Gnus were able to break such low-level functionality, too. >> Can you give us any more clues? Is this something that only started >> happening recently? > > With the point in article mode, are you able to reproduce it? (Sending this back to the bug report...) Yes, I'm able to reproduce it, and it sent me down a really awful rabbit hole -- gnus-art.el goes to huge lengths to make summary-mode keybindings available in article mode. It uses this: (substitute-key-definition #'undefined #'gnus-article-read-summary-keys gnus-article-mode-map) to redirect all unbound keys to the `gnus-article-read-summary-keys' function, which manually reads keys and dispatches to tweaked versions of summary-mode commands. Your immediate issue is caused by the fact that `gnus-article-describe-bindings', which theoretically should be responsible for telling the user about all the redirections, is only aware of the "S" keymap prefix. It doesn't know all the ways in which an 'undefined binding might get translated into a valid summary-mode command, and can't show you those. To be honest, I don't think I'm going to be able to fix this. If we keep the current implementation, `gnus-article-describe-bindings' would have to be made aware of the additional redirections, and I wouldn't even know where to start. It could be that Elisp has better tools for this situation by now (the original architecture was in place before 1997), but I'm not sure what those tools are. Perhaps someone will chime in with a helpful suggestion... Eric