From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Date: Sat, 24 Feb 2024 19:45:49 +0530 Message-ID: <87r0h2x816.fsf@outlook.com> References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> Reply-To: James Thomas Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38864"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69232@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 24 15:17:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rdsps-0009xw-Vd for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Feb 2024 15:17:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdspU-0006EV-U4; Sat, 24 Feb 2024 09:16:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdspS-0006CH-Ob for bug-gnu-emacs@gnu.org; Sat, 24 Feb 2024 09:16:38 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdspS-00063H-FO for bug-gnu-emacs@gnu.org; Sat, 24 Feb 2024 09:16:38 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdspq-0000wi-JW for bug-gnu-emacs@gnu.org; Sat, 24 Feb 2024 09:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: James Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Feb 2024 14:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69232 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69232-submit@debbugs.gnu.org id=B69232.17087841863534 (code B ref 69232); Sat, 24 Feb 2024 14:17:02 +0000 Original-Received: (at 69232) by debbugs.gnu.org; 24 Feb 2024 14:16:26 +0000 Original-Received: from localhost ([127.0.0.1]:59012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdspG-0000ut-1H for submit@debbugs.gnu.org; Sat, 24 Feb 2024 09:16:26 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:60805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdspD-0000uW-FX for 69232@debbugs.gnu.org; Sat, 24 Feb 2024 09:16:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1708784152; x=1709388952; i=jimjoe@gmx.net; bh=e9Auda+VGgSo2QhmvGednYcB79J6ls5yZWp6szC2aKc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=Q09JTcpLvS//P1ZmecjaofT3zOikyJPJzIgruzwWE4J20XJhItzcbvaSqDNBeIl0 SZ2pCpRWJQUTx7V0ovIi9pbv2Olp/z0N0MZHEpgpntrsSH06c1Mm1Ne9fJarvKH/B B08m2tAuePR9cRaaBzlZwS68/HZEuILdmaCe6/hXje7rSR4WiCtu1KJq7l6Msjuqc 3Xcf80R4t4E+Jm+sRXrC2EiG0+xGxvMVREVYmPGdvBvFY7+egeWRas8LVDFkpXhx8 tjsDY5UCKGhmlogQ8Ce2V8TFRZ50q8b0muUuM3s3TUT5i+KphUjhKeEL2eQOeRzOM zSP/1NhBPAodFHmsmg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from user-Inspiron-15-5518 ([117.194.144.213]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MJVHe-1rK0WF3kJE-00JtOW; Sat, 24 Feb 2024 15:15:52 +0100 In-Reply-To: <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> (Jim Porter's message of "Thu, 22 Feb 2024 12:10:36 -0800") X-Provags-ID: V03:K1:HD40EDUfD5ybZ78m5FyF9kUa5Uw4r/8fuXJPplsMAd6p/iraCQh NhSuVuhANzziSSdCVyXriMvVoxobxHQTzNZXW+mF0KwPWjezJjjLEgO2J5RxOoR3HkK7DR2 jpYzZJL17WwlOpqEm/kUkYOi2ROW1UF5q9Yfizv8stULEKQhxfXVA1XaOJpqH9xFHMT4OGo HztmhKB/64c9qoRhzGGBQ== UI-OutboundReport: notjunk:1;M01:P0:4yubWSGX44I=;ERvXNG5KQ7zNbuwXATEn+Et6eOL noTsUgCm9DmOjP2+Y5ynXjt2CB8i4GUEIgc2gjgf5KlyTEqHPJwEpb5BfoaEC69dkyJxzdcLU Tycl3uz4LxScQJYvypijFCZnniCdWezozf0NZTnlY4Tje7OqMZ0ICROOq6y/uMs3w7RAJSn8L YYqjkcpxZjIZPdLf+V50nAcmQ9IsbOwZzlhiA0NxeZdwT7rnQPzBuoaVjL5LHPrwWb5JDVPY/ MzGG0WfIBcTQTlJjN7welj3WMnMSjmQ4+OG/rzJBoGZ7A1HNKN2UFPN7T7AiYPBDqmVjdkpbn 6BZ0ZdSu8Le3Kfvg/CMzvWVMipz1LXfO8XojVLPceKXrRxqwc95fMfyCHyBkcr/AKUlzIRAw+ bAwIGJwknMKFPl02P9KhxsXZecav6IwJTqq9APW5JcvyczgWycCb1kYEwWbkWiy2wg+8bekqJ WuV4+vXmOgsNrHuBiR/nWyXSfmDa76q+tDaGTwbjWNomIiSocYXeapWPm6xFZZV0dQD/hEZAR +HK/ttXvl6rHE4wf+SFelu3ON9NBwrjat4aH2eK20NUWBqg4FFtL9cg/y1mn36E0IpMOyUYYL m2I/l8hb2LX2CbaJSU9GUZ/QL+eZh0F0EHEOJIRc91s1sHrYjsYgKzfI4eVlYyh5NPNaR2I+7 fqdqDN4f20CUD22HRFVmKoZXDjY/JcrmMEAOTlHuPIMf2HAtZOZY0KcQeL2LepaVJsy+kxgPd vPg+10879X2uYUDNxUXpIRRmJHMbNcZ5SdgcIzfj+Kc+CNMf86ThvYHiNsWi3bt3anHITRs9 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280548 Archived-At: Jim Porter wrote: > From 0f2528482527262ff59153595d7a3f10517153ca Mon Sep 17 00:00:00 2001 > From: Jim Porter > Date: Sat, 17 Feb 2024 20:49:15 -0800 > Subject: [PATCH] When navigating through history in EWW, don't keep adding to > 'eww-history' > > This resolves an issue where navigating back and then forward kept > adding new history entries so you could never hit the "end" (bug#69232). > > * lisp/net/eww.el (eww-history-position): Add docstring. > (eww-mode-map, eww-context-menu): Use correct predicates for when to > enable back/forward. > (eww-save-history): Save history entry in its original place when > viewing a historical page. > (eww-back-url): Set 'eww-history-position' based on the result of > 'eww-save-history'. > (eww-forward-url): Set 'eww-history-position' directly, since > 'eww-save-history' no longer adds a new entry in this case. > > * etc/NEWS: Announce this change. > --- > etc/NEWS | 8 ++++++++ > lisp/net/eww.el | 39 ++++++++++++++++++++++++++++----------- > 2 files changed, 36 insertions(+), 11 deletions(-) One possible problem with this patch, I realize now, is that if you navigate backward ('l') and then visit another link there, the new page is added to the very end of history rather than the immediate next position. This would be confusing if you, then, navigate back and find that it's not the page from which you followed the link. Perhaps the original code was a hack around this? -- James