From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions Date: Wed, 08 May 2024 23:53:38 -0700 Message-ID: <87r0eb79xp.fsf@breatheoutbreathe.in> References: <87edcrtegz.fsf@gmail.com> <87sf15rjyf.fsf@gmail.com> <8734t5yh49.fsf@posteo.net> <87edcp9p54.fsf@breatheoutbreathe.in> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13062"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69528@debbugs.gnu.org, iarchivedmywholelife@gmail.com To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 09 08:55:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s4xgG-0003JH-3U for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 May 2024 08:55:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s4xfr-0004Su-9W; Thu, 09 May 2024 02:54:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4xfo-0004Sc-Lx for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 02:54:36 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s4xfo-0005SD-De for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 02:54:36 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s4xgE-0006oC-09 for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 02:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 May 2024 06:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69528 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, No Wayman , 69528@debbugs.gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.171523766826161 (code B ref -1); Thu, 09 May 2024 06:55:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 May 2024 06:54:28 +0000 Original-Received: from localhost ([127.0.0.1]:53444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4xff-0006nt-OI for submit@debbugs.gnu.org; Thu, 09 May 2024 02:54:28 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:45034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4xfa-0006nX-N6 for submit@debbugs.gnu.org; Thu, 09 May 2024 02:54:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4xf4-0004Qc-8a for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 02:53:50 -0400 Original-Received: from out-174.mta1.migadu.com ([95.215.58.174]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4xf2-0005IE-0g for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 02:53:50 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1715237623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EHMj+LLE8x1MyzVijC/CRMo9U6u5nZMk3k0WC3BItxc=; b=GZUEXMAepkBc1NcQdOCjRojO303gpk6wvcDfJRNmv7ZEW58B5sPuFk9J87VxnoYI4rYBE7 Q2RaDnOL8BM7VfXEQDKtrcDgHFuacNGGR0a8TAm18DXSvM7CZ35OpdbpG+G8rYVmvZe/aA YLe4u98f/Vy2Qw0W8+LrhDKWpGljyX4= In-Reply-To: <87edcp9p54.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Mon, 04 Mar 2024 22:17:30 -0800") X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=95.215.58.174; envelope-from=joseph@breatheoutbreathe.in; helo=out-174.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284720 Archived-At: Joseph Turner writes: > Philip Kaludercic writes: >> So in general, this patch might be appropriate? >> >> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el >> index 581053f6304..42f386933dc 100644 >> --- a/lisp/emacs-lisp/loaddefs-gen.el >> +++ b/lisp/emacs-lisp/loaddefs-gen.el >> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file >> ;; loaddefs for packages so that `syntax-ppss' later gives >> ;; correct results. >> (emacs-lisp-mode) >> - (let ((version (lm-header "version")) >> + (let ((version (or (lm-header "package-version") >> + (lm-header "version"))) >> package) >> (when (and version >> (setq version (ignore-errors (version-to-list version))) >> >> > > What about making `lm-version' handle the "package-version" header then > using `lm-version' in loaddefs-generate--parse-file? See patches. > > Joseph > > [2. text/x-diff; 0002-Use-lm-version-instead-of-lm-header-version.patch]... > > [3. text/x-diff; 0001-Check-Package-Version-header-in-lm-version-also.patch]... Ping!