From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jules Tamagnan Newsgroups: gmane.emacs.bugs Subject: bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands Date: Thu, 27 Jun 2024 22:49:02 -0700 Message-ID: <87r0chty5t.fsf@gmail.com> References: <87a5jd8hqh.fsf@gmail.com> <877ceg9546.fsf@gmail.com> <874j9k8wpo.fsf@gmail.com> <87r0cn5n2s.fsf@gmail.com> <87bk3q5ki8.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15444"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71716@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 28 07:51:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sN4W5-0003lt-F3 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Jun 2024 07:51:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sN4Vl-0007I0-Fh; Fri, 28 Jun 2024 01:51:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sN4Vj-0007He-QP for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2024 01:51:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sN4Vj-0006x0-IJ for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2024 01:51:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sN4Vh-0000P7-Rc for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2024 01:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jules Tamagnan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jun 2024 05:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71716 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71716-submit@debbugs.gnu.org id=B71716.17195538111484 (code B ref 71716); Fri, 28 Jun 2024 05:51:01 +0000 Original-Received: (at 71716) by debbugs.gnu.org; 28 Jun 2024 05:50:11 +0000 Original-Received: from localhost ([127.0.0.1]:51349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sN4Ut-0000Ns-8e for submit@debbugs.gnu.org; Fri, 28 Jun 2024 01:50:11 -0400 Original-Received: from mail-pj1-f52.google.com ([209.85.216.52]:61901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sN4Uq-0000Nb-Ux for 71716@debbugs.gnu.org; Fri, 28 Jun 2024 01:50:09 -0400 Original-Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2c889d6995aso167010a91.3 for <71716@debbugs.gnu.org>; Thu, 27 Jun 2024 22:50:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719553744; x=1720158544; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=eZCUQrFHkK8qcdomb9fM9hQk/XNYKthLN0HRRxg+kzc=; b=nRTg24lKBhovbbJDNSTZBKDi813RDKaYTnpBqPSbqoGmBIfbbKjQVLr/swpyPWDK2/ pGsWAch+pMFOWQEJ5W33gyzcjhPFJyt5MOgaZ6DO/C4RDC4uV2oyqrF0zjtWwpauY6zW G3opTnyAUmeDy5LjuXTWHAwv6icxXZ7nQM8zxKZo7CuZUposuD4/XZwLN8S3ptJT7/sF QN6d3XJmi9DHKF1HBU7aKK4WAV2y4MxA2/xNCjyuY7RsAYkmlNexf6TA9KoaLcyZnrkX HgnWidhaLe/c/pcWOaAVk/eAdtUoOoPikOe4tXj3nj/jyPmDRpIDyNrJwyM9nbypbH+0 VZ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719553744; x=1720158544; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eZCUQrFHkK8qcdomb9fM9hQk/XNYKthLN0HRRxg+kzc=; b=F+543jnLWV9EFqk2QDqx+vyEYY26aS8pkuLZzuO45daEV/n5HRufOJsSot4HRlNS0i v26m/H6mg0np42QAPibV+PJRLQMh5hXDjd7+Lx7Kb4dDzzPrSFWfGc95s8BQp5UsqQUr hYeiiImQLr20AF92qqW+yYOA1f3+mvTEOIl7C2DFjBgDhJsrSiBK+yzMXhWg2gTzICjc xuI3c0uervS5DcIqQSWJZRJCf/0b7kgBwugf8LOqLWJ/QN1gYK6OlBV5XszYhKCEWmlx thFQrHxBKtNFT3tB/BAWSZ3olpp8JFU0i+7VYVslZHlSgiP3ovkd8lNf1DZMD92uu3/C D+jw== X-Gm-Message-State: AOJu0Yz55zUBqXwIj66Hd5jv125RIPDxQJgINjjFEo0naid1umsKzl2G Th8h8YeH88aurb9BP1OnD+TMTqXJKmbl0bumqcQpBOpShNgei0O8P7K8bA== X-Google-Smtp-Source: AGHT+IFpZKNnC9IxNJvZkRUaSjlvc3V3puJizdJ+cQRV+t1K1kC0t/Hx9myos5jyLafKn9aWOB0PZw== X-Received: by 2002:a17:90a:7c06:b0:2c2:fe3d:3453 with SMTP id 98e67ed59e1d1-2c86124c9f7mr12785211a91.18.1719553743999; Thu, 27 Jun 2024 22:49:03 -0700 (PDT) Original-Received: from jat-framework (c-73-189-85-43.hsd1.ca.comcast.net. [73.189.85.43]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c91ce17b9fsm763459a91.9.2024.06.27.22.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 22:49:03 -0700 (PDT) In-Reply-To: (Eshel Yaron's message of "Wed, 26 Jun 2024 13:41:32 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288038 Archived-At: Eshel Yaron writes: > Thank you, pushed to master as commit b3017e7c252, after some tweaks to > the commit message. I've also pushed a follow up commit (9cb2a204088) > with some minor refinements, see the commit message for details. One > notable change is that completion-preview-partial-insert does not force > point to the position of the preview overlay ("end") before calling the > motion function. This makes completion-preview-insert-word behave more > like forward-word when point is in the middle of a multi-word symbol, > with the completion preview at the end of that symbol. I've added > another test case that demonstrates this behavior. > > Could you please give it a try to make sure that everything still works > as you expect? > > Thanks, > > Eshel I've taken this change around the block since yesterday and everything seems to be working exactly as I would expect it to. I've also reviewed the cleanup that you did and tried to take some notes, especially on the commit message. Thanks again for all of the work that you put into creating this packaging in the first place, helping me through my change, and cleaning up the rough edges in the aftermath. Best, Jules