From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input Date: Thu, 04 Jul 2024 20:29:05 +0200 Message-ID: <87r0c957v2.fsf@gmx.net> References: <86ikxltzhx.fsf@mail.linkov.net> <861q49a8vt.fsf@gnu.org> <86y16h8olf.fsf@gnu.org> <878qyh79ov.fsf@gmx.net> <86zfqxqi6e.fsf@mail.linkov.net> <87v81l5aal.fsf@gmx.net> <864j9581zr.fsf@gnu.org> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20299"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: jpw@gnu.org, juri@linkov.net, me@eshelyaron.com, basil@contovou.net, 71927@debbugs.gnu.org, kickingvegas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 04 20:30:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPRDh-00055h-OY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jul 2024 20:30:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPRDV-0004YW-Lj; Thu, 04 Jul 2024 14:30:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPRDU-0004Xy-EN for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 14:30:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPRDU-0002kK-5E for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 14:30:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPRDW-0001Ub-FO for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 14:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jul 2024 18:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71927 X-GNU-PR-Package: emacs Original-Received: via spool by 71927-submit@debbugs.gnu.org id=B71927.17201177635650 (code B ref 71927); Thu, 04 Jul 2024 18:30:02 +0000 Original-Received: (at 71927) by debbugs.gnu.org; 4 Jul 2024 18:29:23 +0000 Original-Received: from localhost ([127.0.0.1]:42946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPRCt-0001T4-7U for submit@debbugs.gnu.org; Thu, 04 Jul 2024 14:29:23 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:40815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPRCq-0001Sj-LH for 71927@debbugs.gnu.org; Thu, 04 Jul 2024 14:29:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1720117746; x=1720722546; i=stephen.berman@gmx.net; bh=1LiPbbY6iOiY2xJPyJ3h34jX170VhDNd1xQfp3BdCzI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=R3AAsUcbGppnzOS0w8bW5pVgk4rczD/pzMzkGQi2d0Yy0pDrMz6Bye6IwU5ikx2W NjNxGdw3mMGtdcAsebmLGLulnVPv5F8g4C+UF0D77eIM+0Jk2B+Tks7lBm9WIARG1 icOhZZj0rI6IR7cSujK1ivmWMa9EY5C4uqx0zZjC19/X9SOqhoPg8ogn80alX5zEJ d/EtVGCNYTYNMTKVTwm/Ro3wJXgQUYx+eXJIfXXxg97pzC98F76jzgRXgPQDu/yCx +azjtXQGfvhhp3wWUWz3O1ge480cP1TkBPrTH7klf9sEM1APVm7DnHFF9tyma8Jzb a0AMQOhbX57GDtgUTQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs ([88.130.48.103]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MDhlf-1sWpiX01fr-00CGPN; Thu, 04 Jul 2024 20:29:06 +0200 In-Reply-To: <864j9581zr.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 04 Jul 2024 21:07:36 +0300") X-Provags-ID: V03:K1:SGEr520w8BIz1amWoGit0IQEdestw7ahb401Ym0NBNC5grwYxPo Et6N1oZTskvlBIrKASm8F69dBA9vM9AIK1Mo8beweKez714/w3tL/PsTnvR6Ff9DpnlsRpD h+mgG5pbgZ5yZHf6vnzVWcIsuRPnwICM4nKehwg8qoa0Q9OL44xz25qIFuAx4WwNULjMZ61 6pE1oR5y7BMA3CcLkjsmw== UI-OutboundReport: notjunk:1;M01:P0:AXruoKy836E=;GYCO0S0PdzT0UYrT5Uh5k2nH03N ft8DTpJyA/QHQhgaYxoaMhsCMMXIp5ozBjLMxFuEtAhwLlBqx4KN1/7cbVqZTWdI1IyG2Yf0I g7WW6J8U1i4EL9BjnSS9pHJgY0+xj3DLLlfcFu03jIoHjDGbi2ZzrRuqSJaWDVYUofRykUkX7 4zqW1NpBySOLjlBKdFfaFy5HAQ4jLzy9QDVUEAYweXhby42CMpIKP/b0wa6h0RI3Nb+mr5mg2 9yinb/BOghxeGmMHKwv6DzuXSW+eeC05YMtATg2BQ6LlF3K2+nt34AqEJYF2pFXc3ntYbt9Qq CQ5JYhACSAfO4f5SdUrnUxu28iXNS7OOdE/z9dMS7QxqTSH2yEdH167jXpux0pkVZYjgjo0i6 e98MhvUYARQHr2iMAITIAKtHhw7lb1SxQ8S0+RznytG5Mo5eT6XcV2sRjhLdmM0zCVN0vuqos F1+7gGBwtuFzT+Y52dJrdWBdcLU7G4tqDR4adtQZbA8sJuoGFZg5EhoomyL1GKGvpcD/jWVzm IcCEVL5Iv2/h2MA8VDTlTSgbQHxcMSgbIuGUyR4Uh5XicmJccZBPKpe5VcyuUxIHTt+fN+kM7 sRDCcTSwFxfqsTtRwGBNcSgQ9vDBtu8wmEZrOV2PJk+FWqELgVFh1gXQE9iHfsBnPQmrXZ/RO tm0tU0FDASc2osAJuSCucdvSC4HGgJ7RVWqY020EXaWYANxqT9AAF+Vf3WcxrfIKvbqfh+uS0 B+JZhjMeHPktjnfm2BG6zkH2fZuoP5Kf56Y3cq0nkLx7ZgImsQh634KVoyD/UZKNDiBJDCXc X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288390 Archived-At: On Thu, 04 Jul 2024 21:07:36 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: Eli Zaretskii , Eshel Yaron , >> kickingvegas@gmail.com, 71927@debbugs.gnu.org, basil@contovou.net, >> jpw@gnu.org >> Date: Thu, 04 Jul 2024 19:36:34 +0200 >> >> On Thu, 04 Jul 2024 19:04:42 +0300 Juri Linkov wrote: >> >> >>>> FWIW, AFAICT everything is working correctly, it's just that the >> >>>> "Operation finished" message hides the prompt. ibuffer-do-isearch >> >>>> should tell define-ibuffer-op not to display that message, somehow= . >> >>> >> >>> I don't see how this could be considered "correct": the "Operation >> >>> finished" message is supposed to be shown only after the Isearch is >> >>> finished in all the marked buffer, not before. It looks like we ne= ed >> >>> a function that will not return until all the buffers where searche= d, >> >>> because that's what define-ibuffer-op expects. Don't you agree? >> > >> > It intentionally uses 'no-recursive-edit' set to t, so ibuffer-do-ise= arch >> > correctly exits immediately while leaving isearch-mode enabled. >> > >> >> The attached patch appears to DTRT, but I only tested it briefly. >> >> ... >> >> (define-ibuffer-op ibuffer-do-isearch () >> >> "Perform a `isearch-forward' in marked buffers." >> >> (:interactive () >> >> - :opstring "searched in" >> >> + :no-opstring t >> > >> > Thanks for the patch. I confirm this is the right thing to do. >> > Maybe instead of :no-opstring would be better to use some special val= ue >> > like :opstring 'no? But I'm not sure if this is better than :no-opst= ring. >> >> Suppressing the message when :opstring has the value 'no is fine with >> me. If Eli is willing to accept this approach, I can go ahead and >> commit it (to master, presumably, since this is a longstanding issue). > > I already said this didn't sound the right solution here, and I > explained why. I'd be interested in hearing counter-arguments, if > there are any. I gave a mild counterargument upthread, that making ibuffer-do-isearch{-regexp} defuns independent of define-ibuffer-op seems like accepting the inadequacy of the latter instead of trying to improve it. Also, I am not familiar enough with the ibuffer code to be confident that I could implement I could implement the functionality without using this macro, but someone else might be in a better position to do that. Steve Berman