From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#72358: 29.4; oauth2.el improvements Date: Tue, 30 Jul 2024 16:39:26 +0200 Message-ID: <87r0bbvt9d.fsf@gmail.com> References: <87mslz8yzk.fsf@debian-hx90.lan> <9717.00003590144$1722349291@news.gmane.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26542"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?UTF-8?Q?Bj=C3=B6rn?= Bidar , 72358@debbugs.gnu.org To: Xiyue Deng Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 30 16:41:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sYo2L-0006bs-BA for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Jul 2024 16:41:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sYo1x-0005UT-VW; Tue, 30 Jul 2024 10:40:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sYo1x-0005Tq-3Y for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2024 10:40:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sYo1w-0006yK-QR for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2024 10:40:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=DbG7KztFvgNNtLhPXMQ1mbmX0urvP31b698Ra71KnPY=; b=WhtuWgDA9CjjmdvNCZo4yGkS35JYDwmlOq67nL+hbH3iPqJ1Xww5uIF0BLvpH7wZsh2yEzmHM3sBFw9EzZnFZlmTK/7RGp2nQszgqbjklStdP/wtXNeWQgWowF8bpUGQdzKpi/Z2WgmY29EYkOFsf+1WfSXDUqx6IHj1BsT8a39BkYbSEB4UKCAKVmLBeBIpc1pd8EXSzpwF+skZiR42KLly3f3fUl/1o0oLP/rMXb3s76S74j/SzDXbwk56tsQFTB6s3AvfWJ5RByMKu6Fzij8VEKXWyQaUAIWgRo22/L29gXXPQbadTGfgKneGlQFssZjoCWv3mr+tty5hLIC1MQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sYo2A-000775-Kg for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2024 10:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jul 2024 14:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72358 X-GNU-PR-Package: emacs Original-Received: via spool by 72358-submit@debbugs.gnu.org id=B72358.172235045327312 (code B ref 72358); Tue, 30 Jul 2024 14:41:02 +0000 Original-Received: (at 72358) by debbugs.gnu.org; 30 Jul 2024 14:40:53 +0000 Original-Received: from localhost ([127.0.0.1]:48101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sYo20-00076S-MP for submit@debbugs.gnu.org; Tue, 30 Jul 2024 10:40:52 -0400 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:55589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sYo1w-00076A-Sw for 72358@debbugs.gnu.org; Tue, 30 Jul 2024 10:40:50 -0400 Original-Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-42817bee9e8so24764545e9.3 for <72358@debbugs.gnu.org>; Tue, 30 Jul 2024 07:40:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722350368; x=1722955168; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=DbG7KztFvgNNtLhPXMQ1mbmX0urvP31b698Ra71KnPY=; b=KI6/OhWH1H7DJCgpVIRgtdelvzhmEwik6n9AHsXFS+7MmfqfeCbr6LiYhtlyLQ/NJM r95Av64KQz1QUwQciUZdVuzg3Y4Mox6Fm3+c9pOD2T0nNxJKfbviNI1GoQRJmKuQDX7T CxkWevuIFPY8TdWHm6PorrAaFgqscvDpv9RcCWY56GoEc8IIkBecn4KZjpoBxYrvoy8u 17vUyIWrLAivxu80eSmLc1UTjFDGDT0LM18RCdr2V2Hca7pm4NDyKzJDG+k3uOGKW/2+ sqSIa5zvQe+JkMt7s+RiSFTaEMDJ+07fUMm5pEibglGg71z94XVFhScL6xdUnvf68T/6 RLCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722350368; x=1722955168; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DbG7KztFvgNNtLhPXMQ1mbmX0urvP31b698Ra71KnPY=; b=sUy5TCZm+PmpQvR3e1GMcyQQhN74l4lANekNBkgOSl6+15km0ae7A1XRAP/TIBw7OH e3X748Tp7fBtHIdkYxced8N6ATavw7Dne+ZrcPhZnACqzJ6ACctDQPPyH/4phYb2S36p k8byoLC2RUTtQWO6JEyHlakJHY4fG2LKNM6+c6aqiC6EpC2Sj94Qk1bVa6g2LQCkCZuh IXCdSTmIMv94CnV6M5wrKOGrzGta5Cta9Dg8jIjhXvTjNrfwIYWZC8nc/QoUvd8yIY9f nQzZuMq9L6Uj9M3/ajI8yMrjbcO0RTVRhvxciRotJW6XR/l8FwStU6Eu9556JqwjHbhl Qa+A== X-Forwarded-Encrypted: i=1; AJvYcCVFP+6fZ1ZLKVaslwEYg33XRMxm6Kvx9RaeLf6Zt14hMqZtO4bwzVzytPepcmqTFQ4pGQRFfyZKs/JDRgTJodsn1xbf9Nk= X-Gm-Message-State: AOJu0YzXjRLaY0DEQ96ARCj0tR74MppKubsinP8NpRpZAbkZSmnPOltD rvu+z2EyMsRBho9Bv6uXssIk1zrgybLGujbmzKBJjde6+UILXURVkeLOXg== X-Google-Smtp-Source: AGHT+IHmQQ/mXnPlLdrcdy7nDMAWuYGJ812Cgmd/NOckDCt2WZGa8Boc19WJqefqjGc49ukCQB9fTg== X-Received: by 2002:a05:600c:358e:b0:428:10ec:e5ca with SMTP id 5b1f17b1804b1-42811d88a0fmr84758845e9.14.1722350367811; Tue, 30 Jul 2024 07:39:27 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb51:c026:d246:cbf5:2104]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4280573fec6sm215337655e9.18.2024.07.30.07.39.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jul 2024 07:39:27 -0700 (PDT) In-Reply-To: <9717.00003590144$1722349291@news.gmane.org> ("=?UTF-8?Q?Bj=C3=B6rn?= Bidar via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\""'s message of "Tue, 30 Jul 2024 17:08:21 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289552 Archived-At: >>>>> On Tue, 30 Jul 2024 17:08:21 +0300, Bj=C3=B6rn Bidar via "Bug reports= for GNU Emacs, the Swiss army knife of text editors" said: Bj=C3=B6rn> Xiyue Deng writes: >> The fourth patch may need a bit of background: oauth2.el (optionally) >> uses plstore to save authentication data for future reuse, and the >> plstore id for an account is computed using a combination of `auth-u= rl', >> `token-url', and `scope'. However, this combination of data doesn't >> guarantee uniqueness for accounts for a same provider, e.g. for Gmai= l, >> the three parameters are the same for different accounts, and hence >> storing a second account information will override the first one. Bj=C3=B6rn> Would it make sense to plug OAuth2.el into auth-source to s= tore the Bj=C3=B6rn> authentication token safely inside an existing credential s= torage? Bj=C3=B6rn> Various applications already do so when using the native cr= edential Bj=C3=B6rn> storages such as Freedesktop.org or the macOS keyring. Yes. In fact there=CA=BCs the auth-source-xoauth2 package that does that. And oauth2 can already store stuff using plstore, so I=CA=BCm sure it can be extended to use auth-source. Robert --=20