From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tony Zorman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73016: Potential inclusion of kbd-mode, part of kmonad, in Non-GNU ELPA Date: Fri, 06 Sep 2024 12:53:53 +0200 Message-ID: <87r09x59z2.fsf@hyperspace> References: <875xrcfkiy.fsf@jeremybryant.net> <87wmjqjuiz.fsf@posteo.net> Reply-To: Tony Zorman Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3429"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73016@debbugs.gnu.org To: Philip Kaludercic , Jeremy Bryant Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 06 13:50:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smXTr-0000iX-Ld for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Sep 2024 13:50:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smXTk-00024q-Ag; Fri, 06 Sep 2024 07:50:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smXTb-0001Wz-I3 for bug-gnu-emacs@gnu.org; Fri, 06 Sep 2024 07:50:10 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smXTX-0006fb-Qb for bug-gnu-emacs@gnu.org; Fri, 06 Sep 2024 07:50:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=OU1hmn9kxBQL7ANh3+ZoVkBCyvLJ7VQFg+nxmdyr9A8=; b=nbdTJvGSHKW1zhYYzBblFj/BNQjiho7ktxYL6tYTFytsm2LExOk9NM/KkfuiRntDKMOkRfsfT47VaZsnLo6PpL03qcCTqA0vl0eOL4EEFNqP2vOJTfoILAeOEUBAjiqNdTOvyWoAVCvhrn1u5SP5OOMmtVr0pZwaGlqExk5pyyW+Jz6kkat/rwipopW271V33BtjfxQrS3YgFgovXFn01OA+7D64IvQIiNB5LuGkULevdj5inkvqWOKc9pwon8NoPfVXkINoDxze5m7xunbGNpOlZt+hVmEVRa1VuczvAZ7/tm94MRGV9ob4a3v5k40fwiWGxHvoh0cSRqA09jAWxA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smXTW-0001a1-6D for bug-gnu-emacs@gnu.org; Fri, 06 Sep 2024 07:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tony Zorman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Sep 2024 11:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73016 X-GNU-PR-Package: emacs Original-Received: via spool by 73016-submit@debbugs.gnu.org id=B73016.17256233876041 (code B ref 73016); Fri, 06 Sep 2024 11:50:02 +0000 Original-Received: (at 73016) by debbugs.gnu.org; 6 Sep 2024 11:49:47 +0000 Original-Received: from localhost ([127.0.0.1]:52354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smXTG-0001ZM-BU for submit@debbugs.gnu.org; Fri, 06 Sep 2024 07:49:46 -0400 Original-Received: from mout-p-102.mailbox.org ([80.241.56.152]:50350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smXTD-0001Ym-Ck for 73016@debbugs.gnu.org; Fri, 06 Sep 2024 07:49:44 -0400 Original-Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4X0Y4j3sX2z9skX; Fri, 6 Sep 2024 12:53:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1725620037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OU1hmn9kxBQL7ANh3+ZoVkBCyvLJ7VQFg+nxmdyr9A8=; b=G2/trzvtd8iny1oO/X5C6bsrDCgGUTbgzS0PSAEhf1ralBhpuXwr2v0qybZIEmks5a+zSB uPc1gtBWbBOdMgFOMUSyVgFJWpHaZnNtmhT/M3BB6WWgVYGw73pTiYGVUQutKfsPvs5PGW AfnGx4ADkftGIA3oWKLVvveW4ZSuJWsIKokiLUxgjnoJiJy0Vj6WdJbPapI/IF8bAkUfsq AnYB3jPxFF/lOf+ih5EeOJmIUuHnlFWSeq1Hts7EdlbqloCR+ZL9lfZJtfOv8raURMv5ey lZd6kgXar45jIEQrf1x0J78/qNaivUuO3e7bbfE072SVPq8b9RM97zQjEcWO8Q== In-Reply-To: <87wmjqjuiz.fsf@posteo.net> X-MBO-RS-META: 6fexioocjq96nnbkizxqx66fxwnzo3ug X-MBO-RS-ID: a623028260f8a805128 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291308 Archived-At: Hi, thanks to Jeremy for submitting this, and to Philip for reviewing! I'm travelling right now, so I'll keep this short; more to come in a few days I hope. =20 On Thu, Sep 05 2024 09:53, Philip Kaludercic wrote: > [=E2=80=A6 12 lines elided =E2=80=A6] > >> On behalf of the author, Tony Zorman, I would like to request >> consideration to include it in NON-GNU ELPA. > > Just for the sake of the protocol, is there a reason against adding the > package to GNU ELPA? There has been at least one non-trivial contribution to the package, as well as several smaller ones. While I have assigned copyright to the FSF for Emacs and ELPA related things, I don't know whether the same can be said of the other contributors. >> The author is conscious that the following snippet should be improved >> and we are soliciting recommendations on how to improve it. >> ;; HACK >> (defadvice redisplay (after refresh-font-locking activate) >> (when (derived-mode-p 'kbd-mode) >> (font-lock-fontify-buffer)))) > > I agree, we should get rid of that. But first, what is the intention? > What breaks if we just remove this advice? When specifying the keyboard layout, the configuration language accepts most special symbols verbatim (as in, one can just write @ to have that symbol bound to a key). This includes " for double quotes, meaning the highlighting of strings has to be taken care of be the mode=E2=80=94at leas= t, I think so. This produces inconsistent behaviour that I was never really a fan of, especially when moving things around. For example, going from=20 (f "string") to=20 (f "string") would "unhighlight" the string until one refreshes the syntax highlighting for the buffer via e.g. font-lock-update, or wait until this happens by itself. The advice is nothing more but a band-aid such that the latter happens more often. It may well be that I overlooked something about Emacs's way of going about string highlighting back when I wrote the mode, and so far I haven't had the drive to look back into this. Tony --=20 Tony Zorman | https://tony-zorman.com