From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74289: 30.0.92; `require-with-check' fails on non-existing files Date: Mon, 11 Nov 2024 05:52:16 +0100 Message-ID: <87r07icqyn.fsf@daniel-mendler.de> References: <87ldxrbhse.fsf@daniel-mendler.de> <87iksvasni.fsf@daniel-mendler.de> Reply-To: Daniel Mendler Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9727"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 74289-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 11 05:55:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tAMSP-0002OO-T4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Nov 2024 05:55:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tAMS9-0002UM-7d; Sun, 10 Nov 2024 23:55:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAMS6-0002Tw-H1 for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2024 23:55:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tAMS6-0006EV-7w for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2024 23:55:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=ExmHsfRhBLHy2P/vyZfDfH9Wq21g0FicGvpbY3neg+Q=; b=XXl/FNk3KOhe3lgI8/3cSg5kpiqwftMVbUAiJQqjdyMaZoeOB9dgRPbhm/O4qlB5u7hVzq+NWqkjb50fu8gJu9NVNz8VRoei9TF+fRM5oPK93nGZwrZNMyxw1uZ1YtqGtelIKr1SV5T09jv2gJEEicoIF/o22LnAQCi5lA/4iyEJPW/RFEPpLmdiqnBf+CQG3pwM6JCTjTaDvo5tavVkEplhEeyvExjC94O9CuBkXp3deBW0UL79PnszcYcm3bSW8CunK7eY4DPf3y8bJFp4KF5gtlqstsdTYpFtngK3MRIEi+RG3FA8+qNDpeI67S0n5Ywyn5rDtcSzKwQdejz8EQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tAMS6-0001FK-3t for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2024 23:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Nov 2024 04:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74289 X-GNU-PR-Package: emacs Original-Received: via spool by 74289-done@debbugs.gnu.org id=D74289.17313008784748 (code D ref 74289); Mon, 11 Nov 2024 04:55:02 +0000 Original-Received: (at 74289-done) by debbugs.gnu.org; 11 Nov 2024 04:54:38 +0000 Original-Received: from localhost ([127.0.0.1]:57433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAMRi-0001EW-0h for submit@debbugs.gnu.org; Sun, 10 Nov 2024 23:54:38 -0500 Original-Received: from server.qxqx.de ([49.12.34.165]:37191 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAMRf-0001EG-TJ for 74289-done@debbugs.gnu.org; Sun, 10 Nov 2024 23:54:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ExmHsfRhBLHy2P/vyZfDfH9Wq21g0FicGvpbY3neg+Q=; b=f9jQ0N+P16H6B/OOGZ9YgGu6zr V9xCzssHFXl1aE0htH+U2aoJ+I/h5OwU64IyDPclhiA9TPkoBzKd9oRZepQuL5bR37tAuKq+1E3vP ILQsvCjUsa1G78oLLji7BpCT0oXgN/SrKv+ZYap/0LeIQL6iQezlvZac8JVsjdkqtuvA=; In-Reply-To: (Stefan Monnier's message of "Sun, 10 Nov 2024 16:51:14 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295214 Archived-At: Stefan Monnier writes: >>>> `require-with-check' fails since >>>> 0aae02a3741c397d6952e3128d434827aca0f912 on non-existing files. >>>> >>>> See the CI run of the Compat test suite: >>>> >>>> https://github.com/emacs-compat/compat/actions/runs/11763132765/job/32766767667 >>>> >>>> This call fails: >>>> >>>> (require-with-check 'compat-does-not-exist nil 'noerror) >>> >>> Oops, can you confirm that the patch below works for you? >> >> It does look correct :) Thanks. > > Than you, Daniel, pushed to `emacs-30`. > Closing, Hi Stefan, I think there is one more bug a little bit later. prefix can be nil here: (while (and lh (let ((file (car-safe (car lh)))) (not (and file (string-prefix-p prefix file))))) ...) In order to check, simply eval this code: (require-with-check 'compat-does-not-exist nil 'noerror) Daniel