From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74617: 30.0.92; ffap-menu always displays the *Completions* buffer Date: Sat, 30 Nov 2024 08:02:20 +0100 Message-ID: <87r06turur.fsf@daniel-mendler.de> Reply-To: Daniel Mendler Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40005"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier To: 74617@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 30 08:03:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tHHVb-000ACj-Ji for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Nov 2024 08:03:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tHHVQ-000240-Uk; Sat, 30 Nov 2024 02:03:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHHVO-00023r-SL for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 02:03:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tHHVO-0008Dt-Jm for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 02:03:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=GqtCkYtXt/iZoWXRKNAdegMM4X5Ihpq9/YKj8pw1+Zg=; b=f0S79Tl7WxQ260kNIhwwFfWs9uiVflzb96qouHi2EAadtEOduLxFCMaf6BBZyuA4ZoKtPs/EkdO4EbFAbo+apUgvYSkVtgPaH4g384+Lr8291ikurlh4CJC4wNa8mVira6I4pAtwCWl9hmnl423uYD0VS3qhWu42CAeucWHUHzOd2dk3Phj9vgvsg0aLXvE+VDfEhFnLKwOMLS0rhy/vmlaCtnCGN1UwifccqQ/U4x7baEH1b0zhrJKmkAQ5Wb0X6SLlN4XkpP1fuSuQ/MFRs8rOM6tl2ZDi5UA7ylom0AVN9cfd/1FvGs8KRqwPEhalcAaeblm052J3RQrb+KwYnQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tHHVN-0006GV-SS; Sat, 30 Nov 2024 02:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Nov 2024 07:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74617 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Stefan Monnier Original-Received: via spool by submit@debbugs.gnu.org id=B.173295015424030 (code B ref -1); Sat, 30 Nov 2024 07:03:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Nov 2024 07:02:34 +0000 Original-Received: from localhost ([127.0.0.1]:45207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHHUw-0006FV-87 for submit@debbugs.gnu.org; Sat, 30 Nov 2024 02:02:34 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:54804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHHUu-0006FJ-2f for submit@debbugs.gnu.org; Sat, 30 Nov 2024 02:02:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHHUr-00022b-4Q for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 02:02:31 -0500 Original-Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHHUo-0007zY-KY for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 02:02:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GqtCkYtXt/iZoWXRKNAdegMM4X5Ihpq9/YKj8pw1+Zg=; b=M9Y6ZuGJ3b63YHvzSWFjExpdlQ Arn2klWuHbfkurY7nOwWy/XjN7jtecPe1W9ztC3xW8MS9NBv57DGxC553WG9LraeJpT/5H6epDoSx khgO7jSzsbuOwQUjalA36TdfmSga/VrsR1ZIRlg1fTfipHcvwXZahKSbUGEno0woM3VM=; Received-SPF: pass client-ip=2a01:4f8:c012:9177::1; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296112 Archived-At: `ffap-menu' automatically displays the *Completions* buffer by calling `minibuffer-completion-help'. If an alternative minibuffer completion system like Icomplete or Vertico is used, the *Completions* buffer is not needed since the candidates are already displayed in the minibuffer. I propose to either detect these alternative completion systems (e.g., by checking the value of the completing-read-function and/or the mode variables) or to provide a way to disable the call to `minibuffer-completion-help'. Since the same problem is present in tmm.el, maybe a generic solution could be provided by minibuffer.el? Option 1: A function `minibuffer-completion-help-if-needed' could call `minibuffer-completion-help' only if no other completion system is detected. Option 2: A new function `completing-read-display-help-function' could be added which defaults to `minibuffer-completion-help' and which could be set to nil/ignore by alternative completion UIs like Vertico. This function could be used by tmm/ffap. Option 3: A new variable `minibuffer-inhibit-completion-help' could be added which is checked by `minibuffer-completion-help' and which could be set to t by alternative completion UIs. I am happy to provide a patch for any of these approaches.