unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Anush V <j@gnu.org>
Cc: 74759@debbugs.gnu.org
Subject: bug#74759: 30.0.92; Gnus configuration warning
Date: Tue, 10 Dec 2024 15:01:16 +0100	[thread overview]
Message-ID: <87r06f8wnn.fsf@gmail.com> (raw)
In-Reply-To: <871pyfagx2.fsf@gmail.com> (Robert Pluim's message of "Tue, 10 Dec 2024 12:58:17 +0100")

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

>>>>> On Tue, 10 Dec 2024 12:58:17 +0100, Robert Pluim <rpluim@gmail.com> said:
    Robert> Itʼs an oversight in the definition of the custom type of
    Robert> `gnus-select-method'. Iʼll see if I can come up with a fix.

This works for me. Maintainers, master or emacs-30? (Iʼd lean towards
the latter)

Robert
-- 


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-gnus-select-method-custom-type.patch --]
[-- Type: text/x-diff, Size: 1141 bytes --]

From d14a9c0d71e0e2240c97e449f4875577e7b44f73 Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim@gmail.com>
Date: Tue, 10 Dec 2024 14:56:21 +0100
Subject: [PATCH] Fix 'gnus-select-method' custom type
To: emacs-devel@gnu.org

* lisp/gnus/gnus.el (gnus-redefine-select-method-widget): Cater
for the 'gnus-search-engine' configuration variable, which takes
2 args instead of 1.   (Bug#74759)
---
 lisp/gnus/gnus.el | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/lisp/gnus/gnus.el b/lisp/gnus/gnus.el
index 62a090bd9df..0d0e678309f 100644
--- a/lisp/gnus/gnus.el
+++ b/lisp/gnus/gnus.el
@@ -1402,9 +1402,14 @@ gnus-redefine-select-method-widget
 	    (string :tag "Address")
 	    (repeat :tag "Options"
 		    :inline t
-		    (list :format "%v"
-			  variable
-			  (sexp :tag "Value"))))))
+                    (radio
+		     (list :tag "Single var" :format "%v"
+			   variable
+			   (sexp :tag "Value"))
+                     (list :tag "Multiple var" :format "%v"
+			   variable
+                           variable
+			   (sexp :tag "Value")))))))
 
 (gnus-redefine-select-method-widget)
 
-- 
2.39.5


  reply	other threads:[~2024-12-10 14:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10  3:09 bug#74759: 30.0.92; Gnus configuration warning Anush V
2024-12-10 11:58 ` Robert Pluim
2024-12-10 14:01   ` Robert Pluim [this message]
2024-12-10 14:42     ` Eli Zaretskii
2024-12-10 14:54       ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r06f8wnn.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=74759@debbugs.gnu.org \
    --cc=j@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).