From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#5773: 23.1; vc-diff save buffer when re-diffing (or save whole fileset) Date: Sun, 28 Mar 2010 15:43:26 -0400 Message-ID: <87pr2o6xlt.fsf@stupidchicken.com> References: <87pr2sja5c.fsf@blah.blah> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1269806169 30649 80.91.229.12 (28 Mar 2010 19:56:09 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 28 Mar 2010 19:56:09 +0000 (UTC) Cc: 5773@debbugs.gnu.org To: Kevin Ryde Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 28 21:56:04 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NvyaX-0001Ad-79 for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Mar 2010 21:56:01 +0200 Original-Received: from localhost ([127.0.0.1]:49758 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NvyaW-0007ff-Q4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Mar 2010 15:56:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NvyaA-0007KU-R6 for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2010 15:55:38 -0400 Original-Received: from [140.186.70.92] (port=52279 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nvya6-0007GB-CH for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2010 15:55:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nvya4-0004Gw-L3 for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2010 15:55:34 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56566) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nvya4-0004Gp-GW for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2010 15:55:32 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NvyOw-0007AU-58; Sun, 28 Mar 2010 15:44:02 -0400 X-Loop: bug-gnu-emacs@gnu.org In-Reply-To: <87pr2sja5c.fsf@blah.blah> Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Mar 2010 19:44:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-GNU-PR-Message: followup 5773 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5773-submit@debbugs.gnu.org id=B5773.126980541327538 (code B ref 5773); Sun, 28 Mar 2010 19:44:02 +0000 Original-Received: (at 5773) by debbugs.gnu.org; 28 Mar 2010 19:43:33 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvyOT-0007A7-L4 for submit@debbugs.gnu.org; Sun, 28 Mar 2010 15:43:33 -0400 Original-Received: from pantheon-po33.its.yale.edu ([130.132.50.94]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvyOR-0007A0-JL for 5773@debbugs.gnu.org; Sun, 28 Mar 2010 15:43:32 -0400 Original-Received: from furry (173-14-147-246-NewEngland.hfc.comcastbusiness.net [173.14.147.246]) (authenticated bits=0) by pantheon-po33.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o2SJhQCf020949 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 28 Mar 2010 15:43:26 -0400 Original-Received: by furry (Postfix, from userid 1000) id 60EB7C05D; Sun, 28 Mar 2010 15:43:26 -0400 (EDT) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 28 Mar 2010 15:44:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:35784 Archived-At: > If you re-run M-x vc-diff from a *vc-diff* buffer, it doesn't ask you > to save the buffer being diffed the way that it does when operating > from that buffer itself > > 2010-03-25 Kevin Ryde zip.com.au> > > * vc.el (vc-buffer-sync-fileset): New function. > (vc-diff): Use it to save all relevant file buffers no matter > where run (not just the current buffer). Thanks, but I think your patch may need to go further. There are several other places in VC where vc-buffer-sync is called; could you check whether they need to use your `vc-buffer-sync-fileset' (which ought to be in vc-dispatcher.el)?