From: Chong Yidong <cyd@stupidchicken.com>
To: David De La Harpe Golden <david@harpegolden.net>
Cc: 6956@debbugs.gnu.org, Dj@debbugs.gnu.org
Subject: bug#6956: 24.0.50; pasting mouse selection in other session pastes only first word
Date: Sat, 04 Sep 2010 21:53:46 -0400 [thread overview]
Message-ID: <87pqwtuf9x.fsf@stupidchicken.com> (raw)
In-Reply-To: <4C82BC4E.4080500@harpegolden.net> (David De La Harpe Golden's message of "Sat, 04 Sep 2010 22:38:22 +0100")
Thanks, the patch looks generally OK, except for the following:
> (defcustom mouse-drag-copy-region nil
> - "If non-nil, mouse drag copies region to kill-ring."
> + "If non-nil, copy to kill-ring upon mouse adjustments of the region.
> +
> +For consistency this affects both actual mouse drag operations and
> +`mouse-save-then-kill' (\\[mouse-save-then-kill]) operations that
> +change the region."
It is sufficient to say "This affects `mouse-save-then-kill'
(\\[mouse-save-then-kill]) in addition to mouse drags."
> If the region is inactive, activate it temporarily. Set mark at
> the original point, and move point to the position of CLICK.
> +If `mouse-drag-copy-region' is non-nil, also save the region
> +to the kill ring.
>
> If the region is already active, adjust it. Normally, do this by
> moving point or mark, whichever is closer, to CLICK. But if you
> have selected whole words or lines, move point or mark to the
> word or line boundary closest to CLICK instead.
> +If `mouse-drag-copy-region' is non-nil, also save the region
> +to the kill ring, replacing the previous kill corresponding
> +to the already active region.
We don't need to explain what mouse-drag-copy-region does twice.
Just add a separate paragraph saying
If `mouse-drag-copy-region' is non-nil, this command also saves the
region to the kill ring, replacing the previous kill if it was also
made with `mouse-save-then-kill'.
> If this command is called a second consecutive time with the same
> -CLICK position, kill the region."
> +CLICK position, kill the region (or delete it
> +if `mouse-drag-copy-region' is non-nil - it will already
> +have been saved to the kill ring by the previous click.)"
Omit the part after the "-", it's not necessary.
> - (kill-region (mark t) (point))
> + (if mouse-drag-copy-region
> + ;; region already saved the previous click,
> + ;; don't make a duplicate entry, just delete
> + (delete-region (mark t) (point))
> + (kill-region (mark t) (point)))
> + (setq deactivate-mark t)
What's the additional deactivate-mark for?
next prev parent reply other threads:[~2010-09-05 1:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 16:48 bug#6956: 24.0.50; pasting mouse selection in other session pastes only first word Drew Adams
2010-08-31 17:26 ` Eli Zaretskii
2010-08-31 18:13 ` Chong Yidong
2010-09-01 14:38 ` Eli Zaretskii
2010-09-04 7:18 ` Eli Zaretskii
2010-09-04 8:35 ` Jan Djärv
2010-09-04 11:07 ` Eli Zaretskii
2010-09-04 15:06 ` Drew Adams
2010-09-04 15:44 ` Eli Zaretskii
2010-09-04 15:15 ` Jan Djärv
2010-09-04 19:09 ` Chong Yidong
2010-09-04 20:35 ` David De La Harpe Golden
2010-09-04 21:38 ` David De La Harpe Golden
2010-09-05 1:53 ` Chong Yidong [this message]
2010-09-05 5:33 ` David De La Harpe Golden
2010-09-05 14:36 ` David De La Harpe Golden
2010-09-05 3:09 ` Eli Zaretskii
2010-09-05 4:48 ` David De La Harpe Golden
2010-09-05 5:06 ` Eli Zaretskii
2010-09-04 17:06 ` David De La Harpe Golden
2010-08-31 18:16 ` Drew Adams
2010-09-16 20:02 ` Eli Zaretskii
2010-09-16 23:51 ` Drew Adams
2010-09-17 8:01 ` Eli Zaretskii
[not found] ` <3BE2421F73AD4292AE8375CA3328663D@us.oracle.com>
2010-09-17 16:14 ` Eli Zaretskii
2010-09-17 16:20 ` Drew Adams
2010-09-17 17:03 ` Eli Zaretskii
2010-09-20 18:47 ` Drew Adams
2010-09-20 19:18 ` Eli Zaretskii
2010-09-20 20:19 ` Drew Adams
2010-09-20 20:43 ` Drew Adams
2010-09-20 20:52 ` Eli Zaretskii
2010-09-20 21:41 ` Drew Adams
2010-09-20 21:53 ` Eli Zaretskii
2010-09-20 22:24 ` Drew Adams
2010-09-21 4:08 ` Eli Zaretskii
2010-09-21 14:20 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqwtuf9x.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=6956@debbugs.gnu.org \
--cc=Dj@debbugs.gnu.org \
--cc=david@harpegolden.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).