From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 8340@debbugs.gnu.org, Trevor Spiteri <tspiteri@ieee.org>
Subject: bug#8340: 23.2; recompile does not retain compilation-environment needed by vc-git-grep
Date: Wed, 07 Sep 2011 15:19:33 +0300 [thread overview]
Message-ID: <87pqjdqsz2.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwvbouxa5bz.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 06 Sep 2011 14:39:58 -0400")
> Mixing defcustom+bufferlocal+letbinding is really asking for trouble,
> although I think in this case it might just fall within the limits of
> what does work.
>
> The vc-git.el patch looks perfectly good and so does the (set...thisenv).
Installed.
> But I'd prefer to refrain from making compilation-environment a defcustom
> for now, until we find a really good use for it.
There have been requests to make it a defcustom, and you even agreed to that ;-)
http://lists.gnu.org/archive/html/emacs-devel/2009-02/msg00118.html
It will allow the users to find and change it more easily in cases like this:
http://lists.gnu.org/archive/html/help-gnu-emacs/2011-02/msg00338.html
next prev parent reply other threads:[~2011-09-07 12:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 18:45 bug#8340: 23.2; recompile does not retain compilation-environment needed by vc-git-grep Trevor Spiteri
2011-09-05 9:10 ` Juri Linkov
2011-09-06 9:27 ` Juri Linkov
2011-09-06 18:39 ` Stefan Monnier
2011-09-07 12:19 ` Juri Linkov [this message]
2011-09-07 13:36 ` Stefan Monnier
2011-09-08 12:12 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqjdqsz2.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=8340@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=tspiteri@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).