unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Rob Browning <rlb@defaultvalue.org>
To: 10592@debbugs.gnu.org
Cc: 655118@bugs.debian.org, 655118-forwarded@bugs.debian.org,
	"Moritz Mühlenhoff" <jmm@inutil.org>
Subject: bug#10592: Bug#655118: Please enabled hardened build flags
Date: Mon, 23 Jan 2012 23:05:26 -0600	[thread overview]
Message-ID: <87pqe98zc9.fsf@trouble.defaultvalue.org> (raw)
In-Reply-To: <87wr8h8zhu.fsf@trouble.defaultvalue.org> (Rob Browning's message of "Mon, 23 Jan 2012 23:02:05 -0600")


(Sorry, accidentally hit send too early.)

Mortiz updated Emacs to support -Wformat -Wformat-security
-Werror=format-security.

Here are the relevant changes (further details are available at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655118):

diff -aur emacs23-23.3+1.orig/lib-src/movemail.c emacs23-23.3+1/lib-src/movemail.c
--- emacs23-23.3+1.orig/lib-src/movemail.c	2011-12-29 05:07:27.000000000 +0100
+++ emacs23-23.3+1/lib-src/movemail.c	2012-01-08 17:31:22.000000000 +0100
@@ -615,11 +615,11 @@
 {
   fprintf (stderr, "movemail: ");
   if (s3)
-    fprintf (stderr, s1, s2, s3);
+    fprintf (stderr, "%s%s%s", s1, s2, s3);
   else if (s2)
-    fprintf (stderr, s1, s2);
+    fprintf (stderr, "%s%s", s1, s2);
   else
-    fprintf (stderr, s1);
+    fprintf (stderr, "%s", s1);
   fprintf (stderr, "\n");
 }
 
Thanks
-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4





  reply	other threads:[~2012-01-24  5:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120108171359.6340.17517.reportbug@pisco.westfalen.local>
     [not found] ` <20120108180151.GA919@pisco.westfalen.local>
2012-01-24  5:02   ` bug#10591: Bug#655118: Please enabled hardened build flags Rob Browning
2012-01-24  5:05     ` Rob Browning [this message]
2012-01-24  6:06       ` bug#10592: " Eli Zaretskii
2012-01-24 16:17         ` Rob Browning
2012-01-25  2:22         ` Rob Browning
2012-01-25  6:40           ` Eli Zaretskii
2012-01-26  3:13             ` Rob Browning
2012-01-26  3:25               ` Rob Browning
2012-01-31  4:22       ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pqe98zc9.fsf@trouble.defaultvalue.org \
    --to=rlb@defaultvalue.org \
    --cc=10592@debbugs.gnu.org \
    --cc=655118-forwarded@bugs.debian.org \
    --cc=655118@bugs.debian.org \
    --cc=jmm@inutil.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).