bug#9967: 24.0.90; semantic/srecode : Missing require

bug#9967: 24.0.90; semantic/srecode : Missing require

[Andreas Politz]

$ emacs -Q

(require 'srecode)
M-x srecode-insert RET "file:empty" RET
=> error : "Variable insertion second arg srecode-comment-prefix is not a function"

This function is defined in srecode/filters.el .

Andreas


In GNU Emacs 24.0.90.1 (x86_64-pc-linux-gnu, GTK+ Version 2.20.1)
 of 2011-10-18 on cw-bkp0, modified by Debian
 (emacs-snapshot package, version 1:20111012-1+squeeze1)
Windowing system distributor `The X.Org Foundation', version 11.0.10707000
configured using `configure  '--build' 'x86_64-linux-gnu' '--host' 'x86_64-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/24.0.90/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.0.90/site-lisp:/usr/share/emacs/site-lisp' '--without-compress-info' '--with-crt-dir=/usr/lib//' '--with-x=yes' '--with-x-toolkit=gtk' '--with-imagemagick=yes' 'build_alias=x86_64-linux-gnu' 'host_alias=x86_64-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: C
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Org

Minor modes in effect:
  defining-kbd-macro: t
  semantic-minor-modes-format: ((:eval (if (or semantic-highlight-edits-mode semantic-show-unmatched-syntax-mode)  S)))
  global-semanticdb-minor-mode: t
  global-semantic-idle-scheduler-mode: t
  semantic-mode: t
  shell-dirtrack-mode: t
  savehist-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-b C-n C-n C-n C-c C-c n M-< C-e M-b M-d f h - t r 
i e r . d e C-h a m a i C-g M-x a p r o <tab> - v a 
r <return> m a i l <return> C-x o C-v C-v C-v C-v C-v 
C-v C-v C-s u s e r C-s C-s <return> C-l <return> C-a 
C-M-SPC M-w C-x b i n i <tab> <return> M-> <return> 
( s e t q SPC C-y SPC " p o l i t z a @ f h - t r i 
e r . d e " ) C-x C-e C-x C-s C-x k <return> C-x b 
<return> C-x 1 C-c C-c C-g C-SPC M-{ M-{ C-w C-SPC 
M-{ M-{ C-w M-{ M-{ M-{ M-{ C-SPC C-g C-p C-p C-p C-p 
C-n C-n C-SPC M-> C-g C-u C-SPC C-l C-SPC M-} C-w C-k 
M-} C-/ C-/ C-/ C-/ C-/ C-v C-v C-v C-c C-c y C-x b 
* <backspace> <return> C-x C-k C-p C-p C-p C-n C-n 
C-n C-n C-g C-x ( M-x C-g C-h k C-x ( C-x o C-s b e 
f o <return> C-M-f C-x C-e C-M-b C-l C-l C-l C-M-SPC 
M-w C-x b f i l <tab> M-/ <M-backspace> <M-backspace> 
<M-backspace> <M-backspace> i n i <tab> C-g C-x r b 
f i l e : i n i t <tab> <return> M-> C-y M-y C-a ( 
s e t q SPC C-M-f C-x C-e SPC n i l ) C-x C-s C-x C-e 
M-b M-d t C-a ; ; C-e C-b <backspace> n i l C-x C-s 
C-x o C-x 1 C-x ( M-x r e p o r t <return> C-g C-x 
( M-f M-b C-SPC C-e M-w C-n C-a M-x r e p o r t <r
eturn>

Recent messages:
t
Saving file /home/politza/.emacs.d/init.el...
Wrote /home/politza/.emacs.d/init.el
nil
Saving file /home/politza/.emacs.d/init.el...
Wrote /home/politza/.emacs.d/init.el
Defining kbd macro...
Quit
Defining kbd macro...
Mark set

Load-path shadows:
/usr/share/emacs/site-lisp/haskell-mode/haskell-decl-scan hides /usr/share/emacs/24.0.90/site-lisp/haskell-mode/haskell-decl-scan
/usr/share/emacs/site-lisp/haskell-mode/haskell-c hides /usr/share/emacs/24.0.90/site-lisp/haskell-mode/haskell-c
/usr/share/emacs/site-lisp/haskell-mode/haskell-ghci hides /usr/share/emacs/24.0.90/site-lisp/haskell-mode/haskell-ghci
/usr/share/emacs/site-lisp/haskell-mode/haskell-doc hides /usr/share/emacs/24.0.90/site-lisp/haskell-mode/haskell-doc
/usr/share/emacs/site-lisp/haskell-mode/haskell-indent hides /usr/share/emacs/24.0.90/site-lisp/haskell-mode/haskell-indent
/usr/share/emacs/site-lisp/haskell-mode/haskell-mode hides /usr/share/emacs/24.0.90/site-lisp/haskell-mode/haskell-mode
/usr/share/emacs/site-lisp/haskell-mode/haskell-hugs hides /usr/share/emacs/24.0.90/site-lisp/haskell-mode/haskell-hugs
/usr/share/emacs/site-lisp/haskell-mode/haskell-site-file hides /usr/share/emacs/24.0.90/site-lisp/haskell-mode/haskell-site-file
/usr/share/emacs/site-lisp/haskell-mode/haskell-cabal hides /usr/share/emacs/24.0.90/site-lisp/haskell-mode/haskell-cabal
/usr/share/emacs/site-lisp/haskell-mode/inf-haskell hides /usr/share/emacs/24.0.90/site-lisp/haskell-mode/inf-haskell
/usr/share/emacs/site-lisp/haskell-mode/haskell-font-lock hides /usr/share/emacs/24.0.90/site-lisp/haskell-mode/haskell-font-lock
/usr/share/emacs/site-lisp/haskell-mode/haskell-simple-indent hides /usr/share/emacs/24.0.90/site-lisp/haskell-mode/haskell-simple-indent
/usr/share/emacs/site-lisp/haskell-mode/haskell-indentation hides /usr/share/emacs/24.0.90/site-lisp/haskell-mode/haskell-indentation
/usr/share/emacs/24.0.90/site-lisp/cscope/xcscope hides /usr/share/emacs/site-lisp/xcscope
/usr/share/emacs/24.0.90/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup
/home/politza/.emacs.d/plugins/battery hides /usr/share/emacs/24.0.90/lisp/battery
/home/politza/.emacs.d/bugfixes/esh-cmd hides /usr/share/emacs/24.0.90/lisp/eshell/esh-cmd

Features:
(mailalias smtpmail sendmail apropos shadow mail-extr emacsbug boxquote
rect ffap org-wl org-w3m org-vm org-rmail org-mhe org-mew org-irc
org-jsinfo org-infojs org-html org-exp ob-exp org-exp-blocks org-agenda
org-info org-gnus org-docview org-bibtex bibtex org-bbdb locate imenu
jka-compr find-func dired-aux wdired url-cache network-stream starttls
url-http tls url-gw url-auth url url-proxy url-privacy url-expand
url-methods url-history url-cookie url-util url-parse url-vars mailcap
finder-inf message rfc822 mml mml-sec mm-decode mm-bodies mm-encode
mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils
gmm-utils mailheader ediff-merg ediff-diff ediff-wind ediff-help
ediff-util ediff-mult ediff-init ediff reposition dabbrev vc-bzr
semantic/edit bookmark pp semantic/tag-write semantic/find multi-isearch
thingatpt semantic/decorate/mode help-mode debug semantic/db-file
cedet-files semantic/db-mode semantic/idle srecode/srt-mode
semantic/analyze semantic/sort semantic/scope semantic/analyze/fcn
semantic/db semantic/format ezimage srecode/template srecode/srt-wy
semantic/ctxt vc-dispatcher vc-svn server view eldoc srecode/mode
semantic/wisent semantic/wisent/wisent semantic/decorate pulse
srecode/filters newcomment srecode/insert srecode/args srecode/find
srecode/map srecode/ctxt semantic/tag-ls srecode/compile
srecode/dictionary srecode/table eieio-base semantic/util-modes
semantic/util semantic semantic/tag semantic/lex semantic/fw cedet
auctex-autoloads tex-site info c-eldoc-autoloads
sunrise-x-loop-autoloads sunrise-x-loop sunrise-commander term ehelp
electric sort find-dired disp-table enriched dired-x
sunrise-commander-autoloads package tabulated-list srecode mode-local
grep compile tramp tramp-compat auth-source eieio assoc gnus-util
mm-util mail-prsvr password-cache shell format-spec tramp-loaddefs
dired-details+ dired dired-details org byte-opt warnings bytecomp
byte-compile cconv macroexp advice help-fns advice-preload ob-emacs-lisp
ob-tangle ob-ref ob-lob ob-table org-footnote org-src ob-comint ob-keys
ob ob-eval org-pcomplete pcomplete comint ring org-list org-faces
org-compat org-entities org-macs noutline outline easy-mmode cal-menu
easymenu calendar cal-loaddefs time-date savehist regexp-opt edmacro
kmacro cl w3m-load tooltip ediff-hook vc-hooks lisp-float-type mwheel
x-win x-dnd tool-bar dnd fontset image fringe lisp-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs
button faces cus-face files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind dynamic-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)

bug#9967: 24.0.90; semantic/srecode : Missing require

[David Engster]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Andreas Politz writes:
> $ emacs -Q
>
> (require 'srecode)
> M-x srecode-insert RET "file:empty" RET
> => error : "Variable insertion second arg srecode-comment-prefix is not a function"
>
> This function is defined in srecode/filters.el .

I've attached a patch. I'm not sure if that's the best solution, but
please try if it fixes your problem.

-David


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: srecode-diff.patch --]
[-- Type: text/x-patch, Size: 942 bytes --]

=== modified file 'lisp/cedet/srecode/filters.el'
--- lisp/cedet/srecode/filters.el       2011-10-26 21:08:09 +0000
+++ lisp/cedet/srecode/filters.el       2011-11-01 21:11:12 +0000
@@ -26,8 +26,10 @@
 ;;; Code:
 
 (require 'newcomment)
-(require 'srecode/table)
-(require 'srecode/insert)
+
+(declare-function srecode-dictionary-lookup-name "srecode/dictionary")
+(defvar srecode-inserter-variable-current-dictionary)
+
 
 (defun srecode-comment-prefix (str)
   "Prefix each line of STR with the comment prefix characters."

=== modified file 'lisp/cedet/srecode/insert.el'
--- lisp/cedet/srecode/insert.el        2011-10-29 14:24:03 +0000
+++ lisp/cedet/srecode/insert.el        2011-11-01 21:11:12 +0000
@@ -33,6 +33,7 @@
 (require 'srecode/find)
 (require 'srecode/dictionary)
 (require 'srecode/args)
+(require 'srecode/filters)
 
 (defvar srecode-template-inserter-point)
 (declare-function srecode-overlaid-activate "srecode/fields")

bug#9967: 24.0.90; semantic/srecode : Missing require

[Chong Yidong]

David Engster <deng@randomsample.de> writes:

> I've attached a patch. I'm not sure if that's the best solution, but
> please try if it fixes your problem.

Since there was no response, I checked your patch into the trunk.
Thanks.