From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Tue, 28 Feb 2012 09:31:03 +0100 Message-ID: <87pqczxsu0.fsf@gmx.de> References: <87mx9su32g.fsf@web.de> <87pqd3i8ky.fsf@gmail.com> <87ipiuvsbw.fsf@gmx.de> <87k439gyu5.fsf@gmail.com> <87fwdwhizm.fsf@gmail.com> <87bookhfcn.fsf@gmail.com> <87aa44o7qo.fsf@gmail.com> <87ty2c490n.fsf@gmail.com> <87r4xgkt2b.fsf@gmail.com> <87obskum9i.fsf@gmx.de> <874nuc9bao.fsf@gmail.com> <874nubzdsu.fsf@gmail.com> <87zkc3xwdn.fsf@gmail.com> <87k437o1hm.fsf@gmx.de> <87vcmrxtk2.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1330417968 20768 80.91.229.3 (28 Feb 2012 08:32:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 28 Feb 2012 08:32:48 +0000 (UTC) Cc: 10489@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 28 09:32:45 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S2IUG-0007Pz-Ou for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Feb 2012 09:32:44 +0100 Original-Received: from localhost ([::1]:33351 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2IUG-0003Wc-0t for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Feb 2012 03:32:44 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:38342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2IU1-0003W5-C2 for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 03:32:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2ITu-0000i1-Q3 for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 03:32:28 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2ITu-0000hx-M0 for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 03:32:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S2IWU-0000Rs-GC for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 03:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Feb 2012 08:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.13304180781695 (code B ref 10489); Tue, 28 Feb 2012 08:35:02 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 28 Feb 2012 08:34:38 +0000 Original-Received: from localhost ([127.0.0.1]:60741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S2IW6-0000R8-BN for submit@debbugs.gnu.org; Tue, 28 Feb 2012 03:34:38 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:52616) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1S2IVu-0000Qk-K8 for 10489@debbugs.gnu.org; Tue, 28 Feb 2012 03:34:27 -0500 Original-Received: (qmail invoked by alias); 28 Feb 2012 08:31:14 -0000 Original-Received: from p57BB9CC6.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.156.198] by mail.gmx.net (mp033) with SMTP; 28 Feb 2012 09:31:14 +0100 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX18KFVlCWcQKqVssLM9QM9nbXcIfFwDNKOQq8ZaJ8z ejoQMcmm4Jw9E7 In-Reply-To: <87vcmrxtk2.fsf@gmail.com> (Thierry Volpiatto's message of "Tue, 28 Feb 2012 09:15:25 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57347 Archived-At: Thierry Volpiatto writes: > Hi Michael, Hi Thierry, >> `files-equal-p' still returns t for two non-existing files. Shall be >> fixed too. > Fixed. Looks good to me. Thanks! >> Btw, this is the only primitive function which has the prefix "files-", >> all other start with prefix "file-". Is this necessary? > I wrote files because comparing two files, but I don't care of this, > just rename it to file- Thanks as well. I will change the name in Tramp once you have committed your patch (or, even better, you do it in tramp.el when committing your patch). Still some nit-picking :-) > -(defun files-equal-p (file1 file2) > +(defun file-equal-p (file1 file2) > "Return non-nil if FILE1 and FILE2 name the same file. > Ordinary files are considered to be the same if `file-attributes' > returns `equal' values for them." The file name handler implementation might not use `file-attributes' (that's why we call the handler). Better, you don't say it such strictly in the doc-string. Furthermore, I would like to see the phrase "... existing files ..." somewhere. Best regards, Michael.