From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. Date: Wed, 15 Aug 2012 23:45:19 +0800 Message-ID: <87pq6scg6o.fsf@gnu.org> References: <87boj3byqy.fsf@acerpad.localdomain> <83k3x1jx3p.fsf@gnu.org> <874no4apau.fsf@acerpad.localdomain> <83628kkgjw.fsf@gnu.org> <87lihgffmn.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1345045587 27433 80.91.229.3 (15 Aug 2012 15:46:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 15 Aug 2012 15:46:27 +0000 (UTC) Cc: Li Ian-Xue , 12051@debbugs.gnu.org To: Leo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 15 17:46:27 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T1fnb-0002Nt-T6 for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Aug 2012 17:46:24 +0200 Original-Received: from localhost ([::1]:55764 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1fna-0002QV-UE for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Aug 2012 11:46:22 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1fnY-0002Pu-EK for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2012 11:46:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1fnX-00048p-9O for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2012 11:46:20 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49744) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1fnX-00048l-1o for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2012 11:46:19 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T1fvy-0006M5-Ep for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2012 11:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Aug 2012 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12051-submit@debbugs.gnu.org id=B12051.134504605424368 (code B ref 12051); Wed, 15 Aug 2012 15:55:02 +0000 Original-Received: (at 12051) by debbugs.gnu.org; 15 Aug 2012 15:54:14 +0000 Original-Received: from localhost ([127.0.0.1]:59290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1fvB-0006Kz-UY for submit@debbugs.gnu.org; Wed, 15 Aug 2012 11:54:14 -0400 Original-Received: from mail-gh0-f172.google.com ([209.85.160.172]:40692) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1fv9-0006Kr-UG for 12051@debbugs.gnu.org; Wed, 15 Aug 2012 11:54:12 -0400 Original-Received: by ghbg16 with SMTP id g16so2173476ghb.3 for <12051@debbugs.gnu.org>; Wed, 15 Aug 2012 08:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=pjWWcKo6sBSefGQpz21Aguikjtp5QC3bnWVBGF9wW0g=; b=rrFKECcf8dQL6VcKklDiGTGZ9apELo6taUJHKva8PcU9fFhkG0aYdDmsfGRpAGjuXT tdTxXX2lMKIyXWivQ/roVjqg+RhdyLeMlUz7LCCgYqjDFtwKn/Xrw/TA8xKz7bgJsQLG v3yvKZ+Nmoy0qcjGQG4F4It9i9cVs05jif+LrGa0xw/Dh/vSmvK2WOHXrUDWjZ4Bn1Nr aE+rwzyqIBscHvUUTbLNQpexuTRMO7VcKgeJFASe2lshn+UN6nPqrmCcH86K8/S+YTa6 kOcFN5Sita7WfwBrCg4gxscnnKJINW22J+drCw1Gdx1JOHiziqDV1o8SC6TIeZAG5LgJ kI9A== Original-Received: by 10.68.130.65 with SMTP id oc1mr6451807pbb.29.1345045526798; Wed, 15 Aug 2012 08:45:26 -0700 (PDT) Original-Received: from ulysses (cm162.gamma80.maxonline.com.sg. [202.156.80.162]) by mx.google.com with ESMTPS id rn4sm664748pbb.51.2012.08.15.08.45.22 (version=SSLv3 cipher=OTHER); Wed, 15 Aug 2012 08:45:25 -0700 (PDT) In-Reply-To: <87lihgffmn.fsf@gnu.org> (Chong Yidong's message of "Wed, 15 Aug 2012 21:29:04 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63196 Archived-At: Chong Yidong writes: > Leo writes: > >> I make a small optimisation that calls encode-coding-region char by >> char. Comments? > > If you are still working on this bug and not really sure what's the best > way to solve it, please revert it ASAP and move the bugfix to the trunk. > It is holding up the 24.2 release. OK, I just took a look at the relevant patches. Personally I think the previous patch is easier to understand, so unless this new version has significantly improved performance, I wouldn't bother with it. But in any case, please commit future versions of this fix to the trunk, not the branch, unless you find a regression with it. Thanks.