* bug#13581: 24.3.50; regression: defadvice does not work, to augment doc string
@ 2013-01-28 22:46 Drew Adams
2013-01-30 16:18 ` Drew Adams
0 siblings, 1 reply; 9+ messages in thread
From: Drew Adams @ 2013-01-28 22:46 UTC (permalink / raw)
To: 13581
emacs -Q
(defun frog () (interactive) (message "croak"))
(define-key isearch-mode-map "\C-o" 'frog)
(defadvice isearch-forward (before froggy activate)
"\\<isearch-mode-map>\\[frog] - hear Froggy croak")
C-h f isearch-forward
No Froggy to be seen. Worked in previous Emacs versions, including 24.2.
In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
of 2013-01-25 on ODIEONE
Bzr revision: 111604 eliz@gnu.org-20130125143821-1ykj7ia1qjojjjnp
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
`configure --with-gcc (4.7) --no-opt --enable-checking --cflags
-IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib'
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#13581: 24.3.50; regression: defadvice does not work, to augment doc string
2013-01-28 22:46 bug#13581: 24.3.50; regression: defadvice does not work, to augment doc string Drew Adams
@ 2013-01-30 16:18 ` Drew Adams
2013-01-30 16:38 ` Dani Moncayo
2013-01-30 17:08 ` Michael Heerdegen
0 siblings, 2 replies; 9+ messages in thread
From: Drew Adams @ 2013-01-30 16:18 UTC (permalink / raw)
To: 13581
I cannot download a pretest binary and try this in that now. Could someone else
please try it? If this is a regression also in the pretest (not just in the
trunk), then I think it should be fixed before the release. Thx.
> emacs -Q
>
> (defun frog () (interactive) (message "croak"))
> (define-key isearch-mode-map "\C-o" 'frog)
> (defadvice isearch-forward (before froggy activate)
> "\\<isearch-mode-map>\\[frog] - hear Froggy croak")
>
> C-h f isearch-forward
>
> No Froggy to be seen. Worked in previous Emacs versions,
> including 24.2.
>
>
> In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
> of 2013-01-25 on ODIEONE
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#13581: 24.3.50; regression: defadvice does not work, to augment doc string
2013-01-30 16:18 ` Drew Adams
@ 2013-01-30 16:38 ` Dani Moncayo
2013-01-30 16:42 ` Drew Adams
2013-01-30 17:08 ` Michael Heerdegen
1 sibling, 1 reply; 9+ messages in thread
From: Dani Moncayo @ 2013-01-30 16:38 UTC (permalink / raw)
To: Drew Adams; +Cc: 13581
> I cannot download a pretest binary and try this in that now.
You can get pretest binaries for MS-Windows from here:
https://www.dropbox.com/sh/7jr3vbv9tm1zod0/jPuvfrJAe8
The pretest versions are the ones starting with "emacs-24", so
currently the last one is "emacs-24-r111199-20130125-w32-i386.zip" (5
days old).
--
Dani Moncayo
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#13581: 24.3.50; regression: defadvice does not work, to augment doc string
2013-01-30 16:38 ` Dani Moncayo
@ 2013-01-30 16:42 ` Drew Adams
0 siblings, 0 replies; 9+ messages in thread
From: Drew Adams @ 2013-01-30 16:42 UTC (permalink / raw)
To: 'Dani Moncayo'; +Cc: 13581
> > I cannot download a pretest binary and try this in that now.
>
> You can get pretest binaries for MS-Windows from here:
> https://www.dropbox.com/sh/7jr3vbv9tm1zod0/jPuvfrJAe8
>
> The pretest versions are the ones starting with "emacs-24", so
> currently the last one is "emacs-24-r111199-20130125-w32-i386.zip" (5
> days old).
Yes, I know. But thanks, Dani.
As I said, I cannot download now. I have no access (at my end, not an Emacs Dev
problem).
I'm just asking that someone quickly check whether this regression is a problem
also for the pretest. If so, I think this needs to be fixed before release.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#13581: 24.3.50; regression: defadvice does not work, to augment doc string
2013-01-30 16:18 ` Drew Adams
2013-01-30 16:38 ` Dani Moncayo
@ 2013-01-30 17:08 ` Michael Heerdegen
2013-01-30 17:10 ` Drew Adams
` (2 more replies)
1 sibling, 3 replies; 9+ messages in thread
From: Michael Heerdegen @ 2013-01-30 17:08 UTC (permalink / raw)
To: 13581
"Drew Adams" <drew.adams@oracle.com> writes:
> I cannot download a pretest binary and try this in that now. Could
> someone else
> please try it? If this is a regression also in the pretest (not just
> in the
> trunk), then I think it should be fixed before the release. Thx.
Works for me in a built of the emacs-24 branch from today:
,----------------------------------------------------------------------
| [...]
| If this function is called non-interactively, it does not return to
| the calling function until the search is done.
|
| This function is advised.
|
| Before-advice `froggy':
| C-o - hear Froggy croak
`----------------------------------------------------------------------
Regards,
Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread* bug#13581: 24.3.50; regression: defadvice does not work, to augment doc string
2013-01-30 17:08 ` Michael Heerdegen
@ 2013-01-30 17:10 ` Drew Adams
2013-01-30 18:00 ` Dani Moncayo
2013-01-30 18:07 ` Glenn Morris
2 siblings, 0 replies; 9+ messages in thread
From: Drew Adams @ 2013-01-30 17:10 UTC (permalink / raw)
To: 'Michael Heerdegen', 13581
> Works for me in a built of the emacs-24 branch from today:
Good. Thanks for testing.
So unless this is platform-specific, which is unlikely, the regression was
introduced post-pretest.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#13581: 24.3.50; regression: defadvice does not work, to augment doc string
2013-01-30 17:08 ` Michael Heerdegen
2013-01-30 17:10 ` Drew Adams
@ 2013-01-30 18:00 ` Dani Moncayo
2013-01-30 18:09 ` Drew Adams
2013-01-30 18:07 ` Glenn Morris
2 siblings, 1 reply; 9+ messages in thread
From: Dani Moncayo @ 2013-01-30 18:00 UTC (permalink / raw)
To: Michael Heerdegen; +Cc: 13581
>> I cannot download a pretest binary and try this in that now. Could
>> someone else
>> please try it? If this is a regression also in the pretest (not just
>> in the
>> trunk), then I think it should be fixed before the release. Thx.
>
> Works for me in a built of the emacs-24 branch from today:
>
> ,----------------------------------------------------------------------
> | [...]
> | If this function is called non-interactively, it does not return to
> | the calling function until the search is done.
> |
> | This function is advised.
> |
> | Before-advice `froggy':
> | C-o - hear Froggy croak
> `----------------------------------------------------------------------
Works also for me on MS-Windows:
In GNU Emacs 24.2.92.1 (i386-mingw-nt6.1.7601)
of 2013-01-25 on MS-W8-DANI
Bzr revision: 111199 eliz@gnu.org-20130125144737-gedgongj7wf9j3hv
Windowing system distributor `Microsoft Corp.', version 6.1.7601
--
Dani Moncayo
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#13581: 24.3.50; regression: defadvice does not work, to augment doc string
2013-01-30 17:08 ` Michael Heerdegen
2013-01-30 17:10 ` Drew Adams
2013-01-30 18:00 ` Dani Moncayo
@ 2013-01-30 18:07 ` Glenn Morris
2 siblings, 0 replies; 9+ messages in thread
From: Glenn Morris @ 2013-01-30 18:07 UTC (permalink / raw)
To: 13581
Michael Heerdegen wrote:
> Works for me in a built of the emacs-24 branch from today:
As expected, since the recent advice changes are only in trunk.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-01-30 18:09 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-28 22:46 bug#13581: 24.3.50; regression: defadvice does not work, to augment doc string Drew Adams
2013-01-30 16:18 ` Drew Adams
2013-01-30 16:38 ` Dani Moncayo
2013-01-30 16:42 ` Drew Adams
2013-01-30 17:08 ` Michael Heerdegen
2013-01-30 17:10 ` Drew Adams
2013-01-30 18:00 ` Dani Moncayo
2013-01-30 18:09 ` Drew Adams
2013-01-30 18:07 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).