From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#14714: 24.3.50; `isearch-filter-predicate(s)' Date: Fri, 28 Jun 2013 02:39:37 +0300 Organization: JURTA Message-ID: <87ppv7cd7u.fsf@mail.jurta.org> References: <87vc50pmzw.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1372378817 25505 80.91.229.3 (28 Jun 2013 00:20:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 28 Jun 2013 00:20:17 +0000 (UTC) Cc: 14714@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 28 02:20:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UsMQA-00006I-OI for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Jun 2013 02:20:14 +0200 Original-Received: from localhost ([::1]:36820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsMQA-0006vs-Ar for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2013 20:20:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsMQ2-0006ln-7f for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 20:20:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsMQ0-00017e-Vd for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 20:20:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsMQ0-00017O-SQ for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 20:20:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1UsMQ0-0004H6-3Y for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 20:20:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jun 2013 00:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14714-submit@debbugs.gnu.org id=B14714.137237877816379 (code B ref 14714); Fri, 28 Jun 2013 00:20:03 +0000 Original-Received: (at 14714) by debbugs.gnu.org; 28 Jun 2013 00:19:38 +0000 Original-Received: from localhost ([127.0.0.1]:45840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UsMPZ-0004G1-MZ for submit@debbugs.gnu.org; Thu, 27 Jun 2013 20:19:37 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:44559 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UsMPW-0004Fg-Ul for 14714@debbugs.gnu.org; Thu, 27 Jun 2013 20:19:35 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 9C759258B9E91C; Thu, 27 Jun 2013 17:19:33 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed, 26 Jun 2013 21:32:01 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:75665 Archived-At: > Basically, replace > > (add-hook 'isearch-filter-predicate #'foo nil t) > with > (add-function :before-while (local isearch-filter-predicate) #'foo) > >> (defvar isearch-filter-predicate nil) > > For add-function to work well, you want to change this default value to > be a function, such as (lambda () t). I'm trying this, but not sure how to implement toggling like in `dired-isearch-filenames-toggle': (setq isearch-filter-predicates (if (memq 'dired-isearch-filter-filenames isearch-filter-predicates) (delq 'dired-isearch-filter-filenames isearch-filter-predicates) (cons 'dired-isearch-filter-filenames isearch-filter-predicates))) Whereas it's clear how to add and remove an advice function, it's unclear how to check its existence instead of `memq'. Is `advice-member-p' intended to do what `memq' does? When I tried (defvar-local isearch-filter-predicate (lambda (b e) t)) (defun test-b (b e) (message "b")) (defun test-a (b e) (message "a")) (add-function :before-while (local isearch-filter-predicate) #'test-b) (add-function :after-while (local isearch-filter-predicate) #'test-a) then (funcall isearch-filter-predicate 1 2) works fine, but (advice-member-p #'test-a 'isearch-filter-predicate) returns nil.