From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#19226: eww.el desktop support fixes: autoload eww-mode, use inhibit-read-only Date: Sat, 14 Feb 2015 20:50:41 +0000 Message-ID: <87pp9c9pzy.fsf@violet.siamics.net> References: <87bnst4fmc.fsf@violet.siamics.net> <87d28j7ajp.fsf@violet.siamics.net> <87bnnpne57.fsf_-_@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1423947096 25244 80.91.229.3 (14 Feb 2015 20:51:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Feb 2015 20:51:36 +0000 (UTC) To: 19226@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 14 21:51:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YMjgL-0003IF-SF for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Feb 2015 21:51:18 +0100 Original-Received: from localhost ([::1]:32867 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMjgK-0005KU-UG for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Feb 2015 15:51:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMjgC-0005Jx-Cl for bug-gnu-emacs@gnu.org; Sat, 14 Feb 2015 15:51:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMjg7-0006eB-6a for bug-gnu-emacs@gnu.org; Sat, 14 Feb 2015 15:51:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMjg6-0006e5-CJ for bug-gnu-emacs@gnu.org; Sat, 14 Feb 2015 15:51:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YMjg5-0000me-Q8 for bug-gnu-emacs@gnu.org; Sat, 14 Feb 2015 15:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Feb 2015 20:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19226 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19226-submit@debbugs.gnu.org id=B19226.14239470542999 (code B ref 19226); Sat, 14 Feb 2015 20:51:01 +0000 Original-Received: (at 19226) by debbugs.gnu.org; 14 Feb 2015 20:50:54 +0000 Original-Received: from localhost ([127.0.0.1]:44202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMjfx-0000mI-I6 for submit@debbugs.gnu.org; Sat, 14 Feb 2015 15:50:54 -0500 Original-Received: from fely.am-1.org ([78.47.74.50]:43861) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMjfu-0000m6-Cg for 19226@debbugs.gnu.org; Sat, 14 Feb 2015 15:50:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=PexBFnzeEQyXEacjgxVAk4GyDxXBBCovvmUv4u+BnbU=; b=HUn2aLM+4/YPTF4G9K+9dCIBZAFL8gUWPuWbzpSJdixSv3SHy1f+FJS02WvQuf7K6+dYW7zxnSe5gU8qxAhyK5IunaxzBZh46iOFZw6N5d6s2M/P2UJTG4+MORgAwOcDmQxRECvxzJjOLfLC9r+1G/9LR9Hi3SJhCt8bks+ZVBQ=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMjft-0005kq-51 for 19226@debbugs.gnu.org; Sat, 14 Feb 2015 20:50:49 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMjfm-0003FG-Fn for 19226@debbugs.gnu.org; Sun, 15 Feb 2015 03:50:42 +0700 Mail-Followup-To: 19226@debbugs.gnu.org In-Reply-To: <87bnnpne57.fsf_-_@violet.siamics.net> (Ivan Shmakov's message of "Sun, 30 Nov 2014 11:04:04 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99415 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable The discussion, as it seems, have lead us nowhere. Would there be any objections against me pushing the (updated) fix sometime within the next two days, /as well as/ a couple of unrelated minor changes (both MIMEd)? (Somehow, I believe that the discussion over the possible desktop.el vs. special modes changes can safely be postponed until something specific is suggested.) TIA. Fix eww.el desktop support. * lisp/net/eww.el (eww-mode): Add autoload cookie. (eww-restore-desktop): Use inhibit-read-only. Fixes: debbugs:19226 Minor eww.el fixes. * lisp/net/eww.el (eww-suggest-uris): Add autoload cookie, so that add-hook works correctly even if the file is not yet loaded. (eww-list-histories): Do not pad the rightmost (URIs) column. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -686,6 +687,8 @@ map) "Tool bar for `eww-mode'.") +;; Autoload cookie needed by desktop.el. +;;;###autoload (define-derived-mode eww-mode special-mode "eww" "Mode for browsing the web." (setq-local eww-data (list :title "")) @@ -1877,8 +1880,9 @@ defun eww-restore-desktop (file-name buffer-name misc-data) (case eww-restore-desktop ((t auto) (eww (plist-get eww-data :url))) ((zerop (buffer-size)) - (insert (substitute-command-keys - eww-restore-reload-prompt)))))) + (let ((inhibit-read-only t)) + (insert (substitute-command-keys + eww-restore-reload-prompt))))))) ;; . (current-buffer))) --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -60,6 +60,7 @@ :group 'eww :type 'string) +;;;###autoload (defcustom eww-suggest-uris '(eww-links-at-point url-get-url-at-point @@ -1634,7 +1637,7 @@ defun eww-list-histories () (setq start (point)) (setq domain-length (max domain-length (length (plist-get history :url)))) (setq title-length (max title-length (length (plist-get history :title))))) - (setq format (format "%%-%ds %%-%ds" title-length domain-length) + (setq format (format "%%-%ds %%s" title-length) header-line-format (concat " " (format format "Title" "URL"))) (dolist (history eww-history-trans) --=-=-=--