bug#19117: 25.0.50; emacs on x11 chooses different fonts for the same face sometimes

[handa@gnu.org (K. Handa)]

In article <87bnl9nkqe.fsf@gnu.org>, handa <handa@gnu.org> writes:

> In article <jwvfvamhoh2.fsf-monnier+emacsbugs@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca> writes:
> > > This is a gentle ping. Is there anything more I can do to get this
> > > merged?

> > I could install it, but I really have no idea whether your patch does
> > the right thing, because I'm too unfamiliar with this code.
> > Jan?  Handa?

Sorry for the late response.  I agree that the patch is
doing the correct thing, but it seems that it overlooks the
case of scalable-fonts-allowed being a cons:


	    else if (CONSP (Vscalable_fonts_allowed))
	      {
		Lisp_Object tail;

		for (tail = Vscalable_fonts_allowed; CONSP (tail);
		     tail = XCDR (tail))
		  {
		    Lisp_Object elt = XCAR (tail);
		    if (STRINGP (elt)
			&& (fast_c_string_match_ignore_case (elt, indices[i],
							     len)
			    >= 0))
		      break;
		  }
		if (! CONSP (tail))
		  continue;
	      }

Here too, skipped_some_scalable_fonts must be set to true
before "continue;".

And, one trivial comment on ChangeLog entry :-p

	* xfaces.c (realize_basic_faces): Don't set Qscalable_fonts_allowed to
	t.

Isn't it better to use the pair Qscalable_fonts_allowed and
Qt, or the pair scalable-fonts-allowed and t?

---
Kenichi Handa
handa@gnu.org