From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode Date: Fri, 20 Feb 2015 09:12:08 +0000 Message-ID: <87pp953q1j.fsf_-_@violet.siamics.net> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1424423602 11961 80.91.229.3 (20 Feb 2015 09:13:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Feb 2015 09:13:22 +0000 (UTC) To: 19903@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 20 10:13:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YOje3-0008Bc-RM for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2015 10:13:11 +0100 Original-Received: from localhost ([::1]:59561 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOje2-0002Dg-Uv for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2015 04:13:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOjdz-0002CZ-AF for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 04:13:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOjdw-0007KW-43 for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 04:13:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOjdu-0007KB-OL for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 04:13:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YOjdu-0002kV-CY for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 04:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Feb 2015 09:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19903 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19903-submit@debbugs.gnu.org id=B19903.142442354210516 (code B ref 19903); Fri, 20 Feb 2015 09:13:02 +0000 Original-Received: (at 19903) by debbugs.gnu.org; 20 Feb 2015 09:12:22 +0000 Original-Received: from localhost ([127.0.0.1]:49107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOjdE-0002jW-Lc for submit@debbugs.gnu.org; Fri, 20 Feb 2015 04:12:22 -0500 Original-Received: from fely.am-1.org ([78.47.74.50]:44790) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOjdB-0002jM-QK for 19903@debbugs.gnu.org; Fri, 20 Feb 2015 04:12:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=9rI39hDVdDXmIUMCmqWTJ/hsdgMSbUHRcoSH3dnKiCQ=; b=ARgK6zG/Vg+3gqigAnEHpMakrzYb6yWu16v/ii1hm16NrG1P7IUzlt18f/07qPFP1QbgNnSUyez1yD875qeSBbEdbIB4Pty6uWy4fCtUkxD+g1Yqt2JHQmOSJeWEFE9NjIa5u1aL7KIvw/r2XA/yWMVfexAIxY+q6yjruPOjgtQ=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YOjd9-0004jE-I6 for 19903@debbugs.gnu.org; Fri, 20 Feb 2015 09:12:15 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YOjd3-0000Za-2o for 19903@debbugs.gnu.org; Fri, 20 Feb 2015 16:12:09 +0700 Mail-Followup-To: 19903@debbugs.gnu.org In-Reply-To: (Jorge's message of "Fri, 20 Feb 2015 06:51:54 -0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99629 Archived-At: >>>>> Jorge writes: [=E2=80=A6] > However, it seems to me that the current behavior is not > user-friendly. (facemenu-set-face "bold" 1 2) _does_ make the text > bold, without any warning =E2=80=93 which makes it appear that the call = was > successful =E2=80=93 but then we get an error when we try to save the bu= ffer. The facemenu-set-face command is essentially a call to facemenu-add-new-face, followed by a call to facemenu-add-face. Curiously enough, the former implements explicit support for string arguments: $ git archive --format=3Dtar c4e2be4587ec -- lisp/facemenu.el \ | tar -xO | nl -ba ; # 2015-02-16 07:22:46 +0000=20 =E2=80=A6 785 (defun facemenu-add-new-face (face) 786 "Add FACE (a face) to the Face menu if `facemenu-listed-faces' say= s so. 787 This is called whenever you create a new face, and at other times." 788 (let* (name 789 symbol =E2=80=A6 792 function menu-val) 793 (if (symbolp face) 794 (setq name (symbol-name face) 795 symbol face) 796 (setq name face 797 symbol (intern name))) > Generally, it is best for errors to be detected as close to their > source as possible. What do you think? If string faces are rendered just the same as symbol ones, I=E2=80=99d rather wonder if either facemenu-add-face should silently =E2=80=98intern=E2=80=99 all the strings it gets before use, /or/ face-att= ribute should do that. (Or perhaps both.) --=20 FSF associate member #7257 np. Transformation =E2=80=94 David Modica B6A0= 230E 334A