unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#22773: 25.1.50; Some Gnus Variables not working anymore
@ 2016-02-22 17:51 Emilio Jesús Gallego Arias
  2016-02-23  1:21 ` Lars Ingebrigtsen
  2016-02-23  9:55 ` Lars Ingebrigtsen
  0 siblings, 2 replies; 7+ messages in thread
From: Emilio Jesús Gallego Arias @ 2016-02-22 17:51 UTC (permalink / raw)
  To: 22773

Hi,

message-dont-reply-to-names is broken in emacs master by commit:

357ae5dba5faac5ff48ebb971cb29500f87f02a6

In GNU Emacs 25.1.50.2 (x86_64-pc-linux-gnu, GTK+ Version 3.16.7)
 of 2016-02-22 built on lgw01-25
Windowing system distributor 'The X.Org Foundation', version 11.0.11702000
System Description:	Ubuntu 15.10

E.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#22773: 25.1.50; Some Gnus Variables not working anymore
  2016-02-22 17:51 bug#22773: 25.1.50; Some Gnus Variables not working anymore Emilio Jesús Gallego Arias
@ 2016-02-23  1:21 ` Lars Ingebrigtsen
  2016-02-23  8:40   ` Andreas Schwab
  2016-02-23  9:55 ` Lars Ingebrigtsen
  1 sibling, 1 reply; 7+ messages in thread
From: Lars Ingebrigtsen @ 2016-02-23  1:21 UTC (permalink / raw)
  To: Emilio Jesús Gallego Arias; +Cc: 22773

gallego@cri.ensmp.fr (Emilio Jesús Gallego Arias) writes:

> message-dont-reply-to-names is broken in emacs master by commit:
>
> 357ae5dba5faac5ff48ebb971cb29500f87f02a6

In what way is it broken?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#22773: 25.1.50; Some Gnus Variables not working anymore
  2016-02-23  1:21 ` Lars Ingebrigtsen
@ 2016-02-23  8:40   ` Andreas Schwab
  2016-02-23  9:51     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 7+ messages in thread
From: Andreas Schwab @ 2016-02-23  8:40 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Emilio Jesús Gallego Arias, 22773

Lars Ingebrigtsen <larsi@gnus.org> writes:

> gallego@cri.ensmp.fr (Emilio Jesús Gallego Arias) writes:
>
>> message-dont-reply-to-names is broken in emacs master by commit:
>>
>> 357ae5dba5faac5ff48ebb971cb29500f87f02a6
>
> In what way is it broken?

That looks wrong:

 (defsubst message-dont-reply-to-names ()
-  (gmm-regexp-concat message-dont-reply-to-names))
+  (cond ((functionp message-dont-reply-to-names)
+         message-dont-reply-to-names)
+        ((stringp message-dont-reply-to-names)
+         (gmm-regexp-concat message-dont-reply-to-names))))

It now returns nil if message-dont-reply-to-names is a list.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#22773: 25.1.50; Some Gnus Variables not working anymore
  2016-02-23  8:40   ` Andreas Schwab
@ 2016-02-23  9:51     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 7+ messages in thread
From: Lars Ingebrigtsen @ 2016-02-23  9:51 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: Emilio Jesús Gallego Arias, 22773

Andreas Schwab <schwab@suse.de> writes:

> That looks wrong:
>
>  (defsubst message-dont-reply-to-names ()
> -  (gmm-regexp-concat message-dont-reply-to-names))
> +  (cond ((functionp message-dont-reply-to-names)
> +         message-dont-reply-to-names)
> +        ((stringp message-dont-reply-to-names)
> +         (gmm-regexp-concat message-dont-reply-to-names))))
>
> It now returns nil if message-dont-reply-to-names is a list.

Ah, thanks.  I'll fix that...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#22773: 25.1.50; Some Gnus Variables not working anymore
  2016-02-22 17:51 bug#22773: 25.1.50; Some Gnus Variables not working anymore Emilio Jesús Gallego Arias
  2016-02-23  1:21 ` Lars Ingebrigtsen
@ 2016-02-23  9:55 ` Lars Ingebrigtsen
  2016-02-24 19:51   ` Emilio Jesús Gallego Arias
  2016-02-24 23:37   ` Rasmus
  1 sibling, 2 replies; 7+ messages in thread
From: Lars Ingebrigtsen @ 2016-02-23  9:55 UTC (permalink / raw)
  To: Emilio Jesús Gallego Arias; +Cc: 22773

gallego@cri.ensmp.fr (Emilio Jesús Gallego Arias) writes:

> message-dont-reply-to-names is broken in emacs master by commit:

I've now pushed something I think will fix this.  Could you update and
see whether it works now?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#22773: 25.1.50; Some Gnus Variables not working anymore
  2016-02-23  9:55 ` Lars Ingebrigtsen
@ 2016-02-24 19:51   ` Emilio Jesús Gallego Arias
  2016-02-24 23:37   ` Rasmus
  1 sibling, 0 replies; 7+ messages in thread
From: Emilio Jesús Gallego Arias @ 2016-02-24 19:51 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 22773-close

Lars Ingebrigtsen <larsi@gnus.org> writes:

> gallego@cri.ensmp.fr (Emilio Jesús Gallego Arias) writes:
>
>> message-dont-reply-to-names is broken in emacs master by commit:
>
> I've now pushed something I think will fix this.  Could you update and
> see whether it works now?

It seems fixed now, thanks !





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#22773: 25.1.50; Some Gnus Variables not working anymore
  2016-02-23  9:55 ` Lars Ingebrigtsen
  2016-02-24 19:51   ` Emilio Jesús Gallego Arias
@ 2016-02-24 23:37   ` Rasmus
  1 sibling, 0 replies; 7+ messages in thread
From: Rasmus @ 2016-02-24 23:37 UTC (permalink / raw)
  To: 22773

Lars Ingebrigtsen <larsi@gnus.org> writes:

> gallego@cri.ensmp.fr (Emilio Jesús Gallego Arias) writes:
>
>> message-dont-reply-to-names is broken in emacs master by commit:
>
> I've now pushed something I think will fix this.  Could you update and
> see whether it works now?

Thanks for fixing it Lars.  I saw this bug too late.  Thanks for reporting
it Emilio.

Rasmus

-- 
You people at the NSA are becoming my new best friends!






^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-02-24 23:37 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-22 17:51 bug#22773: 25.1.50; Some Gnus Variables not working anymore Emilio Jesús Gallego Arias
2016-02-23  1:21 ` Lars Ingebrigtsen
2016-02-23  8:40   ` Andreas Schwab
2016-02-23  9:51     ` Lars Ingebrigtsen
2016-02-23  9:55 ` Lars Ingebrigtsen
2016-02-24 19:51   ` Emilio Jesús Gallego Arias
2016-02-24 23:37   ` Rasmus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).