From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#20637: incompatible, undocumented change to vc-working-revision Date: Thu, 14 Apr 2016 09:21:38 +0200 Message-ID: <87potshczh.fsf@gmx.de> References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1460618553 11899 80.91.229.3 (14 Apr 2016 07:22:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 Apr 2016 07:22:33 +0000 (UTC) Cc: 20637@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 14 09:22:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aqbbZ-0004Ro-Jg for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Apr 2016 09:22:21 +0200 Original-Received: from localhost ([::1]:33704 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqbbT-0005Ao-Tn for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Apr 2016 03:22:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqbbN-00055T-6f for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2016 03:22:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqbbG-0000Od-Up for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2016 03:22:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqbbG-0000OX-RI for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2016 03:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aqbbG-0007Qt-G6; Thu, 14 Apr 2016 03:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, Dmitry Gutov Resent-Date: Thu, 14 Apr 2016 07:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20637 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20637-submit@debbugs.gnu.org id=B20637.146061850928549 (code B ref 20637); Thu, 14 Apr 2016 07:22:02 +0000 Original-Received: (at 20637) by debbugs.gnu.org; 14 Apr 2016 07:21:49 +0000 Original-Received: from localhost ([127.0.0.1]:34414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqbb3-0007QP-3b for submit@debbugs.gnu.org; Thu, 14 Apr 2016 03:21:49 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:52683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqbb1-0007QD-Ml for 20637@debbugs.gnu.org; Thu, 14 Apr 2016 03:21:48 -0400 Original-Received: from detlef.gmx.de ([87.146.59.141]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0M9K5G-1avb1039bi-00CiVj; Thu, 14 Apr 2016 09:21:40 +0200 In-Reply-To: (Dmitry Gutov's message of "Wed, 13 Apr 2016 23:49:12 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:hEiWU7g2sj0pLwgnLNRHUMjbZ8Xp9JMwGdpTR/e3aohZYcu/Via G7L1tnRg/WZhZq8XNSPlYaPF4mScquaGkmh58QWIw+vodtwL6f5HxEiDWiUYM9Mvqp4Hhxc Dll4RiqWghZ663R3OK5liuNefDuhnOYOf0C0M84HIeYVpNwgj1pl5QJJiHFp2sqrmtKiA3x jvZ9njR/AwKrZa4r+yZBA== X-UI-Out-Filterresults: notjunk:1;V01:K0:++3caKcwrMY=:zttECgt50DsthJ8fRGwBkD 7DZHKlmRGUPX2scfMdUuRVmJZ9KqwMTCfvmoc3wm9LViYvTBVmuNZxOWumDzJGbOzegGCep/n szLKMEM8GGtfdK6RjUfeDcXKHNWJqJ0dLALQuTWYqrolg3aggBppJ9LNMCnnmeuoc3PElavMU 05lbmH7QRnOVAFd+PJ5hFZOH88G30duHSYv0XldHzBr84qqDWffXtgy8av2/djqvlPswNd8j/ qm3IIXbCaklK0B6Qp/GDkawpQo9ioeUMuZ+4DKyFHfBPfuX4OWxaHsgwUyTDv1hEJv8fRE3y1 MmCiW5yk0yM3yUp2swZAy38Vp2UhCokYYhLU7c79DEgV8pj5SdMUP+nAvDzReoODOZF1gvNEk uSFnkWgk2NX2oKbXc4t5bYYyyx54LUTTgdHbodCBG0AEFy5Vh7f0j5PoSlaySBgfMgCw17LW9 7MbX4H6A1OJC+ch6ISyNPi7Jo6i3sGOP6Ucb5WG9KmqJ3094G2z9Ig01Bl1VLfgrZNyITa7y7 kQYTX71evugb4MsI7PhWAunBardAJ6wYnQ5DdFA7XRDCDYoQNyYDdgnsbiQyvltbWPljLCtuP Wb7jNPqHSwmx7c2IvIdh48TA6GJvWTpQoKY1kRKSO7JZR/Gkmlxyq0YshMsHkSeirqZESNbFx RCn0ojxpti/rhIZlbpi7twF9QtTdA0/RTzQxpRPXn18lAyoLY9/I3oZ+aClEMzPvLkdPp721w Cl2fpAeB2G2va4GdL1I5I37icADZEdsri74TRMBsA6kAW7pJxVLbhfmMOgRlQa1RxKMNMzwC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116452 Archived-At: Dmitry Gutov writes: > Hey Michael, Hi Dmitry, > Problem: vc-registered is slower than vc-backend. Like, orders of > magnitude slower. vc-backend caches the result of the previous > vc-registered invocation in vc-file-prop-obarray. But if we call > vc-registered directly, we go the whole way each time, including > calling vc-BACKEND-registered. I haven't thought too much about performance. But you are right, we shouldn't add serious performance penalties to the code. And improving performance for the 25.1 release is much too late. So we might revert the patch for vc-state and vc-working-revision indeed for the emacs-25 branch, going back to using vc-backend. In the master branch we might apply my proposed patch using vc-registered or something similar, and start to improve performance. In parallel, we shall start to write a VCS section for the elisp manual, describing vc-* functionality in more detail. We could start with vc-backend and vc-responsible-backend and their intended use. I'm missing such documentation for years. I'll come back later today with the patch for emacs-25, if you agree. Best regards, Michael.