unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 15682@debbugs.gnu.org, 52@debbugs.gnu.org
Subject: bug#52: bug#15682: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link'
Date: Wed, 27 Apr 2016 18:53:17 +0200	[thread overview]
Message-ID: <87potbgfia.fsf@gnus.org> (raw)
In-Reply-To: <89237c28-b7ed-4621-9baf-908fe99a6c9d@default> (Drew Adams's message of "Wed, 27 Apr 2016 09:24:34 -0700 (PDT)")

Drew Adams <drew.adams@oracle.com> writes:

> Dunno.  But just because the code can be difficult to follow
> is not a reason to assume that it does unnecessary things, in
> general.  The widget code that I've been able to follow does
> DTRT, generally (AFAICT).

It does, but the logic is very hard to follow.  Custom/widget works by
inserting text into the buffer, and then "converting" it to a widget, or
by creating a widget and then inserting it.  And it does it all with
overlays, and seems like it's created its own event handling distinct
from the normal Emacs event handler, sort of.

There are, of course, historical reasons for this.  Per wrote Widget in
the mid 90s when many of these issues hadn't been resolved, and it
worked across many Emacs versions.

I kinda think it might be time to consider doing a rewrite from scratch
using modern Emacs features, and then things like this bug report would
start working automatically.

How big a task would this be?  I mean, of course we'd keep compatibility
(the defcustom language is fine), but just rewrite the UI `M-x
customize' bits...  Hm...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2016-04-27 16:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-22 15:28 bug#15682: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' Drew Adams
2016-04-27 16:09 ` bug#52: " Lars Ingebrigtsen
2016-04-27 16:24   ` Drew Adams
2016-04-27 16:53     ` Lars Ingebrigtsen [this message]
2016-04-27 17:18       ` Drew Adams
2019-08-23 20:41 ` Mauro Aranda
2019-08-25  5:47   ` Lars Ingebrigtsen
2019-08-25 15:07     ` Mauro Aranda
2019-08-25 16:19       ` Drew Adams
2019-08-25 16:22         ` Drew Adams
2019-08-25 16:41           ` Eli Zaretskii
2019-08-25 16:50           ` Noam Postavsky
2019-08-25 16:58             ` Mauro Aranda
2019-08-27  6:42       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87potbgfia.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=15682@debbugs.gnu.org \
    --cc=52@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).