From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#13670: 24.3.50; `autoload-generate-file-autoloads' off-by-one bug Date: Fri, 29 Apr 2016 00:29:11 +0200 Message-ID: <87pot92wqw.fsf@gnus.org> References: <8E0945F19B9F4E37BA18A7A2232F6411@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461882626 15697 80.91.229.3 (28 Apr 2016 22:30:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Apr 2016 22:30:26 +0000 (UTC) Cc: 13670@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 29 00:30:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1avuRp-0003km-Ou for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Apr 2016 00:30:13 +0200 Original-Received: from localhost ([::1]:51428 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avuRl-0002Fr-RP for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Apr 2016 18:30:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avuRi-0002Bv-PR for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 18:30:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avuRf-0003Ph-KJ for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 18:30:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avuRf-0003Pa-Hr for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 18:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1avuRe-0005Hr-St for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 18:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2016 22:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13670 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13670-submit@debbugs.gnu.org id=B13670.146188256620250 (code B ref 13670); Thu, 28 Apr 2016 22:30:02 +0000 Original-Received: (at 13670) by debbugs.gnu.org; 28 Apr 2016 22:29:26 +0000 Original-Received: from localhost ([127.0.0.1]:53664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avuR3-0005GY-Tf for submit@debbugs.gnu.org; Thu, 28 Apr 2016 18:29:26 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:38507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avuR2-0005GR-FS for 13670@debbugs.gnu.org; Thu, 28 Apr 2016 18:29:24 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1avuR0-00017w-0E; Fri, 29 Apr 2016 00:29:23 +0200 In-Reply-To: <8E0945F19B9F4E37BA18A7A2232F6411@us.oracle.com> (Drew Adams's message of "Sat, 9 Feb 2013 16:03:30 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117127 Archived-At: "Drew Adams" writes: > This source code line of `autoload-generate-file-autoloads': > > (if (= (char-after (1+ (point))) ? ) > > should be replaced by this: > > (if (= (char-after (point)) ? ) [...] > You can use cookies like this: > > ;;;###autoload (autoload 'icicle-mode "icicles" > ;;;###autoload"Icicle mode: Toggle minibuffer input completion and cycling. > ;;;###autoload Non-nil prefix ARG turns mode on if ARG > 0, else off. > ;;;###autoload It is a global minor mode. It binds minibuffer keys." > ;;;###autoload t nil) If we make this change, then autoloads that want to have a single space at the start of the string (and use this syntax to do that) would then not have that space? Have you examined the sources to see whether that's potentially a problem? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no