unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 15909@debbugs.gnu.org
Subject: bug#15909: 24.3.50; please fix `read-face-name' brain-dead PROMPT handling
Date: Fri, 29 Apr 2016 16:42:14 +0200	[thread overview]
Message-ID: <87pot85veh.fsf@gnus.org> (raw)
In-Reply-To: <a4bc6974-37f7-4bb4-ab47-d9f51a2d07d6@default> (Drew Adams's message of "Fri, 15 Nov 2013 14:12:31 -0800 (PST)")

Drew Adams <drew.adams@oracle.com> writes:

> In Emacs 20, the PROMPT arg was just passed to `completing-read'.  So
> you used ": " at the end.  As usual in Emacs.  Simple.  Sure.  No
> nonsense.
>
> In Emacs 22, `read-face-name' decided to become "smart": It required
> callers NOT to end the PROMPT with a space.  Dumb.
>
> In Emacs 24, `read-face-name' decided to become even "smarter": It
> requires callers NOT to end the PROMPT with EITHER a space or a colon.
> It systematically adds ": " to PROMPT.  Dumber.
>
> This is silly.  It means that any 3rd-party code that passes a prompt to
> `read-face-name' has to fiddle with it to get the desired result for
> different Emacs versions.  To what end?  What good is accomplished by
> this silliness?

I've now pushed a fix for this to the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      parent reply	other threads:[~2016-04-29 14:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-15 22:12 bug#15909: 24.3.50; please fix `read-face-name' brain-dead PROMPT handling Drew Adams
2013-11-15 22:49 ` Drew Adams
2014-02-08  3:14 ` Lars Ingebrigtsen
2014-02-08 23:08   ` Drew Adams
2016-04-29 14:42 ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pot85veh.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=15909@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).