From: Michael Albinus <michael.albinus@gmx.de>
To: Glenn Morris <rgm@gnu.org>
Cc: 23618@debbugs.gnu.org
Subject: bug#23618: Some filenotify tests fail with extra "changed" events
Date: Sun, 05 Jun 2016 19:59:11 +0200 [thread overview]
Message-ID: <87porv8qkw.fsf@gmx.de> (raw)
In-Reply-To: <87oa7rgz3e.fsf@gmx.de> (Michael Albinus's message of "Fri, 27 May 2016 20:00:53 +0200")
Michael Albinus <michael.albinus@gmx.de> writes:
Hi Glenn,
> OK, I'll try to get an RHEL 7.2 VM in order to reproduce it. Or maybe a
> CentOS VM, in case RHEL VMs are not available.
I haven't been able to reproduce the problems this way :-(
Anyway, the bug in `file-notify-test08-watched-file-in-watched-dir-remote'
I could fix (this was the only one I could reproduce locally).
Furthermore, I've added code to filenotify-tests.el in order to make it
more robust. That' means especially, that no events could arrive during
a test, resulting from a *previous* test. Maybe this fixes the other
problems already. Committed to the master branch.
> In case it fails, I will send you an instrumentation patch for
> filenotify-tests.el. We do agree that we work on the master branch,
> don't we?
In that case, pls apply the following patch
--8<---------------cut here---------------start------------->8---
*** /home/albinus/src/emacs/lisp/filenotify.el.~6627dd7c9405670db99b792f782aa94c5da118a9~ 2016-06-05 19:56:18.485624177 +0200
--- /home/albinus/src/emacs/lisp/filenotify.el 2016-06-05 19:56:02.353342656 +0200
***************
*** 86,92 ****
Otherwise, signal a `file-notify-error'."
(interactive "e")
! ;;(message "file-notify-handle-event %S" event)
(if (and (eq (car event) 'file-notify)
(>= (length event) 3))
(funcall (nth 2 event) (nth 1 event))
--- 86,92 ----
Otherwise, signal a `file-notify-error'."
(interactive "e")
! (message "file-notify-handle-event %S" event)
(if (and (eq (car event) 'file-notify)
(>= (length event) 3))
(funcall (nth 2 event) (nth 1 event))
***************
*** 261,270 ****
(and (stringp file1)
(string-equal
(nth 0 entry) (file-name-nondirectory file1)))))
! ;;(message
! ;;"file-notify-callback %S %S %S %S %S"
! ;;(file-notify--descriptor desc (car entry))
! ;;action file file1 registered)
(if file1
(funcall
callback
--- 261,270 ----
(and (stringp file1)
(string-equal
(nth 0 entry) (file-name-nondirectory file1)))))
! (message
! "file-notify-callback %S %S %S %S %S"
! (file-notify--descriptor desc (car entry))
! action file file1 registered)
(if file1
(funcall
callback
--8<---------------cut here---------------end--------------->8---
Hopefully, the logs will tell us what happens.
Best regards, Michael.
next prev parent reply other threads:[~2016-06-05 17:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 16:55 bug#23618: Some filenotify tests fail with extra "changed" events Glenn Morris
2016-05-27 9:24 ` Michael Albinus
2016-05-27 16:38 ` Glenn Morris
2016-05-27 18:00 ` Michael Albinus
2016-06-05 17:59 ` Michael Albinus [this message]
2016-06-07 21:23 ` Glenn Morris
2016-06-20 12:46 ` Michael Albinus
2016-06-23 17:34 ` Glenn Morris
2016-06-23 18:34 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87porv8qkw.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=23618@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).