From: Tino Calancha <tino.calancha@gmail.com>
To: Drew Adams <drew.adams@oracle.com>
Cc: Stephen Berman <stephen.berman@gmx.net>,
tino.calancha@gmail.com, 24969@debbugs.gnu.org,
npostavs@users.sourceforge.net
Subject: bug#24969: 26.0.50; number-at-point
Date: Mon, 21 Nov 2016 22:09:41 +0900 [thread overview]
Message-ID: <87polp7ze2.fsf@gmail.com> (raw)
In-Reply-To: <f3a4ffe3-a283-444f-a6fc-48d2bca507ca@default> (Drew Adams's message of "Sun, 20 Nov 2016 08:19:28 -0800 (PST)")
Drew Adams <drew.adams@oracle.com> writes:
> In Emacs 25.1 (emacs -Q), `number-at-point' at either
> the `-' or the `1' returns nil, for me. And I do not
> see why it should return a number.
>
> `number-at-point' is defined using `form-at-point' with
> THING `sexp' and predicate `numberp'. The sexp picked
> up at point is `foo-1', and that fails `numberp'.
From the time when i opened Bug#24605, the
implementation, in master branch, of `number-at-point'
was different: it changed in commit 786ab4a5 (Bug#8634).
My patch was driven by this implementation. I didn't notice
that `number-at-point' behaves different in emacs-25.
> What am I missing? Why should this rightfully return
> a number? I'm guessing that you are all using a more
> recent version of `number-at-point' than what is in
> Emacs 25.1 (?). But to me the Emacs 25.1 behavior I
> see (i.e., returning nil) is correct.
>
> Did someone change the meaning of `number-at-point'
> so that it now picks up a numeral that is not isolated?
> If so, why would that be considered proper behavior?
> At the very least it is not backward-compatible behavior.
That's right. Commit above breaks backward-compatibility.
>In Lisp, at least, there is no number at point, in `foo-2'.
>That is, the Lisp parser (reader) would never pick up the
>`2' as a number here.
The doc string of `list-at-point' clearly says that the list should
be a Lisp list. In the case of `number-at-point' the doc string just
says 'the number at point', without connection with the Lisp parser.
>IOW, I agree with the bug report that `form-at-point'
>should - somehow - handle the case where `thing-at-point'
>returns a non-string. There is a bug to be fixed. But
>I'm not convinced that the fix we've implemented is TRT.
Sure, I am open to alternative fixes.
next prev parent reply other threads:[~2016-11-21 13:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 12:47 bug#24969: 26.0.50; number-at-point Andreas Röhler
2016-11-20 12:53 ` Stephen Berman
2016-11-20 13:53 ` Andreas Röhler
2016-11-20 14:15 ` npostavs
2016-11-20 16:19 ` Drew Adams
2016-11-20 16:35 ` Noam Postavsky
2016-11-20 16:58 ` Drew Adams
2016-11-20 19:26 ` Andreas Röhler
2016-11-20 21:28 ` Drew Adams
2016-11-21 6:48 ` Andreas Röhler
2016-11-21 14:22 ` Drew Adams
2016-11-21 13:09 ` Tino Calancha [this message]
2016-11-21 23:07 ` Drew Adams
2016-11-22 8:45 ` Andreas Röhler
2021-08-10 16:18 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87polp7ze2.fsf@gmail.com \
--to=tino.calancha@gmail.com \
--cc=24969@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=npostavs@users.sourceforge.net \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).