From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#25482: 26.0.50; Allow setting `query-replace-from-to-separator` to nil Date: Sat, 28 Jan 2017 11:43:48 +0100 Message-ID: <87poj7wjkr.fsf@gmail.com> References: <871svzzcn4.fsf@gmail.com> <83lgu76nuf.fsf@gnu.org> <87vatac0a2.fsf@gmail.com> <83a8am6u6q.fsf@gnu.org> <87y3y6ezge.fsf@gmail.com> <8337gd7udo.fsf@gnu.org> <87o9z1n4o3.fsf@gmail.com> <83lgu252zc.fsf@gnu.org> <87o9yy26pg.fsf@gmail.com> <83fuka4yzj.fsf@gnu.org> <87vat65h3o.fsf@gmail.com> <87r33n3cgk.fsf@gmail.com> <83tw8jzllx.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1485600263 9362 195.159.176.226 (28 Jan 2017 10:44:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Jan 2017 10:44:23 +0000 (UTC) User-Agent: mu4e 0.9.19; emacs 24.5.1 Cc: 25482@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 28 11:44:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXQUM-0000qE-JI for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Jan 2017 11:44:10 +0100 Original-Received: from localhost ([::1]:51215 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXQUO-0000nf-TL for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Jan 2017 05:44:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXQUH-0000mV-9q for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 05:44:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXQUE-00067s-70 for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 05:44:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50601) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXQUE-00067o-3h for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 05:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cXQUD-0007Ew-U3 for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 05:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jan 2017 10:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25482 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25482-submit@debbugs.gnu.org id=B25482.148560024027815 (code B ref 25482); Sat, 28 Jan 2017 10:44:01 +0000 Original-Received: (at 25482) by debbugs.gnu.org; 28 Jan 2017 10:44:00 +0000 Original-Received: from localhost ([127.0.0.1]:48800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXQUB-0007EZ-W1 for submit@debbugs.gnu.org; Sat, 28 Jan 2017 05:44:00 -0500 Original-Received: from mail-wm0-f54.google.com ([74.125.82.54]:34391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXQU9-0007EL-Tt for 25482@debbugs.gnu.org; Sat, 28 Jan 2017 05:43:58 -0500 Original-Received: by mail-wm0-f54.google.com with SMTP id p192so5825093wme.1 for <25482@debbugs.gnu.org>; Sat, 28 Jan 2017 02:43:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=wy46w6CQcGsjWi2VJk1NRFtFT5nUl9Oui4e0ltpT29w=; b=kFsXWS8qRAFHp6ywuMRgQuAtuim5HeTR37VFGrBbX9zOjzqbBMzmLn5syQ/xKZRAPt I5woiiekVd07Qt7RlEoQRf5xEn2E3lwCyP3KgREVFiSz5lxpQ6eU8ck3kUI8DeysYHw9 TIHW6t7GDwjG+yCgptvsKnvMGODBy0JSPBtDPLBHghbvc7D3HbpcLvJycBlsDWj4GVf4 Ro2hozhGmusZWqVSvucvHIVoYr2t9j68Q2O3NgNEYH/gA/TUTADqdfQCScivleKd49Yg JehnJVIbX0zjd4fBdoY9NRAV/zbiI3ZJbBu5IcHyrZaRecWR5bCWHBdofBZimNWDvkKn WELg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=wy46w6CQcGsjWi2VJk1NRFtFT5nUl9Oui4e0ltpT29w=; b=GkBD3Olooq0NAFKeCdU+8tPaAW2Mn8JPfLZ5TkgRcyeO2AItyJpZg/3iBKf4VXqv3T TMxcEzDJZlKaOVWxSVXmvZSqEDfLglWOMr0CcDEnmKOzGa6S9e7MHijKR2eylFH3WNGQ qIAqlS5bjWissC4z5jVO1rhoNd4jJXeM1Ku/2f3hRxHUvNJXN3XRWiGNVPW6nMJaOaYN Rc/8bZtXm4pIU1vLXGKGmpWhrpXQfKjUmg6t6eqA05ykO1RApYYcnjFntBlv0jXh15UA ACvDce+FQxHx1+XGpyBqg80jlZxIGVQZy4QJjLJr49nMq+nQTRXzPgLQ8Uddh9P45JLY UVcQ== X-Gm-Message-State: AIkVDXLqArP3wUx0BtOn8Stw8Ku1ZhK8jB1npXM5gHlf1c5oONcxCIcq10cnvrXmGwhIOw== X-Received: by 10.223.138.241 with SMTP id z46mr13507403wrz.30.1485600232194; Sat, 28 Jan 2017 02:43:52 -0800 (PST) Original-Received: from dell-14z ([37.169.101.111]) by smtp.gmail.com with ESMTPSA id e72sm8242803wma.16.2017.01.28.02.43.50 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 28 Jan 2017 02:43:51 -0800 (PST) In-reply-to: <83tw8jzllx.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128711 Archived-At: Eli Zaretskii writes: > Thanks, but I don't understand why you want to get rid of the display > property. This complicate the code and force external apps to handle this, see https://github.com/emacs-helm/helm/commit/2b8576c0705145b5d133e41478976eef5b3d7390 > (I also object to calling the result of that "crap".) Sorry, but it is: Selecting foo → bar in a list results in foo^@bar being entered into the minibuffer, not with the query-replace interface but when handling the history list from somewhere else. > I'd rather we left the display property and its supporting code > intact, and only moved the char-displayable-p call to the place where > the string is used instead of having it in the defcustom, thus > allowing customizations with setq. That should solve the real > problems with the current code, leaving the style-related issues > alone. It doesn't see above. > I realize that you don't like that style, but I think we should > respect style preferences of others and not change their code just > because we would have written it differently. The patch change nothing and allow same customization as before. I wrote this patch because I think it makes the code better, allow easier customization and fix issue described above. I understand if you want to keep the code as it is to be sure nothing wrong is introduced in a code that is already "working". Thanks. -- Thierry