From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#26126: 26.0.50; file-notify-rm-watch removes arbitrary watches Date: Sat, 18 Mar 2017 09:30:42 +0100 Message-ID: <87pohfkmvh.fsf@detlef> References: <87r31x9ulw.fsf@luca> <87shmcney8.fsf@detlef> <87efxw7xvc.fsf@luca> <87mvcjophx.fsf@detlef> <87tw6rssoi.fsf@luca> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1489825880 28802 195.159.176.226 (18 Mar 2017 08:31:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Mar 2017 08:31:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 26126@debbugs.gnu.org To: Andreas Politz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 18 09:31:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cp9lX-0006La-5b for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Mar 2017 09:31:11 +0100 Original-Received: from localhost ([::1]:52241 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cp9lZ-00021u-Up for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Mar 2017 04:31:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cp9lS-00021R-Hj for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2017 04:31:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cp9lO-0000Ew-Gn for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2017 04:31:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35022) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cp9lO-0000EG-9f for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2017 04:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cp9lN-0001y7-VP for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2017 04:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Mar 2017 08:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26126-submit@debbugs.gnu.org id=B26126.14898258537552 (code B ref 26126); Sat, 18 Mar 2017 08:31:01 +0000 Original-Received: (at 26126) by debbugs.gnu.org; 18 Mar 2017 08:30:53 +0000 Original-Received: from localhost ([127.0.0.1]:33221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cp9lE-0001xj-Qe for submit@debbugs.gnu.org; Sat, 18 Mar 2017 04:30:52 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:53849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cp9lC-0001xU-Jo for 26126@debbugs.gnu.org; Sat, 18 Mar 2017 04:30:51 -0400 Original-Received: from detlef.gmx.de ([87.146.40.245]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LqW8j-1cKTpq43VZ-00e0e4; Sat, 18 Mar 2017 09:30:44 +0100 In-Reply-To: <87tw6rssoi.fsf@luca> (Andreas Politz's message of "Fri, 17 Mar 2017 18:45:49 +0100") X-Provags-ID: V03:K0:XzDVh0tgkG96THZ+70Z2H9Lpa3EUrmsQxK5gs8JfKifwSyloWrq 3hT5fo/SiP3/6Uv3WH78PVo+0r86r5fYEBqzPRPe/Gy2uaNzm4MOhSWuMkB0Nx8gd10WoB5 FIVB+k+PNHtQtcM+zISjeKH3RWl6uvAGuCuZ4nycqF4gibKxC6wecJ8l3oe7Mgz1JtQS9DB gkwfGIzx0EOkPdS0v7QFQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:0P9eg2VpL5o=:fTF+eKkBc8PlEEsruyOFyI mtFXviDAzENe3Q0pYKuUg3TmJFqfyA+qOGuVJ6NdB6UvMrLA2TZQl5ngYbuuUZtIyGwalZbEr AhNH4VtcARuP++bHdC7768k2kEW6ZTYJAD7z+yIpm2hugyxdJY/6LXhcpCoK3oGQXBIi08cQX XTNZjkohKafoJJML4R8nNXrInKclhM2TqL+Eq/hW8NFpKtBA8D0UFcTJBIRnZwTN4zfUqXcwH XoNTQIMJUyJO0o4J63QvJ3lF1WlqpRb2gbUM4/TFzkE5VNMvbemolBbkSrjRxGzSMynkEhqei NL2Ubwzv8XdgWuFRCBJDQ9sY/c6TnG7ZqkBRZfpO5/NopIPrvcQynE0jUHFtDuJMaSHRu/dfR 4ErncQpJHF8GMrD8EvU5uD+dKbVhRLNxPtlDsQSxtTOhDBmHNZHs3UFG6LQG3TRWFesOmIRW/ RJIROSmpiQD2q8Ct9G0T+0Uxxc+aOVSMOTWCIt+dSuAilhb5zJJ1KLhiUZoqNg++UfBpZYI3j cQ1Iki8xM3vkyrkgzI6bnjB2zMZUQgJsaMgOQqshJMkACN4JFeSVlcCTHReUCVlbJX6vS8hvb Xze+O/Q0aTXzCIcSeAlPiIYQsNORbBUZNEdziWC2STroIwO7iej0VKZrx85igHVXLZgUzXORi Qxb55E1pKyuynwKfZRHNNHyOZT/naIHjVdSjPBNNWlKg2ax6qeDvWWlaxZv4j1UEKoE4q5xYj fDiT983vlHzTEkcmEd7cpbKpwLEYHY+RJRSn4xkv+BjqVu9RxmOjpemYA/FVrkGtTNt8iHWO X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130689 Archived-At: Andreas Politz writes: > What I would do, is box the internal descriptor in file-notify-add-watch, > to make it unique to the caller and unbox it in file-notify-rm-watch and > file-notify-valid-p. Sounds OK to me. Do you want to do this only for inotify, or also for the other backends? > A different question is, whether file-notify-add-watch should behave > like add-hook with regards to adding a function multiple times. I don't > think it does at the moment, so I probably leave it as such (?). I believe adding the *same* function twice for the same file/directory doesn't make sense. Maybe we should document this in the Elisp manual, and test it also in `file-notify-test01-add-watch'. > -ap Best regards, Michael.