From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#354: "Added (how many lines, bytes?!) to file.txt" Date: Sun, 02 Apr 2017 15:09:07 -0400 Message-ID: <87poguwrsc.fsf@users.sourceforge.net> References: <54F01AE2.8050406@cs.ucla.edu> <87y4njzckz.fsf@gmail.com> <87fuig7jxo.fsf@users.sourceforge.net> <83h92vc0op.fsf@gnu.org> <87mvc021mr.fsf@users.sourceforge.net> <83zig04q2n.fsf@gnu.org> <87shlrxy2e.fsf@users.sourceforge.net> <87shlqwt4p.fsf@users.sourceforge.net> <4ac2a524-05db-071b-6628-73a5ccad14ce@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1491160098 31651 195.159.176.226 (2 Apr 2017 19:08:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 2 Apr 2017 19:08:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: 354@debbugs.gnu.org, kb1vqh@gmail.com To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 02 21:08:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cukrA-0007Ep-PW for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Apr 2017 21:08:08 +0200 Original-Received: from localhost ([::1]:55975 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cukrG-0003fl-LQ for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Apr 2017 15:08:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cukr7-0003fU-TG for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2017 15:08:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cukr4-0005gi-NY for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2017 15:08:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59552) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cukr4-0005gW-K4 for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2017 15:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cukr4-0003ae-CP for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2017 15:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Apr 2017 19:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 354 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 354-submit@debbugs.gnu.org id=B354.149116007313781 (code B ref 354); Sun, 02 Apr 2017 19:08:02 +0000 Original-Received: (at 354) by debbugs.gnu.org; 2 Apr 2017 19:07:53 +0000 Original-Received: from localhost ([127.0.0.1]:57751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cukqv-0003aD-FP for submit@debbugs.gnu.org; Sun, 02 Apr 2017 15:07:53 -0400 Original-Received: from mail-io0-f194.google.com ([209.85.223.194]:36263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cukqt-0003Zv-Ka for 354@debbugs.gnu.org; Sun, 02 Apr 2017 15:07:51 -0400 Original-Received: by mail-io0-f194.google.com with SMTP id 68so10300951ioh.3 for <354@debbugs.gnu.org>; Sun, 02 Apr 2017 12:07:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2RMaw7rZMOIwMuv/xz73kAn/e5+l8LhLQY27dvT8rUs=; b=FiMBu5c4SDO7Mj7aLAfQDV24VJaR14P9Fsn3YluucWvK/Kb1VVDE/bIRkt19ueTzme roWglG+s8DZ4Nf2dljeOpW+Nz56AcKVxeB+m5gajtcuVpc+HTlFMm9yb+vn8/tVR22K4 FOQjkAxGJNDzZyx7da8MiTweFC+iKgDH9ZYeKJvhXoIdRQuf5hdYGjoTEscBCEnAM4gZ 3kRj+EMhtuyzcZrfl6knnNee6zwYQkngiExXBwMc/le2LPUtT9Nasua79VlNSGFq+ekN NX6V7X/T0DE025IOeSukirwLoh3+MwLgMZ6YjpyqQq+rHzHPGGJ0E6DxYQyeQOs3lHA/ Yo4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=2RMaw7rZMOIwMuv/xz73kAn/e5+l8LhLQY27dvT8rUs=; b=mIlSZ3BLbxInW6E63JfZUlSRFlkHv2+QoEgmJpwLhIkqZCATKsaXaVk5jUZaGdKQRx +YAzOPkL7GToYIT+IME/aSqxTk3Yl/z/24PJX6jUJBaIhjEE+MTnQB5TsIFg734tV+DV 4VMABu9rND+xNvqqpQBSwKheGT++JDZ/JcuJrkvtnyPPNOJAecMglAtQIx6juToLTEwo 97j4JOAVraYYUAYPZv+danhJyzAjnVDccIuJigWCiPSRZy8xJTEJ/2KlZEw12n/EVpvq P8fx4p4oLz8vyEXrxVy8kDFLLccfZbEHPZ6Pjw9cb7SAaydfaXWGEjga8a3C4CQJv7ix bujg== X-Gm-Message-State: AFeK/H1Cn/bebX5CBQQtKDc6jvRQssJGB0L2a+YyB0UFSGFKJprlSNWj2TMhaQMYEHcyhA== X-Received: by 10.107.185.135 with SMTP id j129mr12446056iof.3.1491160066141; Sun, 02 Apr 2017 12:07:46 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id b132sm6595455iob.6.2017.04.02.12.07.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 02 Apr 2017 12:07:45 -0700 (PDT) In-Reply-To: <4ac2a524-05db-071b-6628-73a5ccad14ce@cs.ucla.edu> (Paul Eggert's message of "Sun, 2 Apr 2017 11:44:34 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131228 Archived-At: Paul Eggert writes: > On 04/02/2017 11:40 AM, npostavs@users.sourceforge.net wrote: >> I'm not sure what you >> mean about "idiomatic English" as both versions produce the same text. > > The old version says "Added to FOO" whereas the new says "Added N > characters of `FOO'". The "to" is more idiomatic than the "of". Oh, huh. Apparently I didn't actually read the original code. I must *really* not like the multi-format string style. But yes, producing a correct message is more important. Here's the fixed code: if (!auto_saving && !noninteractive) { AUTO_STRING (format, NUMBERP (append) ? "Updated %d characters of `%s'" : ! NILP (append) ? "Added %d characters to `%s'" : "Wrote %d characters to `%s'"); CALLN (Fmessage, format, make_number (XINT (end) - XINT (start)), visit_file); }